fix: enforce K8s length limit for redis proxy service name (argoproj-labs#2071) (argoproj-labs#2116)

* fix: enforce K8s length limit for redis proxy service name (argoproj-labs#2071)

Signed-off-by: Tejas Soham <tejassoham05@gmail.com>

* fix: resolve redis proxy service name helper conflict

Signed-off-by: Tejas Soham <tejassoham05@gmail.com>

---------

Signed-off-by: Tejas Soham <tejassoham05@gmail.com>

Author: tzprograms

controllers/argoutil/redis.go

@@ -337,6 +337,9 @@ func loadTemplateFile(path string, params map[string]string) (string, error) {
 	return buf.String(), nil
 }
 
+// GenerateAgentPrincipalRedisProxyServiceName generates a deterministic Service name for the agent's principal Redis proxy.
+// It truncates the Custom Resource (CR) name to ensure the final appended name stays within Kubernetes length limits.
 func GenerateAgentPrincipalRedisProxyServiceName(crName string) string {
-	return fmt.Sprintf("%s-agent-%s", crName, "principal-redisproxy")
+	truncatedCRName := TruncateWithHash(crName, 36)
+	return fmt.Sprintf("%s-agent-%s", truncatedCRName, "principal-redisproxy")
 }

controllers/argoutil/resource_test.go

@@ -22,6 +22,37 @@ import (
 	corev1 "k8s.io/api/core/v1"
 )
 
+func TestGenerateAgentPrincipalRedisProxyServiceName(t *testing.T) {
+	tests := []struct {
+		name     string
+		crName   string
+		expected string
+	}{
+		{
+			name:     "short CR name - no truncation",
+			crName:   "short-name",
+			expected: "short-name-agent-principal-redisproxy",
+		},
+		{
+			name: "long CR name - uses truncated name",
+			// Input matches the test case from TestTruncateCRName
+			crName: "this-is-a-very-long-argocd-instance-name-that-exceeds-37-characters",
+			// Base name is truncated to 36 chars to accommodate the 27 char suffix
+			expected: "this-is-a-very-long-argocd-i-657aacd-agent-principal-redisproxy",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := GenerateAgentPrincipalRedisProxyServiceName(tt.crName)
+			assert.Equal(t, tt.expected, result)
+
+			// Enforce K8s 63-character service name limit
+			assert.LessOrEqual(t, len(result), 63)
+		})
+	}
+}
+
 func TestTruncateWithHash(t *testing.T) {
 	tests := []struct {
 		name        string