Skip to content

Commit a8b366f

Browse files
committed
Remove out extraneous hardcode defaults
1 parent 1df689c commit a8b366f

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

config/config.exs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,15 @@ config :exq,
88
host: "127.0.0.1",
99
port: 6379,
1010
namespace: "exq",
11+
database: 0,
1112
queues: ["default"],
1213
scheduler_enable: true,
1314
concurrency: 100,
1415
scheduler_poll_timeout: 200,
1516
poll_timeout: 100,
1617
redis_timeout: 5000,
1718
genserver_timeout: 5000,
19+
reconnect_on_sleep: 100,
1820
max_retries: 25,
1921
middleware: [Exq.Middleware.Stats, Exq.Middleware.Job, Exq.Middleware.Manager,
2022
Exq.Middleware.Logger]

lib/exq/manager/server.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ defmodule Exq.Manager.Server do
293293
work_table
294294
end
295295

296-
defp add_queue(state, queue, concurrency \\ Config.get(:concurrency, 10_000)) do
296+
defp add_queue(state, queue, concurrency \\ Config.get(:concurrency)) do
297297
queue_concurrency = {queue, concurrency, 0}
298298
:ets.insert(state.work_table, queue_concurrency)
299299
GenServer.cast(self, {:re_enqueue_backup, queue})

lib/exq/support/opts.ex

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ defmodule Exq.Support.Opts do
2828
else
2929
host = opts[:host] || Config.get(:host)
3030
port = opts[:port] || Config.get(:port)
31-
database = opts[:database] || Config.get(:database, 0)
31+
database = opts[:database] || Config.get(:database)
3232
password = opts[:password] || Config.get(:password)
3333
[host: host, port: port, database: database, password: password]
3434
end
35-
reconnect_on_sleep = opts[:reconnect_on_sleep] || Config.get(:reconnect_on_sleep, 100)
35+
reconnect_on_sleep = opts[:reconnect_on_sleep] || Config.get(:reconnect_on_sleep)
3636
timeout = opts[:redis_timeout] || Config.get(:redis_timeout)
3737
{redis_opts, [backoff: reconnect_on_sleep, timeout: timeout, name: opts[:redis]]}
3838
end
@@ -46,7 +46,7 @@ defmodule Exq.Support.Opts do
4646
scheduler_enable = opts[:scheduler_enable] || Config.get(:scheduler_enable)
4747
namespace = opts[:namespace] || Config.get(:namespace)
4848
scheduler_poll_timeout = opts[:scheduler_poll_timeout] || Config.get(:scheduler_poll_timeout)
49-
poll_timeout = opts[:poll_timeout] || Config.get(:poll_timeout, 50)
49+
poll_timeout = opts[:poll_timeout] || Config.get(:poll_timeout)
5050

5151
enqueuer = Exq.Enqueuer.Server.server_name(opts[:name])
5252
stats = Exq.Stats.Server.server_name(opts[:name])
@@ -55,7 +55,7 @@ defmodule Exq.Support.Opts do
5555
middleware = Exq.Middleware.Server.server_name(opts[:name])
5656

5757
queue_configs = opts[:queues] || Config.get(:queues)
58-
per_queue_concurrency = opts[:concurrency] || Config.get(:concurrency, 10_000)
58+
per_queue_concurrency = opts[:concurrency] || Config.get(:concurrency)
5959
queues = get_queues(queue_configs)
6060
concurrency = get_concurrency(queue_configs, per_queue_concurrency)
6161
default_middleware = Config.get(:middleware)

0 commit comments

Comments
 (0)