4XX Level Responses Fail Silently

[derekdowling]

If the response from httpGet returns a non-success status code (ie 401), the library fails silently and returns an empty JSON slice. It'd be great if non-success statuses could be made more evident in some manner, via panic, logging, or some other manner.

I'm uncertain of what your preferences or thoughts on this might be otherwise I'd present a solution to this.

[akira]

Agree that the client should surface those, perhaps as part of the error returned? If you wanted to do a MR, will gladly accept.

Also, just wanted to let you know there is a Go Client implementation from Ken Barber as well, I haven't compared or looked at it in detail: https://github.com/kbarber/puppetdb-client-go