Skip to content

Commit 4c87a1e

Browse files
authored
docs: Fix broken samples #32667 (#32668)
* docs: Fix incorrect sharding sample dependencies #32667 * some fixes to the kafka sample as well * Some more dependency bumps
1 parent bc9758d commit 4c87a1e

File tree

12 files changed

+37
-27
lines changed

12 files changed

+37
-27
lines changed

samples/akka-sample-cluster-scala/build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import com.typesafe.sbt.SbtMultiJvm.MultiJvmKeys.MultiJvm
33

44
val AkkaVersion = "2.10.2"
55
val AkkaDiagnosticsVersion = "2.1.1"
6-
val LogbackClassicVersion = "1.2.11"
6+
val LogbackClassicVersion = "1.5.16"
77
val ScalaTestVersion = "3.2.17"
88

99
lazy val `akka-sample-cluster-scala` = project

samples/akka-sample-distributed-data-scala/build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import com.typesafe.sbt.MultiJvmPlugin.multiJvmSettings
22

33
val AkkaVersion = "2.10.2"
44
val AkkaDiagnosticsVersion = "2.1.1"
5-
val LogbackClassicVersion = "1.2.11"
5+
val LogbackClassicVersion = "1.5.16"
66
val ScalaTestVersion = "3.2.17"
77

88
val `akka-sample-distributed-data-scala` = project

samples/akka-sample-fsm-scala/build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ organization := "com.lightbend.akka.samples"
22
name := "akka-sample-fsm-scala"
33

44
val AkkaVersion = "2.10.2"
5-
val LogbackClassicVersion = "1.2.11"
5+
val LogbackClassicVersion = "1.5.1"
66
val AkkaDiagnosticsVersion = "2.1.0"
77

88
scalaVersion := "2.13.12"

samples/akka-sample-kafka-to-sharding-scala/build.sbt

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,29 @@
11
val AkkaVersion = "2.10.2"
2-
val AlpakkaKafkaVersion = "6.0.0"
3-
val AkkaManagementVersion = "1.5.2"
4-
val AkkaHttpVersion = "10.6.3"
2+
val AlpakkaKafkaVersion = "7.0.1"
3+
val AkkaManagementVersion = "1.6.0"
4+
val AkkaHttpVersion = "10.7.0"
55
val EmbeddedKafkaVersion = "3.7.0"
6-
val LogbackVersion = "1.2.11"
6+
val LogbackVersion = "1.5.16"
77

88
resolvers += "Akka library repository".at("https://repo.akka.io/maven")
99

1010
ThisBuild / scalaVersion := "2.13.15"
1111
ThisBuild / organization := "com.lightbend.akka.samples"
12-
ThisBuild / scalacOptions in Compile ++= Seq(
12+
ThisBuild / Compile / scalacOptions ++= Seq(
1313
"-deprecation",
1414
"-feature",
1515
"-unchecked",
1616
"-Xlog-reflective-calls",
1717
"-Xlint")
18-
ThisBuild / javacOptions in Compile ++= Seq("-Xlint:unchecked", "-Xlint:deprecation")
19-
ThisBuild / testOptions in Test += Tests.Argument("-oDF")
18+
ThisBuild / Test / javacOptions ++= Seq("-Xlint:unchecked", "-Xlint:deprecation")
19+
ThisBuild / Test / testOptions += Tests.Argument("-oDF")
2020
ThisBuild / licenses := Seq(("CC0", url("http://creativecommons.org/publicdomain/zero/1.0")))
2121
ThisBuild / resolvers ++= Seq(
2222
"Akka Snapshots".at("https://repo.akka.io/snapshots"),
2323
Resolver.bintrayRepo("akka", "snapshots"))
2424

25-
run / fork := true
25+
ThisBuild / run / fork := true
26+
ThisBuild / run / connectInput := true
2627

2728
lazy val `akka-sample-kafka-to-sharding` = project.in(file(".")).aggregate(producer, processor, client)
2829

@@ -32,7 +33,7 @@ lazy val kafka = project
3233
resolvers += "Akka library repository".at("https://repo.akka.io/maven"),
3334
libraryDependencies ++= Seq(
3435
"ch.qos.logback" % "logback-classic" % LogbackVersion,
35-
"org.slf4j" % "log4j-over-slf4j" % "1.7.26",
36+
"org.slf4j" % "log4j-over-slf4j" % "2.0.16",
3637
"io.github.embeddedkafka" %% "embedded-kafka" % EmbeddedKafkaVersion),
3738
cancelable := false)
3839

@@ -43,7 +44,9 @@ lazy val client = project
4344
resolvers += "Akka library repository".at("https://repo.akka.io/maven"),
4445
libraryDependencies ++= Seq(
4546
"com.typesafe.akka" %% "akka-stream" % AkkaVersion,
46-
"com.typesafe.akka" %% "akka-discovery" % AkkaVersion))
47+
"com.typesafe.akka" %% "akka-pki" % AkkaVersion,
48+
"com.typesafe.akka" %% "akka-discovery" % AkkaVersion,
49+
"ch.qos.logback" % "logback-classic" % LogbackVersion))
4750

4851
lazy val processor = project
4952
.in(file("processor"))
@@ -67,11 +70,11 @@ lazy val processor = project
6770

6871
lazy val producer = project
6972
.in(file("producer"))
70-
.settings(PB.targets in Compile := Seq(scalapb.gen() -> (sourceManaged in Compile).value))
73+
.settings(Compile / PB.targets := Seq(scalapb.gen() -> (Compile / sourceManaged).value))
7174
.settings(
7275
resolvers += "Akka library repository".at("https://repo.akka.io/maven"),
7376
libraryDependencies ++= Seq(
7477
"com.typesafe.akka" %% "akka-stream-kafka" % AlpakkaKafkaVersion,
7578
"com.typesafe.akka" %% "akka-stream" % AkkaVersion,
76-
"ch.qos.logback" % "logback-classic" % "1.2.11",
79+
"ch.qos.logback" % "logback-classic" % LogbackVersion,
7780
"org.scalatest" %% "scalatest" % "3.2.18" % Test))

samples/akka-sample-kafka-to-sharding-scala/client/src/main/resources/application.conf

Lines changed: 0 additions & 5 deletions
This file was deleted.

samples/akka-sample-kafka-to-sharding-scala/client/src/main/scala/client/ClientApp.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ object ClientApp extends App {
2222
while (userId != ":q") {
2323
println("Enter user id or :q to quit")
2424
userId = StdIn.readLine()
25-
if (userId != ":q") {
25+
if (userId != ":q" && userId != null) {
2626
val runningTotal = Await.result(client.userStats(UserStatsRequest(userId)), Duration.Inf)
2727
println(
2828
s"User ${userId} has made ${runningTotal.totalPurchases} purchases for a total of ${runningTotal.amountSpent}p")

samples/akka-sample-kafka-to-sharding-scala/processor/src/main/scala/sample/sharding/kafka/Main.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ object Main {
9797
Behaviors.stopped
9898
}
9999
.receiveSignal {
100-
case (ctx, Terminated(`processor`)) =>
100+
case (_, Terminated(`processor`)) =>
101101
ctx.log.warn("Kafka event processor stopped. Shutting down")
102102
binding.map(_.unbind())(ctx.executionContext)
103103
Behaviors.stopped
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
resolvers += "Akka library repository".at("https://repo.akka.io/maven")
22

3-
addSbtPlugin("com.lightbend.akka.grpc" % "sbt-akka-grpc" % "2.4.0")
3+
addSbtPlugin("com.lightbend.akka.grpc" % "sbt-akka-grpc" % "2.5.3")

samples/akka-sample-sharding-java/build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11

22
val AkkaVersion = "2.10.2"
3-
val AkkaHttpVersion = "10.6.0"
3+
val AkkaHttpVersion = "10.7.0"
44
val LogbackVersion = "1.2.11"
55

66
resolvers += "Akka library repository".at("https://repo.akka.io/maven")

samples/akka-sample-sharding-java/killrweather-fog/pom.xml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<properties>
2020
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
2121
<akka.version>2.10.2</akka.version>
22-
<akka-http.version>10.6.0</akka-http.version>
22+
<akka-http.version>10.7.0</akka-http.version>
2323
<akka-diagnostics.version>2.1.0</akka-diagnostics.version>
2424
</properties>
2525

@@ -42,6 +42,11 @@
4242
<artifactId>akka-stream-typed_2.13</artifactId>
4343
<version>${akka.version}</version>
4444
</dependency>
45+
<dependency>
46+
<groupId>com.typesafe.akka</groupId>
47+
<artifactId>akka-pki_2.13</artifactId>
48+
<version>${akka.version}</version>
49+
</dependency>
4550
<dependency>
4651
<groupId>com.typesafe.akka</groupId>
4752
<artifactId>akka-serialization-jackson_2.13</artifactId>

0 commit comments

Comments
 (0)