more api rename

Author: sebastian-alfers

akka-cluster-sharding/src/main/scala/akka/cluster/sharding/ShardCoordinator.scala

@@ -648,7 +648,7 @@ object ShardCoordinator {
     private val instrumentation = ClusterShardingInstrumentationProvider.get(context.system).instrumentation
     private val cluster = Cluster(context.system)
 
-    instrumentation.onBeginShardHandoff(cluster.selfAddress, self, typeName, shard)
+    instrumentation.shardHandoffStarted(cluster.selfAddress, self, typeName, shard)
 
     regions.foreach { region =>
       region ! BeginHandOff(shard)
@@ -713,7 +713,7 @@ object ShardCoordinator {
     }
 
     def done(ok: Boolean): Unit = {
-      instrumentation.onFinishedShardHandoff(cluster.selfAddress, self, typeName, shard, ok)
+      instrumentation.shardHandoffFinished(cluster.selfAddress, self, typeName, shard, ok)
       context.parent ! RebalanceDone(shard, ok)
       context.stop(self)
     }

akka-cluster-sharding/src/main/scala/akka/cluster/sharding/ShardRegion.scala

@@ -1298,7 +1298,7 @@ private[akka] class ShardRegion(
       context.system.deadLetters ! msg
     } else {
       shardBuffers.append(shardId, msg, snd)
-      instrumentation.incrementShardRegionBufferSize(cluster.selfAddress, self, typeName)
+      instrumentation.shardRegionBufferSizeIncremented(cluster.selfAddress, self, typeName)
       // log some insight to how buffers are filled up every 10% of the buffer capacity
       val tot = totBufSize + 1
       if (tot % (bufferSize / 10) == 0) {
@@ -1374,7 +1374,7 @@ private[akka] class ShardRegion(
               shardId,
               buf.size + 1)
             shardBuffers.append(shardId, msg, snd)
-            instrumentation.incrementShardRegionBufferSize(cluster.selfAddress, self, typeName)
+            instrumentation.shardRegionBufferSizeIncremented(cluster.selfAddress, self, typeName)
         }
 
       case _ =>

akka-cluster-sharding/src/main/scala/akka/cluster/sharding/internal/ClusterShardingInstrumentation.scala

@@ -88,26 +88,26 @@ class ClusterShardingTelemetryEnsemble(val instrumentations: Seq[ClusterSharding
       size: Int): Unit =
     instrumentations.foreach(_.shardRegionBufferSize(selfAddress, shardRegionActor, typeName, size))
 
-  override def incrementShardRegionBufferSize(
+  override def shardRegionBufferSizeIncremented(
       selfAddress: Address,
       shardRegionActor: ActorRef,
       typeName: String): Unit =
-    instrumentations.foreach(_.incrementShardRegionBufferSize(selfAddress, shardRegionActor, typeName))
+    instrumentations.foreach(_.shardRegionBufferSizeIncremented(selfAddress, shardRegionActor, typeName))
 
-  override def onBeginShardHandoff(
+  override def shardHandoffStarted(
       selfAddress: Address,
       shardCoordinatorActor: ActorRef,
       typeName: String,
       shard: String): Unit =
-    instrumentations.foreach(_.onBeginShardHandoff(selfAddress, shardCoordinatorActor, typeName, shard))
+    instrumentations.foreach(_.shardHandoffStarted(selfAddress, shardCoordinatorActor, typeName, shard))
 
-  override def onFinishedShardHandoff(
+  override def shardHandoffFinished(
       selfAddress: Address,
       shardCoordinatorActor: ActorRef,
       typeName: String,
       shard: String,
       ok: Boolean): Unit =
-    instrumentations.foreach(_.onFinishedShardHandoff(selfAddress, shardCoordinatorActor, typeName, shard, ok))
+    instrumentations.foreach(_.shardHandoffFinished(selfAddress, shardCoordinatorActor, typeName, shard, ok))
 
   override def dependencies: immutable.Seq[String] =
     instrumentations.flatMap(_.dependencies)
@@ -131,18 +131,18 @@ class EmptyClusterShardingInstrumentation extends ClusterShardingInstrumentation
       typeName: String,
       size: Int): Unit = ()
 
-  override def incrementShardRegionBufferSize(
+  override def shardRegionBufferSizeIncremented(
       selfAddress: Address,
       shardRegionActor: ActorRef,
       typeName: String): Unit = ()
 
-  override def onBeginShardHandoff(
+  override def shardHandoffStarted(
       selfAddress: Address,
       shardRegionActor: ActorRef,
       typeName: String,
       shard: String): Unit = ()
 
-  override def onFinishedShardHandoff(
+  override def shardHandoffFinished(
       selfAddress: Address,
       self: ActorRef,
       typeName: String,
@@ -158,19 +158,13 @@ class EmptyClusterShardingInstrumentation extends ClusterShardingInstrumentation
 @InternalStableApi
 trait ClusterShardingInstrumentation {
 
-  /**
-   * @param size set current size of the buffer.
-   */
   def shardRegionBufferSize(selfAddress: Address, shardRegionActor: ActorRef, typeName: String, size: Int): Unit
 
-  /**
-   * Increase the current size of the buffer by one.
-   */
-  def incrementShardRegionBufferSize(selfAddress: Address, shardRegionActor: ActorRef, typeName: String): Unit
+  def shardRegionBufferSizeIncremented(selfAddress: Address, shardRegionActor: ActorRef, typeName: String): Unit
 
-  def onBeginShardHandoff(selfAddress: Address, shardCoordinatorActor: ActorRef, typeName: String, shard: String): Unit
+  def shardHandoffStarted(selfAddress: Address, shardCoordinatorActor: ActorRef, typeName: String, shard: String): Unit
 
-  def onFinishedShardHandoff(
+  def shardHandoffFinished(
       selfAddress: Address,
       shardCoordinatorActor: ActorRef,
       typeName: String,

akka-cluster-sharding/src/multi-jvm/scala/akka/cluster/sharding/ClusterShardingInstrumentationSpecTelemetry.scala

@@ -28,20 +28,20 @@ class ClusterShardingInstrumentationSpecTelemetry(@nowarn("msg=never used") syst
     shardRegionBufferSizeCounter.set(size)
   }
 
-  override def incrementShardRegionBufferSize(
+  override def shardRegionBufferSizeIncremented(
       selfAddress: Address,
       shardRegionActor: ActorRef,
       typeName: String): Unit = {
     shardRegionBufferSizeCounter.incrementAndGet()
   }
 
-  override def onBeginShardHandoff(
+  override def shardHandoffStarted(
       selfAddress: Address,
       shardCoordinatorActor: ActorRef,
       typeName: String,
       shard: String): Unit = beginShardHandoffDurationCounter.incrementAndGet()
 
-  override def onFinishedShardHandoff(
+  override def shardHandoffFinished(
       selfAddress: Address,
       shardCoordinatorActor: ActorRef,
       typeName: String,