Use parasitic context by default in Classic pipe pattern#31917
Open
leviramsey wants to merge 3 commits intoakka:mainfrom
Open
Use parasitic context by default in Classic pipe pattern#31917leviramsey wants to merge 3 commits intoakka:mainfrom
leviramsey wants to merge 3 commits intoakka:mainfrom
Conversation
Contributor
|
I was wondering if it was because a BlockingQueue may be used for a mailbox? |
Contributor
That can be the original reason. I don't think we should risk introducing any problem by changing this. |
Contributor
Author
|
If |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by a side discussion in #31906, makes the default
ExecutionContextfor the Classic pipe pattern for Scala futures theparasitic(aka "same thread") context.The Typed
context.pipeToSelfcounterpart only uses the parasitic context (the Classic pipe pattern is still required for piping a future to an actor that's notself). For Java futures, theExecutionContextsetting has no effect, but the use ofwhenCompletein both Classic and Typed has effectively the same semantics.A local run of MiMa reported no binary issues (a little surprisingly...). Since existing source code is putting a context in the implicit scope (most likely the context/system
dispatcher), new/edited code is required in order to take advantage of this, but this does remove a reason to have an implicitExecutionContextin an actor.