Skip to content

Commit 53780fe

Browse files
committed
IMP fastapi_user_manager: add abstract method to create user
1 parent 1dbc51f commit 53780fe

File tree

1 file changed

+17
-14
lines changed
  • fastapi_user_manager/routers

1 file changed

+17
-14
lines changed

fastapi_user_manager/routers/user.py

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,16 @@
1616
user_router = APIRouter(tags=["user"])
1717

1818

19+
def create_user(env, data):
20+
vals = {
21+
"name": data.name,
22+
"login": data.email,
23+
"phone": data.phone,
24+
"mobile": data.mobile,
25+
}
26+
return env["res.users"].create(vals)
27+
28+
1929
@user_router.post("/user")
2030
def update_user_data(
2131
data: UserSc,
@@ -26,19 +36,18 @@ def update_user_data(
2636
"""
2737
update user personal data of authenticated user
2838
"""
39+
##### /!\ Doit on chercher l'utilisateur via le nom et l'email
40+
##### ou via le mail seulement ?
41+
##### il me semble que cela est spécifique au projet
42+
##### je pense qu'il vaudrait mieux faire une methode spécifique
43+
##### de recherche à surchager dans le projet
2944
user = env["res.users"].search(
3045
[("name", "=", data.name), ("email", "=", data.email)]
3146
)
3247
if user:
3348
return UserSc.from_res_user(user)
3449
else:
35-
vals = {
36-
"name": data.name,
37-
"login": data.email,
38-
"phone": data.phone,
39-
"mobile": data.mobile,
40-
}
41-
user = env["res.users"].create(vals)
50+
user = create_user(env, data)
4251
return UserSc.from_res_user(user)
4352
# helper = env["api.user.router"].new()
4453
# user = helper.create(data)
@@ -82,13 +91,7 @@ def _create_user(self, data: UserSc) -> ResUsers:
8291
if user:
8392
return user
8493
else:
85-
vals = {
86-
"name": data.name,
87-
"email": data.email,
88-
"phone": data.phone,
89-
"mobile": data.mobile,
90-
}
91-
user = self.env["res.users"].create(vals)
94+
user = create_user(self.env, data)
9295
return user
9396

9497
# def _get_user_values(self, data: CustomerUpdate) -> dict:

0 commit comments

Comments
 (0)