Merge pull request #322 from akrherz/260309

260309

Author: akrherz

.github/workflows/build.yml

@@ -62,7 +62,6 @@ jobs:
         python -m pip install . -vv --no-deps
         cp pywwa_settings.json-example pywwa_settings.json
         # This is a bit brittle, but loads some data
-        python util/ugcs_update.py --filename=fz18mr25 --date=2025-03-18
         python util/merge_hvtec_nwsli.py hvtec.list.20251006.csv
         python util/copy_iem_network.py MN_ASOS
         python util/copy_iem_network.py NY_COOP
@@ -72,7 +71,8 @@ jobs:
         sh util/run_examples.sh
         # get pqinsert available as a dummy command
         export PATH=$PATH:$(pwd)/tests/bin
-        python -m pytest -vv --cov=pywwa --cov-report=xml
+        python -m pytest -vv --cov=pywwa
+        python -m coverage xml
 
     - name: Run console scripts without database
       run: |

.pre-commit-config.yaml

@@ -10,14 +10,14 @@ repos:
         types: [python]
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: "v0.15.2"
+    rev: "v0.15.5"
     hooks:
       - id: ruff
         args: [--fix, --exit-non-zero-on-fix]
       - id: ruff-format
 
   - repo: https://github.com/tox-dev/pyproject-fmt
-    rev: 'v2.16.1'
+    rev: 'v2.16.2'
     hooks:
       - id: pyproject-fmt
 

src/pywwa/workflows/generic.py

@@ -1,6 +1,5 @@
 """Generic NWS Product Parser"""
 
-# stdlib
 from datetime import timedelta
 from functools import partial
 
@@ -11,15 +10,14 @@
 from pyiem.nws.ugc import UGCProvider
 from shapely.geometry import MultiPolygon
 
-# Local
 from pywwa import common
 from pywwa.database import get_database, load_nwsli
 from pywwa.ldm import bridge
 
 NWSLI_DICT = {}
 
 
-def process_data(ugc_dict, txn, buf) -> TextProduct:
+def process_data(ugc_dict: dict, txn, buf) -> TextProduct:
     """Actually do some processing"""
 
     # Create our TextProduct instance

src/pywwa/workflows/spc.py

@@ -1,10 +1,8 @@
 """SPC Geo Products Parser!"""
 
-# 3rd Party
 import click
 from pyiem.nws.products.spcpts import parser
 
-# Local
 from pywwa import LOG, common
 from pywwa.database import get_database
 from pywwa.ldm import bridge

tests/workflows/test_spc.py

@@ -0,0 +1,20 @@
+"""Test spc."""
+
+import pytest
+import pytest_twisted
+from pyiem.util import utc
+
+import pywwa
+from pywwa.testing import get_example_file
+from pywwa.workflows import spc
+
+
+@pytest.mark.parametrize("database", ["postgis"])
+@pytest_twisted.inlineCallbacks
+def test_processor(cursor):
+    """Test basic parsing."""
+    data = get_example_file("PTSDY1.txt")
+    pywwa.CTX["utcnow"] = utc(2021, 3, 25, 13, 8)
+    pywwa.CTX["disable_xmpp"] = True
+    prod = spc.real_parser(cursor, data)
+    yield spc.do_jabber(prod)