test: Add test for the sap-logging extensibility links (kyma-project#4343)

* tests: Add test for the sap-logging extensibility links

* adjust title of the it

* adjust comments

* remove additional configmap

Author: mrCherry97

.github/workflows/pull-integration-cluster-k3d.yml

@@ -6,13 +6,13 @@ on:
     paths:
       - '.github/workflows/pull-integration-cluster-k3d.yml'
       - '.github/scripts/**'
-      - "backend/**"
-      - "public/**"
-      - "src/**"
-      - "package.json"
-      - "Makefile"
-      - "Dockerfile*"
-      - "nginx/**"
+      - 'backend/**'
+      - 'public/**'
+      - 'src/**'
+      - 'package.json'
+      - 'Makefile'
+      - 'Dockerfile*'
+      - 'nginx/**'
       - 'resources/**'
       - 'tests/integration/**'
 
@@ -51,6 +51,12 @@ jobs:
         run: |
           kubectl create namespace kyma-system
           (cd examples/busola-web-components && kubectl kustomize . | kubectl apply -n kyma-system -f - )
+      - name: Install sap-logging extensibility example
+        shell: bash
+        run: |
+          kubectl create namespace sap-cloud-logging-integration
+          kubectl apply -f tests/integration/fixtures/sap-logging-secret.yaml
+          kubectl apply -f tests/integration/fixtures/sap-loggging-config-map.yaml
       - name: Run tests
         shell: bash
         run: |

src/sidebar/NavItem.tsx

@@ -72,17 +72,9 @@ export function NavItem({ node, subItem = false }: NavItemProps) {
   ]);
 
   const handleNavigation = () => {
-    if (node.dataSources) {
-      let link =
-        !jsonataError && jsonataLink ? jsonataLink : (node.externalUrl ?? '');
-      link = link.startsWith('http') ? link : `https://${link}`;
-      const newWindow = window.open(link, 'noopener, noreferrer');
-      if (newWindow) newWindow.opener = null;
-    } else if (node.externalUrl) {
-      const link = node.externalUrl.startsWith('http')
-        ? node.externalUrl
-        : `https://${node.externalUrl}`;
-      const newWindow = window.open(link, 'noopener, noreferrer');
+    if (node.dataSources || node.externalUrl) {
+      const link = getURL();
+      const newWindow = window.open(link, '_blank', 'noopener,noreferrer');
       if (newWindow) newWindow.opener = null;
     } else {
       navigateSafely(() => {
@@ -109,11 +101,27 @@ export function NavItem({ node, subItem = false }: NavItemProps) {
     }
   };
 
+  const getURL = () => {
+    let link;
+    if (node.dataSources) {
+      link =
+        !jsonataError && jsonataLink ? jsonataLink : (node.externalUrl ?? '');
+      link = link.startsWith('http') ? link : `https://${link}`;
+    } else if (node.externalUrl) {
+      link = node.externalUrl.startsWith('http')
+        ? node.externalUrl
+        : `https://${node.externalUrl}`;
+    }
+    return link || undefined;
+  };
+
   const propsForNav = {
     icon: node.externalUrl ? 'action' : node.icon,
     text: t(node.label, { defaultValue: node.label }),
     selected: isSelected,
+    href: node.dataSources || node.externalUrl ? getURL() : undefined,
     onClick: (e: Event) => {
+      e.preventDefault();
       e.stopPropagation();
       handleNavigation();
     },

tests/integration/cypress.config.js

@@ -54,6 +54,7 @@ module.exports = defineConfig({
       'tests/cluster/test-command-palette.spec.js',
       'tests/cluster/test-custom-resources.spec.js',
       'tests/cluster/test-navigation-features.spec.js',
+      'tests/extensibility/ext-test-statics-jsonata-links.spec.js',
       'tests/extensibility/ext-test-pizzas.spec.js',
       'tests/extensibility/ext-test-services.spec.js',
       'tests/extensibility/ext-test-variables.spec.js',

tests/integration/fixtures/sap-loggging-config-map.yaml

@@ -0,0 +1,25 @@
+kind: ConfigMap
+apiVersion: v1
+metadata:
+  name: sap-cloud-logging
+  namespace: kube-public
+  labels:
+    busola.io/extension: statics
+    busola.io/extension-version: '0.5'
+data:
+  dataSources: |-
+    clsSecret:
+      resource:
+        kind: Secret
+        version: v1
+        namespace: sap-cloud-logging-integration
+        name: sap-cloud-logging
+  general: |-
+    externalNodes:
+    - category: SAP Cloud Logging
+      icon: display
+      children:
+        - label: "Dashboards"
+          link: "$string('https://') & $base64decode($string($clsSecret().data.'dashboards-endpoint')) & \"/app/dashboards#/view/maintained-by-perfx_kyma-content-package_Kyma-Overview\""
+        - label: "Discover Logs"
+          link: "$string('https://') & $base64decode($string($clsSecret().data.'dashboards-endpoint')) & \"/app/discover?security_tenant=global#/?_g=(filters:!(),refreshInterval:(pause:!t,value:5000),time:(from:now-7d,to:now))&_a=(columns:!(kubernetes.pod_name,kubernetes.container_name,log),index:maintained-by-perfx_kyma-content-package_index-pattern-logs-json-kyma)\""

tests/integration/fixtures/sap-logging-secret.yaml

@@ -0,0 +1,8 @@
+kind: Secret
+apiVersion: v1
+metadata:
+  name: sap-cloud-logging
+  namespace: sap-cloud-logging-integration
+data:
+  dashboards-endpoint: dGVzdA==
+type: Opaque

tests/integration/tests/extensibility/ext-test-statics-jsonata-links.spec.js

@@ -0,0 +1,20 @@
+/// <reference types="cypress" />
+import 'cypress-file-upload';
+
+context('Test Links from Statics - sap-logging example', () => {
+  Cypress.skipAfterFail();
+
+  before(() => {
+    cy.loginAndSelectCluster();
+  });
+
+  it('Check Cluster Overview sap-logging links', () => {
+    cy.wait(500);
+    cy.getLeftNav().contains('SAP Cloud Logging').click();
+
+    cy.get('ui5-side-navigation-sub-item')
+      .contains('Discover Logs')
+      .invoke('attr', 'href')
+      .should('match', /^https:\/\/test\/app/);
+  });
+});