Skip to content

git-push: concurrent promotions retry not working #5286

@etetar

Description

@etetar

Checklist

  • I've searched the issue queue to verify this is not a duplicate bug report.
  • I've included steps to reproduce the bug.
  • I've pasted the output of kargo version.
  • I've pasted logs, if applicable.

Description

It seems the built-in retry functionality is not working for git-push when two stages are trying to concurrently push to the same branch, but different file locations.

The docs state that the step should handle this scenario by doing a pull/rebase up to 50 times be default, but this does not seem to be happening.

No config options for the git-push step are being set other than:

  • path
  • targetBranch

Error:

step "task-1::do-push" met error threshold of 1: error running step "task-1::do-push": error pushing commits to remote: error pushing branch: error executing cmd [/usr/bin/git push origin HEAD:main]: To https://my-repo.git ! [remote rejected] HEAD -> main (incorrect old value provided) error: failed to push some refs to 'https://my-repo.git'

Screenshots

N/A

Steps to Reproduce

Using a remote GitLab project:

  1. Create two stages which run in parallel, writing to the same repo/branch, but to separate file locations.
  2. Trigger promotion for them both through a prior stage: "Promote to downstream"
  3. One of the stages successfully pushes, but the 2nd one fails with the above error.

Version

Kargo: v1.8.1

GitLab: 18.5

Logs

N/A

Metadata

Metadata

Assignees

Labels

area/controllerAffects the (main) controllerkind/bugSomething isn't working as intended; If unsure that something IS a bug, start a discussion insteadpriority/normalThis is the priority for most work

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions