Skip to content

feat(chart): Still create Role/Rolebinding when opting out of creating shared resources namespace #5703

@shiehand

Description

@shiehand

Note: If you're requesting a Helm chart option that may be very niche and not useful to the community at large, please consider using Kustomize to apply "last mile" tweaks to the output of helm template to suit your needs instead.

Checklist

  • I've searched the issue queue to verify this is not a duplicate feature request.
  • I've pasted the output of kargo version, if applicable.
  • I've pasted logs, if applicable.

Proposed Feature

In the Helm Chart, would like the Role/RoleBinding for the shared resources namespace to be still created when createNamespace is set to false.

We can do this by removing the if statement at the start of the Role/RoleBinding templates.
Noticed that this was the case in the cluster-secrets-namespace templates.

Motivation

Similar to #4839, we want to opt out of the chart creating the new shared resources namespace by setting .Values.global.sharedResources.createNamespace to false.
We do this because we have a dedicated process in creating namespaces, so we would like to create the namespace separately and have Kargo use it afterwards.

However the creation of the Role/RoleBinding seems to be also tied to the createNamespace value, thus when opting out we would have to define the Role/RoleBinding ourselves.
I noticed that this was not the case on the cluster-secrets-namespace template and I wonder if the change in the new namespaces templates are unintended.

Thanks for developing a great tool guys!

Metadata

Metadata

Assignees

Labels

kind/enhancementAn entirely new featurekind/proposalIndicates maintainers have not yet committed to a feature requestneeds/areaIssue or PR needs to be labeled to indicate what parts of the code base are affectedneeds/priorityPriority has not yet been determined; a good signal that maintainers aren't fully committed

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions