UEFIHelper: Correct source type for function updates

The decompiler documentation (under Welcome to Help > Ghidra
Functionality > Decompiler > Program Annotations Affecting the
Decompiler) states that the defined parameters are only used by the
decompiler if it is forced (i.e., using a source type other than
default):

  Discovering Parameters

  The input parameter and return value annotations of the function
  prototype, like any variable annotations, can be forcing on the
  Decompiler (see the complete discussion in Forcing Data-types). But
  keep in mind:

    The input parameters and return value are all forced on the
    Decompiler as a unit based on the Signature Source. They are all
    forced if the type is set to anything other than DEFAULT; otherwise
    none of them are forced.

  If the function prototype's annotations are not forcing, the
  Decompiler will attempt to discover the parameters and return value
  using the calling convention. The prototype model underlying the
  calling convention dictates which storage locations can be considered
  as parameters and their formal ordering.

UEFIHelper currently uses SourceType.DEFAULT which causes the signature
updates to be ignored by decompiler. Switch to SourceType.ANALYSIS to
fix this.

Fixes: #40

Author: al3xtjames

ghidra_scripts/UEFIHelper.java

@@ -104,9 +104,9 @@ private void updateFunctionSignature(Function function,
 				currentProgram);
 
 		// Update the function with the generated parameter list and return type.
-		function.setName(definition.getName(), SourceType.DEFAULT);
+		function.setName(definition.getName(), SourceType.ANALYSIS);
 		function.updateFunction(null, returnType, parameters,
-				FunctionUpdateType.DYNAMIC_STORAGE_FORMAL_PARAMS, false, SourceType.DEFAULT);
+				FunctionUpdateType.DYNAMIC_STORAGE_FORMAL_PARAMS, false, SourceType.ANALYSIS);
 	}
 
 	/**
@@ -298,7 +298,7 @@ private void propagateFunctionParameters(DecompInterface decompiler, DecompileOp
 					if (parameters.size() == originalParameters.length) {
 						function.updateFunction(null, null, parameters,
 								FunctionUpdateType.DYNAMIC_STORAGE_FORMAL_PARAMS, false,
-								SourceType.DEFAULT);
+								SourceType.ANALYSIS);
 						println("Updated " + function.getName() + " function signature");
 					} else {
 						Msg.error(this, "Failed to parse " + function.getName() + " parameters");