remove show event (#2023)

Author: alainm23

core/Objects/Item.vala

@@ -1519,12 +1519,11 @@ public class Objects.Item : Objects.BaseObject {
     }
 
     public void move (Objects.Project project, string _section_id) {
-        loading = true;
-        show_item = false;
-
         if (project.source_type == SourceType.LOCAL) {
             _move (project.id, _section_id);
         } else if (project.source_type == SourceType.TODOIST) {
+            loading = true;
+            
             string move_id = project.id;
             string move_type = "project_id";
             if (_section_id != "") {
@@ -1535,7 +1534,6 @@ public class Objects.Item : Objects.BaseObject {
             Services.Todoist.get_default ().move_item.begin (this, move_type, move_id, (obj, res) => {
                 var response = Services.Todoist.get_default ().move_item.end (res);
                 loading = false;
-                show_item = true;
 
                 if (response.status) {
                     _move (project.id, _section_id);
@@ -1544,6 +1542,8 @@ public class Objects.Item : Objects.BaseObject {
                 }
             });
         } else if (project.source_type == SourceType.CALDAV) {
+            loading = true;
+
             move_caldav_recursive.begin (project, _section_id);
         }
     }

src/Views/Today.vala

@@ -326,29 +326,21 @@ public class Views.Today : Adw.Bin {
         signal_map[Services.Store.instance ().item_archived.connect (valid_delete_item)] = Services.Store.instance ();
         signal_map[Services.Store.instance ().item_unarchived.connect (valid_add_item)] = Services.Store.instance ();
 
-        signal_map[Services.EventBus.get_default ().item_moved.connect ((item) => {
-            // Handle existing items that may no longer belong in Today view
+        signal_map[Services.EventBus.get_default ().item_moved.connect ((item, old_project_id, old_section_id, old_parent_id) => {
             if (items.has_key (item.id)) {
-                if (Services.Store.instance ().valid_item_by_date (item, date, false)) {
-                    items[item.id].update_request ();
-                } else {
-                    // Remove item that no longer belongs in today
+                if (!Services.Store.instance ().valid_item_by_date (item, date, false)) {
                     items[item.id].hide_destroy ();
                     items.unset (item.id);
                 }
             }
 
             if (overdue_items.has_key (item.id)) {
-                if (Services.Store.instance ().valid_item_by_overdue (item, date, false)) {
-                    overdue_items[item.id].update_request ();
-                } else {
-                    // Remove item that no longer belongs in overdue
+                if (!Services.Store.instance ().valid_item_by_overdue (item, date, false)) {
                     overdue_items[item.id].hide_destroy ();
                     overdue_items.unset (item.id);
                 }
             }
 
-            // Check if item should be added to Today view (wasn't there before but should be now)
             if (!items.has_key (item.id) &&
                 Services.Store.instance ().valid_item_by_date (item, date, false)) {
                 add_item (item);
@@ -359,7 +351,6 @@ public class Views.Today : Adw.Bin {
                 add_overdue_item (item);
             }
 
-            // Update UI state
             update_headers ();
             check_placeholder ();
             listbox.invalidate_filter ();
@@ -542,7 +533,7 @@ public class Views.Today : Adw.Bin {
         overdue_listbox.invalidate_filter ();
     }
 
-    private void valid_update_item (Objects.Item item) {
+    private void valid_update_item (Objects.Item item, string update_id) {
         if (items.has_key (item.id)) {
             items[item.id].update_request ();
         }