update button

Author: alainm23

core/Objects/Item.vala

@@ -1172,7 +1172,7 @@ public class Objects.Item : Objects.BaseObject {
                     Array<short> values = new Array<short> ();
                     short val;
 
-                    if (due.recurrency_weeks.split (",").length > 0) {
+                    if (due.recurrency_weeks != null && due.recurrency_weeks.split (",").length > 0) {
                         if (due.recurrency_weeks.contains ("1")) {
                             val = (short) 2;
                             values.append_val (val);

core/Services/CalDAV/Core.vala

@@ -278,11 +278,7 @@ public class Services.CalDAV.Core : GLib.Object {
             source.sync_finished ();
             source.last_sync = new GLib.DateTime.now_local ().to_string ();
         } catch (Error e) {
-            var error_msg = e.message ?? "Unknown error";
-            if (error_msg.strip () == "" || error_msg == ".") {
-                error_msg = "Connection timeout or server closed connection";
-            }
-            warning ("Failed to sync: %s", error_msg);
+            warning ("Failed to sync: %s", e.message);
             source.sync_failed ();
         }
     }

core/Services/Chrono/Locales/en/ENCasualDateParser.vala

@@ -31,9 +31,16 @@ namespace Chrono {
 
                 switch (keyword) {
                     case "now":
-                    case "today":
                         date = now;
                         break;
+                    case "today":
+                        date = new DateTime.local (
+                            now.get_year (),
+                            now.get_month (),
+                            now.get_day_of_month (),
+                            0, 0, 0
+                        );
+                        break;
                     case "tonight":
                         date = new DateTime.local (
                             now.get_year (),
@@ -45,13 +52,31 @@ namespace Chrono {
                     case "tomorrow":
                     case "tmr":
                     case "tmrw":
-                        date = now.add_days (1);
+                        var tomorrow = now.add_days (1);
+                        date = new DateTime.local (
+                            tomorrow.get_year (),
+                            tomorrow.get_month (),
+                            tomorrow.get_day_of_month (),
+                            0, 0, 0
+                        );
                         break;
                     case "overmorrow":
-                        date = now.add_days (2);
+                        var overmorrow = now.add_days (2);
+                        date = new DateTime.local (
+                            overmorrow.get_year (),
+                            overmorrow.get_month (),
+                            overmorrow.get_day_of_month (),
+                            0, 0, 0
+                        );
                         break;
                     case "yesterday":
-                        date = now.add_days (-1);
+                        var yesterday = now.add_days (-1);
+                        date = new DateTime.local (
+                            yesterday.get_year (),
+                            yesterday.get_month (),
+                            yesterday.get_day_of_month (),
+                            0, 0, 0
+                        );
                         break;
                     case "lastnight":
                         date = new DateTime.local (

core/Services/Chrono/Locales/en/ENMonthNameParser.vala

@@ -97,6 +97,11 @@ namespace Chrono {
                     }
                 }
 
+                // Validate year - must be 4 digits or 2 digits (will be converted to 20xx)
+                if (year < 1000 && year >= 100) {
+                    return null;
+                }
+                
                 var result = new ParseResult ();
                 result.date = new DateTime.local (year, month, day, 0, 0, 0);
 

core/Services/Chrono/Locales/en/ENRelativeDateFormatParser.vala

@@ -68,6 +68,7 @@ namespace Chrono {
         }
 
         private DateTime add_time_unit (DateTime date, TimeUnit unit, int amount) {
+            DateTime result;
             switch (unit) {
                 case TimeUnit.SECOND:
                     return date.add_seconds (amount);
@@ -76,15 +77,20 @@ namespace Chrono {
                 case TimeUnit.HOUR:
                     return date.add_hours (amount);
                 case TimeUnit.DAY:
-                    return date.add_days (amount);
+                    result = date.add_days (amount);
+                    return new DateTime.local (result.get_year (), result.get_month (), result.get_day_of_month (), 0, 0, 0);
                 case TimeUnit.WEEK:
-                    return date.add_weeks (amount);
+                    result = date.add_weeks (amount);
+                    return new DateTime.local (result.get_year (), result.get_month (), result.get_day_of_month (), 0, 0, 0);
                 case TimeUnit.MONTH:
-                    return date.add_months (amount);
+                    result = date.add_months (amount);
+                    return new DateTime.local (result.get_year (), result.get_month (), result.get_day_of_month (), 0, 0, 0);
                 case TimeUnit.QUARTER:
-                    return date.add_months (amount * 3);
+                    result = date.add_months (amount * 3);
+                    return new DateTime.local (result.get_year (), result.get_month (), result.get_day_of_month (), 0, 0, 0);
                 case TimeUnit.YEAR:
-                    return date.add_years (amount);
+                    result = date.add_years (amount);
+                    return new DateTime.local (result.get_year (), result.get_month (), result.get_day_of_month (), 0, 0, 0);
                 default:
                     return date;
             }

core/Utils/Datetime.vala

@@ -259,7 +259,7 @@ public class Utils.Datetime {
                 recurrency_weeks += "6,";
             }
 
-            if (recurrency_weeks.split (",").length > 0) {
+            if (recurrency_weeks != null && recurrency_weeks.split (",").length > 0) {
                 recurrency_weeks.slice (0, -1);
             }
 
@@ -344,6 +344,10 @@ public class Utils.Datetime {
     }
 
     public static int get_next_day_of_week_from_recurrency_week (GLib.DateTime datetime, Objects.DueDate duedate) {
+        if (duedate.recurrency_weeks == null || duedate.recurrency_weeks == "") {
+            return datetime.get_day_of_week ();
+        }
+        
         string[] weeks = duedate.recurrency_weeks.split (",");
         int day_of_week = datetime.get_day_of_week ();
         int index = 0;
@@ -363,6 +367,10 @@ public class Utils.Datetime {
     }
 
     public static GLib.DateTime next_recurrency_week (GLib.DateTime datetime, Objects.DueDate duedate, bool user = false) {
+        if (duedate.recurrency_weeks == null || duedate.recurrency_weeks == "") {
+            return datetime.add_days (duedate.recurrency_interval * 7);
+        }
+        
         string[] weeks = duedate.recurrency_weeks.split (","); // [1, 2, 3]
         int day_of_week = datetime.get_day_of_week (); // 2
         int days = 0;
@@ -397,7 +405,7 @@ public class Utils.Datetime {
         string returned = recurrency_type.to_friendly_string (recurrency_interval);
 
         if (recurrency_type == RecurrencyType.EVERY_WEEK &&
-            recurrency_weeks.split (",").length > 0) {
+            recurrency_weeks != null && recurrency_weeks.split (",").length > 0) {
             string weeks = "";
             if (recurrency_weeks.contains ("1")) {
                 weeks += _("Mo,");