Skip to content

Commit b596d85

Browse files
pgritactions-useralainm23
authored
Fix manual ordering sync with CalDav / Nextcloud (#2227)
* set child_order from creation time * Update translations --------- Co-authored-by: Planify Bot <actions@github.com> Co-authored-by: Alain <alainmh23@gmail.com>
1 parent 23929c6 commit b596d85

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

86 files changed

+180
-170
lines changed

‎core/Objects/Item.vala‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -538,6 +538,16 @@ public class Objects.Item : Objects.BaseObject {
538538
if (sort_order_str != null) {
539539
child_order = int.parse (sort_order_str);
540540
}
541+
} else {
542+
// Items without an X-APPLE-SORT-ORDER must use the time in seconds
543+
// since 2001-01-01-00:00:00 (978307200L) as their sort order
544+
ICal.Property ? created_property = ical_vtodo.get_first_property (ICal.PropertyKind.CREATED_PROPERTY);
545+
if (created_property != null) {
546+
var create_time = (long) created_property.get_created ().as_timet ();
547+
child_order = (int)(create_time - 978307200L);
548+
} else {
549+
// TODO should probably emit a warning that manual sorting will not work?
550+
}
541551
}
542552

543553
ICal.Property ? pinned_property = ical_vtodo.get_first_property (ICal.PropertyKind.from_string ("X-PINNED"));

‎po/af.po‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,11 +310,11 @@ msgstr ""
310310
msgid "unlabeled"
311311
msgstr ""
312312

313-
#: core/Objects/Item.vala:1374
313+
#: core/Objects/Item.vala:1384
314314
msgid "Task copied to clipboard"
315315
msgstr ""
316316

317-
#: core/Objects/Item.vala:1667 core/Utils/Util.vala:885
317+
#: core/Objects/Item.vala:1677 core/Utils/Util.vala:885
318318
#: src/Widgets/MultiSelectToolbar.vala:376
319319
#: src/Widgets/MultiSelectToolbar.vala:379
320320
#, c-format

‎po/ak.po‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,11 +310,11 @@ msgstr ""
310310
msgid "unlabeled"
311311
msgstr ""
312312

313-
#: core/Objects/Item.vala:1374
313+
#: core/Objects/Item.vala:1384
314314
msgid "Task copied to clipboard"
315315
msgstr ""
316316

317-
#: core/Objects/Item.vala:1667 core/Utils/Util.vala:885
317+
#: core/Objects/Item.vala:1677 core/Utils/Util.vala:885
318318
#: src/Widgets/MultiSelectToolbar.vala:376
319319
#: src/Widgets/MultiSelectToolbar.vala:379
320320
#, c-format

‎po/ar.po‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -335,11 +335,11 @@ msgstr "لا اسم"
335335
msgid "unlabeled"
336336
msgstr "غير مسمى"
337337

338-
#: core/Objects/Item.vala:1374
338+
#: core/Objects/Item.vala:1384
339339
msgid "Task copied to clipboard"
340340
msgstr "تم نسخ المهمة الى الحافظة"
341341

342-
#: core/Objects/Item.vala:1667 core/Utils/Util.vala:885
342+
#: core/Objects/Item.vala:1677 core/Utils/Util.vala:885
343343
#: src/Widgets/MultiSelectToolbar.vala:376
344344
#: src/Widgets/MultiSelectToolbar.vala:379
345345
#, fuzzy, c-format

‎po/az.po‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,11 +310,11 @@ msgstr ""
310310
msgid "unlabeled"
311311
msgstr ""
312312

313-
#: core/Objects/Item.vala:1374
313+
#: core/Objects/Item.vala:1384
314314
msgid "Task copied to clipboard"
315315
msgstr ""
316316

317-
#: core/Objects/Item.vala:1667 core/Utils/Util.vala:885
317+
#: core/Objects/Item.vala:1677 core/Utils/Util.vala:885
318318
#: src/Widgets/MultiSelectToolbar.vala:376
319319
#: src/Widgets/MultiSelectToolbar.vala:379
320320
#, c-format

‎po/be.po‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,11 +317,11 @@ msgstr ""
317317
msgid "unlabeled"
318318
msgstr ""
319319

320-
#: core/Objects/Item.vala:1374
320+
#: core/Objects/Item.vala:1384
321321
msgid "Task copied to clipboard"
322322
msgstr ""
323323

324-
#: core/Objects/Item.vala:1667 core/Utils/Util.vala:885
324+
#: core/Objects/Item.vala:1677 core/Utils/Util.vala:885
325325
#: src/Widgets/MultiSelectToolbar.vala:376
326326
#: src/Widgets/MultiSelectToolbar.vala:379
327327
#, c-format

‎po/bg.po‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -312,13 +312,13 @@ msgstr "без етикет"
312312
msgid "unlabeled"
313313
msgstr "без етикет"
314314

315-
#: core/Objects/Item.vala:1374
315+
#: core/Objects/Item.vala:1384
316316
msgid "Task copied to clipboard"
317317
msgstr "Задачата е копирана в буфера за обмен"
318318

319319
# c-format
320320
# c-format
321-
#: core/Objects/Item.vala:1667 core/Utils/Util.vala:885
321+
#: core/Objects/Item.vala:1677 core/Utils/Util.vala:885
322322
#: src/Widgets/MultiSelectToolbar.vala:376
323323
#: src/Widgets/MultiSelectToolbar.vala:379
324324
#, fuzzy, c-format

‎po/bn.po‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,11 +310,11 @@ msgstr ""
310310
msgid "unlabeled"
311311
msgstr ""
312312

313-
#: core/Objects/Item.vala:1374
313+
#: core/Objects/Item.vala:1384
314314
msgid "Task copied to clipboard"
315315
msgstr ""
316316

317-
#: core/Objects/Item.vala:1667 core/Utils/Util.vala:885
317+
#: core/Objects/Item.vala:1677 core/Utils/Util.vala:885
318318
#: src/Widgets/MultiSelectToolbar.vala:376
319319
#: src/Widgets/MultiSelectToolbar.vala:379
320320
#, c-format

‎po/bs.po‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,11 +317,11 @@ msgstr ""
317317
msgid "unlabeled"
318318
msgstr ""
319319

320-
#: core/Objects/Item.vala:1374
320+
#: core/Objects/Item.vala:1384
321321
msgid "Task copied to clipboard"
322322
msgstr ""
323323

324-
#: core/Objects/Item.vala:1667 core/Utils/Util.vala:885
324+
#: core/Objects/Item.vala:1677 core/Utils/Util.vala:885
325325
#: src/Widgets/MultiSelectToolbar.vala:376
326326
#: src/Widgets/MultiSelectToolbar.vala:379
327327
#, c-format

‎po/ca.po‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,11 +310,11 @@ msgstr "sense etiqueta"
310310
msgid "unlabeled"
311311
msgstr "sense etiquetar"
312312

313-
#: core/Objects/Item.vala:1374
313+
#: core/Objects/Item.vala:1384
314314
msgid "Task copied to clipboard"
315315
msgstr "Tasca copiada al porta-retalls"
316316

317-
#: core/Objects/Item.vala:1667 core/Utils/Util.vala:885
317+
#: core/Objects/Item.vala:1677 core/Utils/Util.vala:885
318318
#: src/Widgets/MultiSelectToolbar.vala:376
319319
#: src/Widgets/MultiSelectToolbar.vala:379
320320
#, c-format

0 commit comments

Comments
 (0)