Autoemulate.compare: proposed fix for issue #222 (#224)

* Autoemulate.compare: proposed fix for issue #222

* Update autoemulate/compare.py

comment re indentation

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update autoemulate/compare.py

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Autoemulate.compare: response to comment - removed unnecessary block.

* tests/test_compare.py: added test to check hyperparameters are correctly updated

* Update tests/test_compare.py

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* tests: applying automatic suggestion

* test passing pre-commit locally

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: MaxBalmus

autoemulate/compare.py

@@ -230,7 +230,7 @@ def compare(self):
                             X=self.X[self.train_idxs],
                             y=self.y[self.train_idxs],
                             cv=self.cross_validator,
-                            model=model,
+                            model=self.models[i],
                             metrics=self.metrics,
                             n_jobs=self.n_jobs,
                             logger=self.logger,

tests/test_compare.py

@@ -162,3 +162,24 @@ def test_refit_models(ae_run):
     models = ae_run.refit_models()
     assert models is not None
     assert len(models) == len(ae_run.models)
+
+
+# --------------- test correct hyperparameter updating ------------------
+def test_param_search_updates_models(ae, Xy):
+    X, y = Xy
+    ae.setup(
+        X, y, model_subset=["RandomForest"], param_search=True, param_search_iters=5
+    )
+    params_before = ae.models[0].get_params()  # just one model, so index with 0
+    ae.compare()
+    params_after = ae.models[0].get_params()
+    assert params_before != params_after
+
+
+def test_model_params_equal_wo_param_search(ae, Xy):
+    X, y = Xy
+    ae.setup(X, y, model_subset=["RandomForest"])
+    params_before = ae.models[0].get_params()
+    ae.compare()
+    params_after = ae.models[0].get_params()
+    assert params_before == params_after