Skip to content

Commit 33e26d8

Browse files
committed
♻️ Rename data_processors.ZebraDataset to data_processors.ZebraDataProcessor to avoid duplicated class names
1 parent 8c804e3 commit 33e26d8

3 files changed

Lines changed: 10 additions & 8 deletions

File tree

ice_station_zebra/data_processors/cli.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from ice_station_zebra.cli import hydra_adaptor
77

8-
from .zebra_dataset_factory import ZebraDatasetFactory
8+
from .zebra_data_processor_factory import ZebraDataProcessorFactory
99

1010
# Create the typer app
1111
datasets_cli = typer.Typer(help="Manage datasets")
@@ -17,7 +17,7 @@
1717
@hydra_adaptor
1818
def create(config: DictConfig) -> None:
1919
"""Create all datasets"""
20-
factory = ZebraDatasetFactory(config)
20+
factory = ZebraDataProcessorFactory(config)
2121
for dataset in factory.datasets:
2222
log.info(f"Working on {dataset.name}")
2323
dataset.create()
@@ -27,7 +27,7 @@ def create(config: DictConfig) -> None:
2727
@hydra_adaptor
2828
def inspect(config: DictConfig) -> None:
2929
"""Inspect all datasets"""
30-
factory = ZebraDatasetFactory(config)
30+
factory = ZebraDataProcessorFactory(config)
3131
for dataset in factory.datasets:
3232
log.info(f"Working on {dataset.name}")
3333
dataset.inspect()

ice_station_zebra/data_processors/zebra_dataset.py renamed to ice_station_zebra/data_processors/zebra_data_processor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
log = logging.getLogger(__name__)
1616

1717

18-
class ZebraDataset:
18+
class ZebraDataProcessor:
1919
def __init__(
2020
self, name: str, config: DictConfig, cls_preprocessor: Type[IPreprocessor]
2121
) -> None:

ice_station_zebra/data_processors/zebra_dataset_factory.py renamed to ice_station_zebra/data_processors/zebra_data_processor_factory.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,23 @@
11
from omegaconf import DictConfig
22

33
from .preprocessors import IceNetSICPreprocessor, NullPreprocessor
4-
from .zebra_dataset import ZebraDataset
4+
from .zebra_data_processor import ZebraDataProcessor
55

66

7-
class ZebraDatasetFactory:
7+
class ZebraDataProcessorFactory:
88
preprocessors = {
99
"None": NullPreprocessor,
1010
"IceNetSIC": IceNetSICPreprocessor,
1111
}
1212

1313
def __init__(self, config: DictConfig) -> None:
14-
self.datasets: list[ZebraDataset] = []
14+
self.datasets: list[ZebraDataProcessor] = []
1515
for dataset_name in config["datasets"]:
1616
cls_preprocessor = self.preprocessors[
1717
config["datasets"][dataset_name]
1818
.get("preprocessor", {})
1919
.get("type", "None")
2020
]
21-
self.datasets.append(ZebraDataset(dataset_name, config, cls_preprocessor))
21+
self.datasets.append(
22+
ZebraDataProcessor(dataset_name, config, cls_preprocessor)
23+
)

0 commit comments

Comments
 (0)