♻️ Separate preprocessors

Author: jemrobinson

ice_station_zebra/data_processors/preprocessors/__init__.py

@@ -1,5 +1,6 @@
-from .base import IPreprocessor, NullPreprocessor
 from .icenet_sic import IceNetSICPreprocessor
+from .ipreprocessor import IPreprocessor
+from .null import NullPreprocessor
 
 __all__ = [
     "IPreprocessor",

ice_station_zebra/data_processors/preprocessors/icenet_sic.py

@@ -7,7 +7,7 @@
 from icenet.data.sic.osisaf import SICDownloader
 from omegaconf import DictConfig
 
-from .base import IPreprocessor
+from .ipreprocessor import IPreprocessor
 
 logger = logging.getLogger(__name__)
 

…ra/data_processors/preprocessors/base.py …rocessors/preprocessors/ipreprocessor.pyice_station_zebra/data_processors/preprocessors/base.py renamed to ice_station_zebra/data_processors/preprocessors/ipreprocessor.py ice_station_zebra/data_processors/preprocessors/base.py renamed to ice_station_zebra/data_processors/preprocessors/ipreprocessor.py

@@ -1,4 +1,4 @@
-from collections.abc import ABC, abstractmethod
+from abc import ABC, abstractmethod
 from pathlib import Path
 
 from omegaconf import DictConfig
@@ -13,7 +13,3 @@ def __init__(self, config: DictConfig) -> None:
     @abstractmethod
     def download(self, preprocessor_path: Path) -> None:
         """Download data to the specified preprocessor path."""
-
-
-class NullPreprocessor(IPreprocessor):
-    pass

ice_station_zebra/data_processors/preprocessors/null.py

@@ -0,0 +1,9 @@
+from pathlib import Path
+
+from .ipreprocessor import IPreprocessor
+
+
+class NullPreprocessor(IPreprocessor):
+    def download(self, preprocessor_path: Path) -> None:  # noqa: ARG002
+        """NullPreprocessor does not download any data."""
+        return