Skip to content

Make easier to check if configuration should be saved #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make easier to check if configuration should be saved #60

wants to merge 2 commits into from

Conversation

@gmag11
Copy link
Contributor

@gmag11 gmag11 commented Oct 24, 2019

This implements a flag to let user code to check if configuration has to be saved. This makes possible to work without the need of _savecallback implementation

@gmag11
Copy link
Contributor Author

gmag11 commented Oct 24, 2019

If this PR is merged together with #59 a small conflict has to be solved.

<<<<<<< HEAD
		if (!connectedDuringConfigPortal && _savecallback != NULL) {
=======
		_shouldSaveConfig = true;
		if ( _savecallback != NULL) {
>>>>>>> feature/save_config_flag

@alanswx
Copy link
Owner

alanswx commented Aug 20, 2021

do we still need this? sorry i missed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gmag11 @alanswx