Skip to content

Commit 637e2c4

Browse files
committed
initial test, debugging time out error
1 parent ad6217a commit 637e2c4

File tree

2 files changed

+41
-1
lines changed

2 files changed

+41
-1
lines changed

tests/observability/metrics/conftest.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -619,3 +619,13 @@ def aaq_resource_hard_limit_and_used(application_aware_resource_quota):
619619
for key, value in resource_used.items()
620620
}
621621
return formatted_hard_limit, formatted_used_value
622+
623+
624+
@pytest.fixture()
625+
def initial_virt_operator_ready_status_restored(prometheus, initial_metric_value):
626+
yield
627+
validate_metrics_value(
628+
prometheus=prometheus,
629+
expected_value=str(initial_metric_value),
630+
metric_name="sum(kubevirt_virt_operator_ready_status)",
631+
)

tests/observability/metrics/test_vms_metrics.py

Lines changed: 31 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@
3333
MIGRATION_POLICY_VM_LABEL,
3434
TIMEOUT_2MIN,
3535
TIMEOUT_3MIN,
36+
TIMEOUT_4MIN,
37+
TIMEOUT_15SEC,
3638
TIMEOUT_30SEC,
3739
USED,
3840
)
@@ -506,6 +508,34 @@ def test_kubevirt_vmi_phase_transition_from_deletion_seconds_sum_windows(
506508
):
507509
validate_metric_value_greater_than_initial_value(
508510
prometheus=prometheus,
509-
metric_name=KUBEVIRT_VMI_PHASE_TRANSITION_TIME_FROM_DELETION_SECONDS_SUM_SUCCEEDED,
511+
metric_name="kubevirt_virt_operator_ready_status",
510512
initial_value=initial_metric_value,
511513
)
514+
515+
516+
class TestVirtOperatorReadyStatus:
517+
@pytest.mark.parametrize(
518+
"initial_metric_value",
519+
[
520+
pytest.param(
521+
"sum(kubevirt_virt_operator_ready_status)",
522+
marks=pytest.mark.polarion("CNV-99999"),
523+
)
524+
],
525+
indirect=True,
526+
)
527+
def test_kubevirt_virt_operator_ready_status(
528+
self, prometheus, initial_metric_value, initial_virt_operator_ready_status_restored, disabled_virt_operator
529+
):
530+
try:
531+
for sample in TimeoutSampler(
532+
wait_timeout=TIMEOUT_4MIN,
533+
sleep=TIMEOUT_15SEC,
534+
func=prometheus.query,
535+
query="kubevirt_virt_operator_ready_status",
536+
):
537+
if not sample:
538+
break
539+
except TimeoutExpiredError:
540+
LOGGER.info(f"Expected no virt operator pods to be ready, but got {sample}")
541+
raise

0 commit comments

Comments
 (0)