fixed syntax errors and logic

Author: albarker-rh

tests/observability/metrics/conftest.py

@@ -627,7 +627,9 @@ def virt_api_pods(admin_client, hco_namespace):
     wait_for_pod_running_by_prefix(
         admin_client=admin_client, namespace_name=hco_namespace.name, pod_prefix="virt-api", expected_number_of_pods=2
     )
-    pods = get_pod_by_name_prefix(dyn_client=admin_client, pod_prefix="virt-api", namespace=hco_namespace.name)
+    pods = get_pod_by_name_prefix(
+        dyn_client=admin_client, pod_prefix="virt-api", namespace=hco_namespace.name, get_all=True
+    )
     return pods
 
 

tests/observability/metrics/test_vms_metrics.py

@@ -528,15 +528,16 @@ def test_kubevirt_vm_created_by_pod_total(
         for pod in virt_api_pods:
             metric_query = f"{KUBEVIRT_VM_CREATED_BY_POD_TOTAL}{{pod='{pod.name}',namespace='{pod.namespace}'}}"
             current_values[pod.name] = int(get_metrics_value(prometheus=prometheus, metrics_name=metric_query))
-            if initial_values[pod.name] == current_values[pod.name]:
+            if current_values[pod.name] == initial_values[pod.name]:
                 continue
-            if not is_increase_found and initial_values[pod.name] == current_values[pod.name] + 1:
+            if not is_increase_found and current_values[pod.name] == initial_values[pod.name] + 1:
                 is_increase_found = True
                 continue
-            raise LOGGER.error(
+            LOGGER.error(
                 f"Metrics value: {current_values[pod.name]},"
                 f"expected: {initial_values[pod.name]} or {initial_values[pod.name] + 1},"
                 f"initial values: {initial_values}"
             )
+            return
 
         LOGGER.info("One metric value increased correctly!")