[applications] Send telemetry about available terminals

Author: ManuelSchneid3r

applications/CMakeLists.txt

@@ -1,7 +1,7 @@
 cmake_minimum_required(VERSION 3.16)
 find_package(Albert REQUIRED)
 
-project(applications VERSION 13.7)
+project(applications VERSION 13.8)
 
 file(GLOB_RECURSE I18N_SOURCES src/*)
 

applications/src/xdg/application.cpp

@@ -20,9 +20,12 @@ Application::Application(const QString &id, const QString &path, ParseOptions po
     // Post a warning on unsupported terminals
     try {
         if (ranges::any_of(p.getString(root_section, QStringLiteral("Categories")).split(';', Qt::SkipEmptyParts),
-                           [&](const auto &cat){ return cat == QStringLiteral("TerminalEmulator"); })
-            && !Plugin::exec_args.contains(id))
-            WARN << QString("Terminal '%1' not supported. Please post an issue.").arg(id);
+                           [&](const auto &cat){ return cat == QStringLiteral("TerminalEmulator"); }))
+        {
+            is_terminal_ = true;
+            if (!Plugin::exec_args.contains(id))
+                WARN << QString("Terminal '%1' not supported. Please post an issue.").arg(id);
+        }
     } catch (const out_of_range &) { }
 
     // Type - string, REQUIRED to be Application
@@ -210,6 +213,8 @@ const QStringList &Application::exec() const
     return exec_;
 }
 
+bool Application::isTerminal() const { return is_terminal_; }
+
 void Application::launchExec(const QStringList &exec, QUrl url, const QString &working_dir) const
 {
     auto commandline = fieldCodesExpanded(exec, url);

applications/src/xdg/application.h

@@ -29,6 +29,8 @@ class Application : public ApplicationBase
 
     const QStringList &exec() const;
 
+    bool isTerminal() const;
+
 protected:
 
     void launchExec(const QStringList &exec, QUrl url, const QString &working_dir) const;
@@ -51,5 +53,6 @@ class Application : public ApplicationBase
     QString working_dir_;
     std::vector<DesktopAction> desktop_actions_;
     bool term_ = false;
+    bool is_terminal_ = false;
 
 };

applications/src/xdg/plugin.cpp

@@ -209,3 +209,15 @@ void Plugin::runTerminal(QStringList commandline, const QString working_dir) con
 {
     terminal->launch(commandline, working_dir);
 }
+
+QJsonObject Plugin::telemetryData() const
+{
+    QJsonObject t;
+    for (const auto &iapp : applications)
+        if (const auto &app = static_pointer_cast<::Application>(iapp); app->isTerminal())
+            t.insert(app->id(), app->exec().join(" "));
+
+    QJsonObject o;
+    o.insert("terminals", t);
+    return o;
+}

applications/src/xdg/plugin.h

@@ -3,8 +3,10 @@
 #pragma once
 #include "pluginbase.h"
 #include <QStringList>
+#include <albert/telemetryprovider.h>
 
-class Plugin : public PluginBase
+class Plugin : public PluginBase,
+               public albert::TelemetryProvider
 {
     ALBERT_PLUGIN
 
@@ -16,6 +18,9 @@ class Plugin : public PluginBase
     // albert::ExtensionPlugin
     QWidget *buildConfigWidget() override;
 
+    // albert::TelemetryProvider
+    QJsonObject telemetryData() const override;
+
     using PluginBase::runTerminal;
 
     void runTerminal(QStringList commandline, const QString working_dir = {}) const;