iOS: Possible Daylight savings issue

[alberto234]

On Sunday March 13, 2016. It was "spring forward" in the US.

Select an end time for Sunday, say 5pm.

When it is saved and retrieved, end time changes from 5pm to 6pm.

This is a bug. However, a question that arises is how prevalent is this? Is it just for the Sunday schedule? What happens for days beyond March 13? Will test those and enter findings in this ticket.

[alberto234]

This issue occurrs because when we are updating a schedule time using the UI, the SAM is basing the date off of the initial date that the schedule was created, and appending the time that we selected to it. So if the the schedule was created in February and we are making a change in May, the SAM will perform calculations using the date in February. When the SAM then calculates when the next alarm time in May should be, that time is one hour off.

There is a comment in the code where it is suggested that we should be using NSCalendar arithmetic. We are currently computing the next alarm time by increasing the previous alarm time by the repeat interval in seconds. This computation is prone to the errors that we are seeing here.