Merge pull request #9 from aldy505/perf/builder

perf: migrate bytes.Buffer to strings.Builder for micro optimization

Author: Reinaldy Rafli

create.go

@@ -1,7 +1,6 @@
 package bob
 
 import (
-	"bytes"
 	"errors"
 	"strings"
 
@@ -205,7 +204,7 @@ func (d *createData) ToSql() (sqlStr string, args []interface{}, err error) {
 		return
 	}
 
-	sql := &bytes.Buffer{}
+	var sql strings.Builder
 
 	sql.WriteString("CREATE TABLE ")
 

has.go

@@ -1,8 +1,8 @@
 package bob
 
 import (
-	"bytes"
 	"errors"
+	"strings"
 
 	"github.com/lann/builder"
 )
@@ -50,7 +50,7 @@ func (h HasBuilder) ToSql() (string, []interface{}, error) {
 
 // ToSql returns 3 variables filled out with the correct values based on bindings, etc.
 func (d *hasData) ToSql() (sqlStr string, args []interface{}, err error) {
-	sql := &bytes.Buffer{}
+	var sql strings.Builder
 	if d.Name == "" {
 		err = errors.New("has statement should have a table name")
 		return

internal.go

@@ -14,21 +14,21 @@ func createArgs(keys ...interface{}) []interface{} {
 }
 
 // isIn checks if an array have a value
-func isIn(arr []string, value string) bool {
-	for _, item := range arr {
-		if item == value {
-			return true
-		}
-	}
-	return false
-}
+// func isIn(arr []string, value string) bool {
+// 	for _, item := range arr {
+// 		if item == value {
+// 			return true
+// 		}
+// 	}
+// 	return false
+// }
 
-// findPosition search for value position on an array
-func findPosition(arr []string, value string) int {
-	for i, item := range arr {
-		if item == value {
-			return i
-		}
-	}
-	return -1
-}
+// // findPosition search for value position on an array
+// func findPosition(arr []string, value string) int {
+// 	for i, item := range arr {
+// 		if item == value {
+// 			return i
+// 		}
+// 	}
+// 	return -1
+// }

upsert.go

@@ -1,7 +1,6 @@
 package bob
 
 import (
-	"bytes"
 	"errors"
 	"strings"
 
@@ -98,7 +97,7 @@ func (d *upsertData) ToSql() (sqlStr string, args []interface{}, err error) {
 		return
 	}
 
-	sql := &bytes.Buffer{}
+	var sql strings.Builder
 
 	if d.Dialect == MSSQL {
 		if len(d.Key) == 0 {