Fix launchDaemonOS signature for Windows

alebeck · alebeck · commit 73e76d497691 · 2026-03-15T18:22:58.000Z
diff --git a/cmd/boring/daemon_windows.go b/cmd/boring/daemon_windows.go
@@ -11,15 +11,15 @@ import (
 
 const DETACHED_PROCESS = 0x00000008
 
-func launchDaemonOS(name string, arg ...string) error {
+func launchDaemonOS(name string, arg ...string) (int, error) {
 	cmd := exec.Command(name, arg...)
 	cmd.SysProcAttr = &syscall.SysProcAttr{
 		CreationFlags: syscall.CREATE_NEW_PROCESS_GROUP | DETACHED_PROCESS,
 	}
 
 	if err := cmd.Start(); err != nil {
-		return err
+		return 0, err
 	}
 	log.Debugf("Daemon started with PID %d", cmd.Process.Pid)
-	return nil
+	return cmd.Process.Pid, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -11,15 +11,15 @@ import (`
`11`	`11`
`12`	`12`	`const DETACHED_PROCESS = 0x00000008`
`13`	`13`
`14`		`-func launchDaemonOS(name string, arg ...string) error {`
	`14`	`+func launchDaemonOS(name string, arg ...string) (int, error) {`
`15`	`15`	`cmd := exec.Command(name, arg...)`
`16`	`16`	`cmd.SysProcAttr = &syscall.SysProcAttr{`
`17`	`17`	`CreationFlags: syscall.CREATE_NEW_PROCESS_GROUP \| DETACHED_PROCESS,`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`if err := cmd.Start(); err != nil {`
`21`		`- return err`
	`21`	`+ return 0, err`
`22`	`22`	`}`
`23`	`23`	`log.Debugf("Daemon started with PID %d", cmd.Process.Pid)`
`24`		`- return nil`
	`24`	`+ return cmd.Process.Pid, nil`
`25`	`25`	`}`