Do not lazy-load TimeSeries tables so the cross-database move guard sees them

With lazy_load_tables=1 a TimeSeries table is reloaded as a StorageTableProxy.
DatabaseAtomic::renameTable guards a cross-database move with
dynamic_cast<StorageTimeSeries *>, which fails on the proxy, so a cross-database
RENAME TABLE of a lazy TimeSeries with inner tables was accepted: only the outer
table moved and the inner tables were orphaned in the source database.

MaterializedView avoids this entire class because shouldLazyLoad already excludes
it, so an MV is never a proxy and the sibling guard branch is safe. TimeSeries
owns inner tables and overrides renameInMemory the same way, so exclude it from
lazy load too. Plain tables keep lazy-loading; only the TimeSeries outer table is
loaded eagerly, which the guard can then see.

Extends the 04340 regression with a lazy_load_tables=1 cross-database move case.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: groeneai

src/Databases/DatabaseOrdinary.cpp

@@ -427,6 +427,11 @@ bool DatabaseOrdinary::shouldLazyLoad(const ASTCreateQuery & query, LoadingStric
         || query.isParameterizedView() || query.is_window_view)
         return false;
 
+    /// A lazy proxy would hide the TimeSeries type from the cross-database rename guard, so its
+    /// inner tables could be orphaned by a cross-database move. Load it eagerly, as for views.
+    if (query.is_time_series_table)
+        return false;
+
     /// Already handled by `StorageTableFunctionProxy`.
     if (query.as_table_function)
         return false;

tests/queries/0_stateless/04340_timeseries_rename_digest_mismatch.reference

@@ -10,3 +10,7 @@ rejected
 1
 1
 1
+rejected
+3
+0
+1

tests/queries/0_stateless/04340_timeseries_rename_digest_mismatch.sh

@@ -75,3 +75,24 @@ ${CLICKHOUSE_CLIENT} -q "EXISTS TABLE ${ORD}.\`.inner.metrics.ts\`"
 ${CLICKHOUSE_CLIENT} -q "EXISTS TABLE ${ORD}.ts"
 
 ${CLICKHOUSE_CLIENT} --send_logs_level=fatal -q "DROP DATABASE ${ORD} SYNC" 2>/dev/null || true
+
+# With lazy_load_tables=1 a reloaded TimeSeries table is materialized as a StorageTableProxy. The
+# proxy must not hide the TimeSeries type from the cross-database move guard -- otherwise a
+# cross-database RENAME would move only the outer table and orphan its inner tables in the old
+# database. The outer TimeSeries table is loaded eagerly so the guard sees it.
+LZ="${CLICKHOUSE_DATABASE}_lazy"
+LZ2="${CLICKHOUSE_DATABASE}_lazy2"
+${CLICKHOUSE_CLIENT} -q "DROP DATABASE IF EXISTS ${LZ} SYNC; DROP DATABASE IF EXISTS ${LZ2} SYNC"
+${CLICKHOUSE_CLIENT} -q "CREATE DATABASE ${LZ} ENGINE = Atomic SETTINGS lazy_load_tables = 1"
+${CLICKHOUSE_CLIENT} -q "CREATE DATABASE ${LZ2} ENGINE = Atomic"
+${CLICKHOUSE_CLIENT} --allow_experimental_time_series_table=1 -q "CREATE TABLE ${LZ}.ts ENGINE = TimeSeries"
+# Reattach so the table is recreated as a lazy proxy.
+${CLICKHOUSE_CLIENT} -q "DETACH DATABASE ${LZ}; ATTACH DATABASE ${LZ}"
+# The cross-database move is rejected before any inner table is moved.
+${CLICKHOUSE_CLIENT} --send_logs_level=fatal -q "RENAME TABLE ${LZ}.ts TO ${LZ2}.ts" 2>&1 | grep -q -F "Cannot move TimeSeries table with inner tables" && echo "rejected"
+# Every inner table stayed in the source database (none orphaned in the target).
+${CLICKHOUSE_CLIENT} -q "SELECT count() FROM system.tables WHERE database = '${LZ}' AND name LIKE '.inner_id.%'"
+${CLICKHOUSE_CLIENT} -q "SELECT count() FROM system.tables WHERE database = '${LZ2}' AND name LIKE '.inner_id.%'"
+${CLICKHOUSE_CLIENT} -q "EXISTS TABLE ${LZ}.ts"
+${CLICKHOUSE_CLIENT} --send_logs_level=fatal -q "DROP DATABASE ${LZ} SYNC" 2>/dev/null || true
+${CLICKHOUSE_CLIENT} --send_logs_level=fatal -q "DROP DATABASE ${LZ2} SYNC" 2>/dev/null || true