chore: fix clippy needless_borrow and allow too_many_arguments on emit

aleksUIX · aleksUIX · commit 52ee1695936a · 2026-04-11T08:05:02.000-07:00
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/vastlint-core/src/rules/mod.rs b/crates/vastlint-core/src/rules/mod.rs
@@ -50,6 +50,7 @@ pub fn run(
 /// Pass `node` to attach the element's source position to the issue. Pass
 /// `None` for document-level issues (e.g. missing root element, parse errors).
 #[inline]
+#[allow(clippy::too_many_arguments)]
 pub(crate) fn emit(
     ctx: &ValidationContext,
     issues: &mut Vec<Issue>,
diff --git a/crates/vastlint-core/src/rules/required.rs b/crates/vastlint-core/src/rules/required.rs
@@ -149,7 +149,7 @@ fn check_ad(
             "<Ad> must contain either <InLine> or <Wrapper>",
             Some(path.clone()),
             "IAB VAST 2.0 §2.2",
-            Some(&ad),
+            Some(ad),
         );
         return;
     }
@@ -163,7 +163,7 @@ fn check_ad(
             "<Ad> must not contain both <InLine> and <Wrapper>",
             Some(path.clone()),
             "IAB VAST 2.0 §2.2",
-            Some(&ad),
+            Some(ad),
         )
     }
 
@@ -200,7 +200,7 @@ fn check_inline(
             "<InLine> is missing required <AdSystem>",
             Some(path.clone()),
             "IAB VAST 2.0 §2.3.1",
-            Some(&inline),
+            Some(inline),
         )
     }
 
@@ -215,7 +215,7 @@ fn check_inline(
             "<InLine> is missing required <AdTitle>",
             Some(path.clone()),
             "IAB VAST 2.0 §2.3.2",
-            Some(&inline),
+            Some(inline),
         )
     }
 
@@ -230,7 +230,7 @@ fn check_inline(
             "<InLine> is missing required <Impression>",
             Some(path.clone()),
             "IAB VAST 2.0 §2.3.4",
-            Some(&inline),
+            Some(inline),
         )
     }
 
@@ -246,7 +246,7 @@ fn check_inline(
             "<InLine> is missing required <Creatives>",
             Some(path.clone()),
             "IAB VAST 2.0 §2.3.5",
-            Some(&inline),
+            Some(inline),
         ),
         Some(creatives) => {
             if creatives.children_named("Creative").count() == 0 {
@@ -258,7 +258,7 @@ fn check_inline(
                     "<Creatives> must contain at least one <Creative>",
                     Some(format!("{}/Creatives", path)),
                     "IAB VAST 2.0 §2.3.5",
-                    Some(&inline),
+                    Some(inline),
                 )
             }
         }
@@ -277,7 +277,7 @@ fn check_inline(
                 "<InLine> is missing required <AdServingId> (required since VAST 4.1)",
                 Some(path.clone()),
                 "IAB VAST 4.1 §3.4.1",
-                Some(&inline),
+                Some(inline),
             )
         }
     }
@@ -337,7 +337,7 @@ fn check_inline_creative(
                 "<Creative> is missing required <UniversalAdId> (required since VAST 4.0)",
                 Some(creative_path.to_owned()),
                 "IAB VAST 4.0 §3.8.1",
-                Some(&creative),
+                Some(creative),
             )
         }
     }
@@ -354,7 +354,7 @@ fn check_inline_creative(
                 "<UniversalAdId> is missing required idRegistry attribute",
                 Some(format!("{}/UniversalAdId", creative_path)),
                 "IAB VAST 4.0 §3.8.1",
-                Some(&creative),
+                Some(creative),
             )
         }
         // VAST-4.0-universaladid-idvalue / VAST-4.1-universaladid-idvalue-removed
@@ -420,7 +420,7 @@ fn check_inline_linear(
             "<Linear> is missing required <Duration>",
             Some(linear_path.to_owned()),
             "IAB VAST 2.0 §2.3.5.1",
-            Some(&linear),
+            Some(linear),
         )
     }
 
@@ -436,7 +436,7 @@ fn check_inline_linear(
             "<Linear> is missing required <MediaFiles>",
             Some(linear_path.to_owned()),
             "IAB VAST 2.0 §2.3.5.2",
-            Some(&linear),
+            Some(linear),
         ),
         Some(mf) => {
             if mf.children_named("MediaFile").count() == 0 {
@@ -448,7 +448,7 @@ fn check_inline_linear(
                     "<MediaFiles> must contain at least one <MediaFile>",
                     Some(format!("{}/MediaFiles", linear_path)),
                     "IAB VAST 2.0 §2.3.5.2",
-                    Some(&linear),
+                    Some(linear),
                 )
             }
             // Check each MediaFile has required attrs.
@@ -501,7 +501,7 @@ fn check_inline_linear(
                     "<InteractiveCreativeFile> should have an apiFramework attribute (e.g. \"SIMID\")",
                     Some(icf_path.clone()),
                     "IAB VAST 4.0 §2.3.5.4",
-            Some(&linear),
+            Some(linear),
         )
             }
 
@@ -517,7 +517,7 @@ fn check_inline_linear(
                     "<InteractiveCreativeFile> should have a type attribute identifying the MIME type",
                     Some(icf_path.clone()),
                     "IAB VAST 4.1 §3.9.3",
-            Some(&linear),
+            Some(linear),
         )
             }
         }
@@ -538,7 +538,7 @@ fn check_mediafile(mf: &Node, path: &str, ctx: &ValidationContext, issues: &mut
             "<MediaFile> is missing required delivery attribute",
             Some(path.to_owned()),
             "IAB VAST 2.0 §2.3.5.2",
-            Some(&mf),
+            Some(mf),
         )
     }
 
@@ -553,7 +553,7 @@ fn check_mediafile(mf: &Node, path: &str, ctx: &ValidationContext, issues: &mut
             "<MediaFile> is missing required type attribute",
             Some(path.to_owned()),
             "IAB VAST 2.0 §2.3.5.2",
-            Some(&mf),
+            Some(mf),
         )
     }
 
@@ -568,7 +568,7 @@ fn check_mediafile(mf: &Node, path: &str, ctx: &ValidationContext, issues: &mut
             "<MediaFile> is missing required width attribute",
             Some(path.to_owned()),
             "IAB VAST 2.0 §2.3.5.2",
-            Some(&mf),
+            Some(mf),
         )
     }
     if mf.attr("height").is_none() {
@@ -580,7 +580,7 @@ fn check_mediafile(mf: &Node, path: &str, ctx: &ValidationContext, issues: &mut
             "<MediaFile> is missing required height attribute",
             Some(path.to_owned()),
             "IAB VAST 2.0 §2.3.5.2",
-            Some(&mf),
+            Some(mf),
         )
     }
 }
@@ -606,7 +606,7 @@ fn check_wrapper(
             "<Wrapper> is missing required <AdSystem>",
             Some(path.clone()),
             "IAB VAST 2.0 §2.3.1",
-            Some(&wrapper),
+            Some(wrapper),
         )
     }
 
@@ -620,7 +620,7 @@ fn check_wrapper(
             "<Wrapper> is missing required <Impression>",
             Some(path.clone()),
             "IAB VAST 2.0 §2.3.4",
-            Some(&wrapper),
+            Some(wrapper),
         )
     }
 
@@ -635,7 +635,7 @@ fn check_wrapper(
             "<Wrapper> is missing required <VASTAdTagURI>",
             Some(path.clone()),
             "IAB VAST 2.0 §2.4",
-            Some(&wrapper),
+            Some(wrapper),
         )
     }
 
@@ -1101,7 +1101,7 @@ fn check_companion_resource(
             "<Companion> must contain at least one StaticResource, IFrameResource, or HTMLResource",
             Some(path.to_owned()),
             "IAB VAST 2.0 §2.3.7",
-            Some(&companion),
+            Some(companion),
         )
     }
 }
@@ -1126,7 +1126,7 @@ fn check_nonlinear_resource(
             "<NonLinear> must contain at least one StaticResource, IFrameResource, or HTMLResource",
             Some(path.to_owned()),
             "IAB VAST 2.0 §2.3.6.1",
-            Some(&nl),
+            Some(nl),
         )
     }
 }
diff --git a/crates/vastlint-core/src/rules/values.rs b/crates/vastlint-core/src/rules/values.rs
@@ -262,7 +262,7 @@ fn check_mediafile_values(mf: &Node, path: &str, ctx: &ValidationContext, issues
                 "<MediaFile> delivery attribute must be \"progressive\" or \"streaming\"",
                 Some(format!("{}[@delivery]", path)),
                 "IAB VAST 2.0 §2.3.5.2",
-                Some(&mf),
+                Some(mf),
             )
         }
     }
@@ -279,7 +279,7 @@ fn check_mediafile_values(mf: &Node, path: &str, ctx: &ValidationContext, issues
             "<MediaFile> must have both minBitrate and maxBitrate, or neither",
             Some(path.to_owned()),
             "IAB VAST 3.0 §2.3.5.2",
-            Some(&mf),
+            Some(mf),
         )
     }
 
@@ -293,7 +293,7 @@ fn check_mediafile_values(mf: &Node, path: &str, ctx: &ValidationContext, issues
             "<MediaFile> should not specify both bitrate and minBitrate/maxBitrate",
             Some(path.to_owned()),
             "IAB VAST 3.0 §2.3.5.2",
-            Some(&mf),
+            Some(mf),
         )
     }
 }
diff --git a/crates/vastlint-wasm/src/lib.rs b/crates/vastlint-wasm/src/lib.rs
@@ -198,7 +198,7 @@ fn to_js(result: vastlint_core::ValidationResult) -> Result<JsValue, JsValue> {
 
     // Patch: manually set line/col on each issue object because
     // serde-wasm-bindgen 0.6 drops Option<numeric> fields.
-    let issues_arr = js_sys::Reflect::get(&val, &JsValue::from_str("issues")).map_err(|e| e)?;
+    let issues_arr = js_sys::Reflect::get(&val, &JsValue::from_str("issues"))?;
     let issues_arr = js_sys::Array::from(&issues_arr);
     for (idx, (line, col)) in line_cols.iter().enumerate() {
         let issue_obj = issues_arr.get(idx as u32);
diff --git a/npm/package.json b/npm/package.json
@@ -23,6 +23,7 @@
   "types": "./index.d.ts",
   "exports": {
     ".": {
+      "workerd": "./index.cjs",
       "import": "./index.js",
       "require": "./index.cjs",
       "types": "./index.d.ts"
diff --git a/npm/vastlint_wasm.js b/npm/vastlint_wasm.js
@@ -3,7 +3,7 @@
 import * as wasm from "./vastlint_wasm_bg.wasm";
 import { __wbg_set_wasm } from "./vastlint_wasm_bg.js";
 __wbg_set_wasm(wasm);
-wasm.__wbindgen_start();
+if (typeof wasm.__wbindgen_start === "function") wasm.__wbindgen_start();
 export {
     rules, validate, validateWithOptions
 } from "./vastlint_wasm_bg.js";

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ fn check_ad(`
`149`	`149`	`"<Ad> must contain either <InLine> or <Wrapper>",`
`150`	`150`	`Some(path.clone()),`
`151`	`151`	`"IAB VAST 2.0 §2.2",`
`152`		`- Some(&ad),`
	`152`	`+ Some(ad),`
`153`	`153`	`);`
`154`	`154`	`return;`
`155`	`155`	`}`
`@@ -163,7 +163,7 @@ fn check_ad(`
`163`	`163`	`"<Ad> must not contain both <InLine> and <Wrapper>",`
`164`	`164`	`Some(path.clone()),`
`165`	`165`	`"IAB VAST 2.0 §2.2",`
`166`		`- Some(&ad),`
	`166`	`+ Some(ad),`
`167`	`167`	`)`
`168`	`168`	`}`
`169`	`169`
`@@ -200,7 +200,7 @@ fn check_inline(`
`200`	`200`	`"<InLine> is missing required <AdSystem>",`
`201`	`201`	`Some(path.clone()),`
`202`	`202`	`"IAB VAST 2.0 §2.3.1",`
`203`		`- Some(&inline),`
	`203`	`+ Some(inline),`
`204`	`204`	`)`
`205`	`205`	`}`
`206`	`206`
`@@ -215,7 +215,7 @@ fn check_inline(`
`215`	`215`	`"<InLine> is missing required <AdTitle>",`
`216`	`216`	`Some(path.clone()),`
`217`	`217`	`"IAB VAST 2.0 §2.3.2",`
`218`		`- Some(&inline),`
	`218`	`+ Some(inline),`
`219`	`219`	`)`
`220`	`220`	`}`
`221`	`221`
`@@ -230,7 +230,7 @@ fn check_inline(`
`230`	`230`	`"<InLine> is missing required <Impression>",`
`231`	`231`	`Some(path.clone()),`
`232`	`232`	`"IAB VAST 2.0 §2.3.4",`
`233`		`- Some(&inline),`
	`233`	`+ Some(inline),`
`234`	`234`	`)`
`235`	`235`	`}`
`236`	`236`
`@@ -246,7 +246,7 @@ fn check_inline(`
`246`	`246`	`"<InLine> is missing required <Creatives>",`
`247`	`247`	`Some(path.clone()),`
`248`	`248`	`"IAB VAST 2.0 §2.3.5",`
`249`		`- Some(&inline),`
	`249`	`+ Some(inline),`
`250`	`250`	`),`
`251`	`251`	`Some(creatives) => {`
`252`	`252`	`if creatives.children_named("Creative").count() == 0 {`
`@@ -258,7 +258,7 @@ fn check_inline(`
`258`	`258`	`"<Creatives> must contain at least one <Creative>",`
`259`	`259`	`Some(format!("{}/Creatives", path)),`
`260`	`260`	`"IAB VAST 2.0 §2.3.5",`
`261`		`- Some(&inline),`
	`261`	`+ Some(inline),`
`262`	`262`	`)`
`263`	`263`	`}`
`264`	`264`	`}`
`@@ -277,7 +277,7 @@ fn check_inline(`
`277`	`277`	`"<InLine> is missing required <AdServingId> (required since VAST 4.1)",`
`278`	`278`	`Some(path.clone()),`
`279`	`279`	`"IAB VAST 4.1 §3.4.1",`
`280`		`- Some(&inline),`
	`280`	`+ Some(inline),`
`281`	`281`	`)`
`282`	`282`	`}`
`283`	`283`	`}`
`@@ -337,7 +337,7 @@ fn check_inline_creative(`
`337`	`337`	`"<Creative> is missing required <UniversalAdId> (required since VAST 4.0)",`
`338`	`338`	`Some(creative_path.to_owned()),`
`339`	`339`	`"IAB VAST 4.0 §3.8.1",`
`340`		`- Some(&creative),`
	`340`	`+ Some(creative),`
`341`	`341`	`)`
`342`	`342`	`}`
`343`	`343`	`}`
`@@ -354,7 +354,7 @@ fn check_inline_creative(`
`354`	`354`	`"<UniversalAdId> is missing required idRegistry attribute",`
`355`	`355`	`Some(format!("{}/UniversalAdId", creative_path)),`
`356`	`356`	`"IAB VAST 4.0 §3.8.1",`
`357`		`- Some(&creative),`
	`357`	`+ Some(creative),`
`358`	`358`	`)`
`359`	`359`	`}`
`360`	`360`	`// VAST-4.0-universaladid-idvalue / VAST-4.1-universaladid-idvalue-removed`
`@@ -420,7 +420,7 @@ fn check_inline_linear(`
`420`	`420`	`"<Linear> is missing required <Duration>",`
`421`	`421`	`Some(linear_path.to_owned()),`
`422`	`422`	`"IAB VAST 2.0 §2.3.5.1",`
`423`		`- Some(&linear),`
	`423`	`+ Some(linear),`
`424`	`424`	`)`
`425`	`425`	`}`
`426`	`426`
`@@ -436,7 +436,7 @@ fn check_inline_linear(`
`436`	`436`	`"<Linear> is missing required <MediaFiles>",`
`437`	`437`	`Some(linear_path.to_owned()),`
`438`	`438`	`"IAB VAST 2.0 §2.3.5.2",`
`439`		`- Some(&linear),`
	`439`	`+ Some(linear),`
`440`	`440`	`),`
`441`	`441`	`Some(mf) => {`
`442`	`442`	`if mf.children_named("MediaFile").count() == 0 {`
`@@ -448,7 +448,7 @@ fn check_inline_linear(`
`448`	`448`	`"<MediaFiles> must contain at least one <MediaFile>",`
`449`	`449`	`Some(format!("{}/MediaFiles", linear_path)),`
`450`	`450`	`"IAB VAST 2.0 §2.3.5.2",`
`451`		`- Some(&linear),`
	`451`	`+ Some(linear),`
`452`	`452`	`)`
`453`	`453`	`}`
`454`	`454`	`// Check each MediaFile has required attrs.`
`@@ -501,7 +501,7 @@ fn check_inline_linear(`
`501`	`501`	`"<InteractiveCreativeFile> should have an apiFramework attribute (e.g. \"SIMID\")",`
`502`	`502`	`Some(icf_path.clone()),`
`503`	`503`	`"IAB VAST 4.0 §2.3.5.4",`
`504`		`- Some(&linear),`
	`504`	`+ Some(linear),`
`505`	`505`	`)`
`506`	`506`	`}`
`507`	`507`
`@@ -517,7 +517,7 @@ fn check_inline_linear(`
`517`	`517`	`"<InteractiveCreativeFile> should have a type attribute identifying the MIME type",`
`518`	`518`	`Some(icf_path.clone()),`
`519`	`519`	`"IAB VAST 4.1 §3.9.3",`
`520`		`- Some(&linear),`
	`520`	`+ Some(linear),`
`521`	`521`	`)`
`522`	`522`	`}`
`523`	`523`	`}`
`@@ -538,7 +538,7 @@ fn check_mediafile(mf: &Node, path: &str, ctx: &ValidationContext, issues: &mut`
`538`	`538`	`"<MediaFile> is missing required delivery attribute",`
`539`	`539`	`Some(path.to_owned()),`
`540`	`540`	`"IAB VAST 2.0 §2.3.5.2",`
`541`		`- Some(&mf),`
	`541`	`+ Some(mf),`
`542`	`542`	`)`
`543`	`543`	`}`
`544`	`544`
`@@ -553,7 +553,7 @@ fn check_mediafile(mf: &Node, path: &str, ctx: &ValidationContext, issues: &mut`
`553`	`553`	`"<MediaFile> is missing required type attribute",`
`554`	`554`	`Some(path.to_owned()),`
`555`	`555`	`"IAB VAST 2.0 §2.3.5.2",`
`556`		`- Some(&mf),`
	`556`	`+ Some(mf),`
`557`	`557`	`)`
`558`	`558`	`}`
`559`	`559`
`@@ -568,7 +568,7 @@ fn check_mediafile(mf: &Node, path: &str, ctx: &ValidationContext, issues: &mut`
`568`	`568`	`"<MediaFile> is missing required width attribute",`
`569`	`569`	`Some(path.to_owned()),`
`570`	`570`	`"IAB VAST 2.0 §2.3.5.2",`
`571`		`- Some(&mf),`
	`571`	`+ Some(mf),`
`572`	`572`	`)`
`573`	`573`	`}`
`574`	`574`	`if mf.attr("height").is_none() {`
`@@ -580,7 +580,7 @@ fn check_mediafile(mf: &Node, path: &str, ctx: &ValidationContext, issues: &mut`
`580`	`580`	`"<MediaFile> is missing required height attribute",`
`581`	`581`	`Some(path.to_owned()),`
`582`	`582`	`"IAB VAST 2.0 §2.3.5.2",`
`583`		`- Some(&mf),`
	`583`	`+ Some(mf),`
`584`	`584`	`)`
`585`	`585`	`}`
`586`	`586`	`}`
`@@ -606,7 +606,7 @@ fn check_wrapper(`
`606`	`606`	`"<Wrapper> is missing required <AdSystem>",`
`607`	`607`	`Some(path.clone()),`
`608`	`608`	`"IAB VAST 2.0 §2.3.1",`
`609`		`- Some(&wrapper),`
	`609`	`+ Some(wrapper),`
`610`	`610`	`)`
`611`	`611`	`}`
`612`	`612`
`@@ -620,7 +620,7 @@ fn check_wrapper(`
`620`	`620`	`"<Wrapper> is missing required <Impression>",`
`621`	`621`	`Some(path.clone()),`
`622`	`622`	`"IAB VAST 2.0 §2.3.4",`
`623`		`- Some(&wrapper),`
	`623`	`+ Some(wrapper),`
`624`	`624`	`)`
`625`	`625`	`}`
`626`	`626`
`@@ -635,7 +635,7 @@ fn check_wrapper(`
`635`	`635`	`"<Wrapper> is missing required <VASTAdTagURI>",`
`636`	`636`	`Some(path.clone()),`
`637`	`637`	`"IAB VAST 2.0 §2.4",`
`638`		`- Some(&wrapper),`
	`638`	`+ Some(wrapper),`
`639`	`639`	`)`
`640`	`640`	`}`
`641`	`641`
`@@ -1101,7 +1101,7 @@ fn check_companion_resource(`
`1101`	`1101`	`"<Companion> must contain at least one StaticResource, IFrameResource, or HTMLResource",`
`1102`	`1102`	`Some(path.to_owned()),`
`1103`	`1103`	`"IAB VAST 2.0 §2.3.7",`
`1104`		`- Some(&companion),`
	`1104`	`+ Some(companion),`
`1105`	`1105`	`)`
`1106`	`1106`	`}`
`1107`	`1107`	`}`
`@@ -1126,7 +1126,7 @@ fn check_nonlinear_resource(`
`1126`	`1126`	`"<NonLinear> must contain at least one StaticResource, IFrameResource, or HTMLResource",`
`1127`	`1127`	`Some(path.to_owned()),`
`1128`	`1128`	`"IAB VAST 2.0 §2.3.6.1",`
`1129`		`- Some(&nl),`
	`1129`	`+ Some(nl),`
`1130`	`1130`	`)`
`1131`	`1131`	`}`
`1132`	`1132`	`}`
Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ fn check_mediafile_values(mf: &Node, path: &str, ctx: &ValidationContext, issues`
`262`	`262`	`"<MediaFile> delivery attribute must be \"progressive\" or \"streaming\"",`
`263`	`263`	`Some(format!("{}[@delivery]", path)),`
`264`	`264`	`"IAB VAST 2.0 §2.3.5.2",`
`265`		`- Some(&mf),`
	`265`	`+ Some(mf),`
`266`	`266`	`)`
`267`	`267`	`}`
`268`	`268`	`}`
`@@ -279,7 +279,7 @@ fn check_mediafile_values(mf: &Node, path: &str, ctx: &ValidationContext, issues`
`279`	`279`	`"<MediaFile> must have both minBitrate and maxBitrate, or neither",`
`280`	`280`	`Some(path.to_owned()),`
`281`	`281`	`"IAB VAST 3.0 §2.3.5.2",`
`282`		`- Some(&mf),`
	`282`	`+ Some(mf),`
`283`	`283`	`)`
`284`	`284`	`}`
`285`	`285`
`@@ -293,7 +293,7 @@ fn check_mediafile_values(mf: &Node, path: &str, ctx: &ValidationContext, issues`
`293`	`293`	`"<MediaFile> should not specify both bitrate and minBitrate/maxBitrate",`
`294`	`294`	`Some(path.to_owned()),`
`295`	`295`	`"IAB VAST 3.0 §2.3.5.2",`
`296`		`- Some(&mf),`
	`296`	`+ Some(mf),`
`297`	`297`	`)`
`298`	`298`	`}`
`299`	`299`	`}`