fix

Author: Aleksandr Pronichev

app/src/main/java/hexlet/code/games/Calc.java

@@ -23,22 +23,22 @@ public static String[][] generateData() {
             int secondNumber = Utils.getRandomInt(MIN_NUMBER, MAX_NUMBER);
             char operator = operators[(int) (Math.random() * operators.length)];
             String question = firstNumber + " " + operator + " " + secondNumber;
-            String correctAnswer = calculate(firstNumber, secondNumber, operator);
+            String correctAnswer = Integer.toString(calculate(firstNumber, secondNumber, operator));
 
             questionsAndAnswers[i][0] = question;
             questionsAndAnswers[i][1] = correctAnswer;
         }
         return questionsAndAnswers;
     }
 
-    public static String calculate(int firstNumber, int secondNumber, char operator) {
+    public static int calculate(int firstNumber, int secondNumber, char operator) {
         switch (operator) {
             case '+':
-                return Integer.toString(firstNumber + secondNumber);
+                return firstNumber + secondNumber;
             case '-':
-                return Integer.toString(firstNumber - secondNumber);
+                return firstNumber - secondNumber;
             case '*':
-                return Integer.toString(firstNumber * secondNumber);
+                return firstNumber * secondNumber;
             default:
                 throw new IllegalArgumentException("Unsupported operator");
         }

app/src/main/java/hexlet/code/games/Even.java

@@ -19,15 +19,15 @@ public static String[][] generateData() {
         for (int i = 0; i < Engine.ROUNDS; i++) {
             int number = Utils.getRandomInt(MIN_NUMBER, MAX_NUMBER);
             String question = Integer.toString(number);
-            String correctAnswer = isEven(number);
+            String correctAnswer = isEven(number) ? "yes" : "no";
             questionsAndAnswers[i][0] = question;
             questionsAndAnswers[i][1] = correctAnswer;
         }
         return questionsAndAnswers;
     }
 
-    public static String isEven(int number) {
-        return (number % 2 == 0) ? "yes" : "no";
+    public static boolean isEven(int number) {
+        return (number % 2 == 0);
     }
 }
 

app/src/main/java/hexlet/code/games/Progression.java

@@ -24,34 +24,32 @@ public static String[][] generateData() {
             int start = Utils.getRandomInt(0, MAX_START);
             int step = Utils.getRandomInt(1, MAX_STEP + 1);
 
-            String[] progression = generateProgression(start, step, progressionLength);
+            int[] progression = generateProgression(start, step, progressionLength);
 
-            questionsAndAnswers[i][0] = progression[0];
-            questionsAndAnswers[i][1] = progression[1];
+            String[] stringProgression = new String[progression.length];
+            for (int j = 0; j < progression.length; j++) {
+                stringProgression[j] = Integer.toString(progression[j]);
+            }
+
+            int missingIndex = Utils.getRandomInt(0, progressionLength - 1);
+            String missingNumber = stringProgression[missingIndex];
+            stringProgression[missingIndex] = "..";
+
+            String question = String.join(" ", stringProgression);
+
+            questionsAndAnswers[i][0] = question;
+            questionsAndAnswers[i][1] = missingNumber;
         }
         return questionsAndAnswers;
     }
 
-    public static String[] generateProgression(int start, int step, int length) {
+    public static int[] generateProgression(int start, int step, int length) {
         int[] progression = new int[length];
 
         for (int i = 0; i < length; i++) {
             progression[i] = start + i * step;
         }
 
-        int missingIndex = Utils.getRandomInt(0, length - 1);
-        int missingNumber = progression[missingIndex];
-
-        String[] formattedProgression = new String[length];
-
-        for (int i = 0; i < length; i++) {
-            if (i == missingIndex) {
-                formattedProgression[i] = "..";
-            } else {
-                formattedProgression[i] = Integer.toString(progression[i]);
-            }
-        }
-        String question = String.join(" ", formattedProgression);
-        return new String[]{question, Integer.toString(missingNumber)};
+        return progression;
     }
 }