fix(ScyllaYaml): add tablets_mode_for_new_keyspaces configuration option

The configuration option was added in scylladb/scylladb#22273
It take precedence over `enable_tablets`

Author: cezarmoise

configurations/force-gossip-topology-changes.yaml

@@ -1,3 +1,4 @@
 append_scylla_yaml:
   force_gossip_topology_changes: true
   enable_tablets: false
+  tablets_mode_for_new_keyspaces: 'disabled'

configurations/tablets-initial-32.yaml

@@ -1,3 +1,4 @@
 append_scylla_yaml:
   enable_tablets: true
+  tablets_mode_for_new_keyspaces: 'enabled'
   tablets_initial_scale_factor: 4

configurations/tablets_disabled.yaml

@@ -1,2 +1,3 @@
 append_scylla_yaml:
   enable_tablets: false
+  tablets_mode_for_new_keyspaces: 'disabled'

docker/scylla-sct/entry.sh

@@ -12,5 +12,6 @@ authorizer: 'CassandraAuthorizer'
 EOM
 
 sed -e '/enable_tablets:.*/s/true/false/g' -i /etc/scylla/scylla.yaml
+sed -e '/tablets_mode_for_new_keyspaces:.*/s/enabled/disabled/g' -i /etc/scylla/scylla.yaml
 
 /docker-entrypoint.py $*

docker/scylla-sct/entry_ssl.sh

@@ -19,5 +19,6 @@ client_encryption_options:
 EOM
 
 sed -e '/enable_tablets:.*/s/true/false/g' -i /etc/scylla/scylla.yaml
+sed -e '/tablets_mode_for_new_keyspaces:.*/s/enabled/disabled/g' -i /etc/scylla/scylla.yaml
 
 /docker-entrypoint.py $*

sdcm/provision/scylla_yaml/scylla_yaml.py

@@ -354,6 +354,7 @@ def set_authorizer(cls, authorizer: str):
     compaction_collection_items_count_warning_threshold: int = None  # None
 
     enable_tablets: bool = None  # False, but default scylla.yaml for some versions (e.g. 6.0) override it to True
+    tablets_mode_for_new_keyspaces: Literal['disabled', 'enabled', 'enforced'] = None  # enabled
     force_gossip_topology_changes: bool = None  # False
 
     reader_concurrency_semaphore_cpu_concurrency: int = None

sdcm/utils/features.py

@@ -83,5 +83,7 @@ def is_tablets_feature_enabled(node) -> bool:
             return True
         if scylla_yaml.dict().get("enable_tablets"):
             return True
+        if scylla_yaml.dict().get("tablets_mode_for_new_keyspaces") in ["enabled", "enforced"]:
+            return True
 
     return False

test-cases/PR-provision-test-docker.yaml

@@ -18,3 +18,4 @@ use_mgmt: false
 
 append_scylla_yaml:
   enable_tablets: false  # counters are not supported with tablets
+  tablets_mode_for_new_keyspaces: 'disabled'  # counters are not supported with tablets

test-cases/PR-provision-test.yaml

@@ -31,3 +31,4 @@ use_preinstalled_scylla: true
 
 append_scylla_yaml:
   enable_tablets: false  # counters are not supported with tablets
+  tablets_mode_for_new_keyspaces: 'disabled'  # counters are not supported with tablets

test-cases/longevity/longevity-aws-custom-d2-workload1-3dcs.yaml

@@ -26,6 +26,7 @@ append_scylla_yaml:
   # See: https://github.com/scylladb/scylladb/pull/21207
   enable_small_table_optimization_for_rbno: true
   enable_tablets: false
+  tablets_mode_for_new_keyspaces: 'disabled'
 
 nemesis_class_name: 'SisyphusMonkey'
 nemesis_seed: '029'

test-cases/longevity/longevity-aws-custom-d2-workload1-5dcs.yaml

@@ -26,6 +26,7 @@ append_scylla_yaml:
   # See: https://github.com/scylladb/scylladb/pull/21207
   enable_small_table_optimization_for_rbno: true
   enable_tablets: false
+  tablets_mode_for_new_keyspaces: 'disabled'
 
 nemesis_class_name: 'SisyphusMonkey'
 nemesis_seed: '007'

unit_tests/test_scylla_yaml.py

@@ -409,6 +409,7 @@ def test_scylla_yaml(self):
                 'workdir': None,
                 'write_request_timeout_in_ms': None,
                 'enable_tablets': None,
+                'tablets_mode_for_new_keyspaces': None,
                 'force_gossip_topology_changes': None,
                 'reader_concurrency_semaphore_cpu_concurrency': None,
             }

upgrade_test.py

@@ -236,6 +236,7 @@ def _upgrade_node(self, node, upgrade_sstables=True, new_scylla_repo=None, new_v
 
         if self.params.get("enable_tablets_on_upgrade"):
             scylla_yaml_updates.update({"enable_tablets": True})
+            scylla_yaml_updates.update({"tablets_mode_for_new_keyspaces": "enabled"})
         if self.params.get("enable_views_with_tablets_on_upgrade"):
             scylla_yaml_updates.update({"experimental_features": ["views-with-tablets"]})