Skip to content

Commit 2578808

Browse files
committed
Solves issue #78 where effects - other than the first one - in groups could not be removed.
1 parent 35828b2 commit 2578808

5 files changed

Lines changed: 12 additions & 4 deletions

File tree

distr/Pizzicato.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1013,7 +1013,7 @@
10131013
return this;
10141014
}
10151015

1016-
var previousNode = (index === 0) ? this.mergeGainNode : this.effectConnectors(index - 1);
1016+
var previousNode = (index === 0) ? this.mergeGainNode : this.effectConnectors[index - 1];
10171017
previousNode.disconnect();
10181018

10191019
// Disconnect connector and effect

distr/Pizzicato.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

site/Pizzicato.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1013,7 +1013,7 @@
10131013
return this;
10141014
}
10151015

1016-
var previousNode = (index === 0) ? this.mergeGainNode : this.effectConnectors(index - 1);
1016+
var previousNode = (index === 0) ? this.mergeGainNode : this.effectConnectors[index - 1];
10171017
previousNode.disconnect();
10181018

10191019
// Disconnect connector and effect

src/Group.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ Pizzicato.Group.prototype = Object.create(Pz.Events, {
186186
return this;
187187
}
188188

189-
var previousNode = (index === 0) ? this.mergeGainNode : this.effectConnectors(index - 1);
189+
var previousNode = (index === 0) ? this.mergeGainNode : this.effectConnectors[index - 1];
190190
previousNode.disconnect();
191191

192192
// Disconnect connector and effect

tests/Group.test.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,19 @@ describe('Group', function() {
9090

9191
it('can be added and removed', function() {
9292
var delay = new Pizzicato.Effects.Delay();
93+
var pingPongDelay = new Pizzicato.Effects.PingPongDelay();
9394
var group = new Pizzicato.Group();
9495

9596
group.addEffect(delay);
9697
expect(group.effects.indexOf(delay)).not.toBe(-1);
9798

99+
group.addEffect(pingPongDelay);
100+
expect(group.effects.indexOf(pingPongDelay)).not.toBe(-1);
101+
102+
group.removeEffect(pingPongDelay);
103+
expect(group.effects.indexOf(pingPongDelay)).toBe(-1);
104+
expect(group.effects.indexOf(delay)).not.toBe(-1);
105+
98106
group.removeEffect(delay);
99107
expect(group.effects.indexOf(delay)).toBe(-1);
100108
});

0 commit comments

Comments
 (0)