Sound will no longer stop when removing effects.

Author: alemangui

distr/Pizzicato.js

@@ -419,13 +419,21 @@
 				if (index === -1) 
 					return;
 
+				var shouldResumePlaying = this.playing;
+	
+				if (shouldResumePlaying)
+					this.pause();
+	
 				this.fadeNode.disconnect();
 
 				for (var i = 0; i < this.effects.length; i++)
 					this.effects[i].outputNode.disconnect();
 
 				this.effects.splice(index, 1);
 				this.connectEffects();
+	
+				if (shouldResumePlaying)
+					this.play();
 			}
 		},
 

distr/Pizzicato.min.js

@@ -419,13 +419,21 @@
 				if (index === -1) 
 					return;
 
+				var shouldResumePlaying = this.playing;
+	
+				if (shouldResumePlaying)
+					this.pause();
+	
 				this.fadeNode.disconnect();
 
 				for (var i = 0; i < this.effects.length; i++)
 					this.effects[i].outputNode.disconnect();
 
 				this.effects.splice(index, 1);
 				this.connectEffects();
+	
+				if (shouldResumePlaying)
+					this.play();
 			}
 		},
 

site/Pizzicato.js

@@ -263,13 +263,21 @@ Pizzicato.Sound.prototype = Object.create(Pizzicato.Events, {
 			if (index === -1) 
 				return;
 
+			var shouldResumePlaying = this.playing;
+
+			if (shouldResumePlaying)
+				this.pause();
+
 			this.fadeNode.disconnect();
 
 			for (var i = 0; i < this.effects.length; i++)
 				this.effects[i].outputNode.disconnect();
 
 			this.effects.splice(index, 1);
 			this.connectEffects();
+
+			if (shouldResumePlaying)
+				this.play();
 		}
 	},
 

src/Sound.js

@@ -281,5 +281,48 @@ describe('Sound', function() {
 				done();
 			});
 		}, 5000);
+
+		it('should continue playing when effects are added', function(done) {
+			var endCallback = jasmine.createSpy('endCallback');
+
+			var sound = new Pizzicato.Sound('base/tests/click.wav', function() {
+
+				var delay = new Pz.Effects.Delay();
+
+				sound.play();
+				sound.addEffect(delay);
+				expect(sound.playing).toBe(true);
+
+				setTimeout(function() {
+					expect(endCallback).toHaveBeenCalled();
+					done();
+				}, 2000);
+			});
+			
+			sound.on('end', endCallback);
+
+		}, 5500);
+
+		it('should continue playing when effects are removed', function(done) {
+			var endCallback = jasmine.createSpy('endCallback');
+			var delay = new Pz.Effects.Delay();
+
+			var sound = new Pizzicato.Sound('base/tests/click.wav', function() {
+
+				sound.play();
+				sound.removeEffect(delay);
+
+				expect(sound.playing).toBe(true);
+				
+				setTimeout(function() {
+					expect(endCallback).toHaveBeenCalled();
+					done();
+				}, 2000);
+			});
+
+			sound.on('end', endCallback);
+			sound.addEffect(delay);
+
+		}, 5500);
 	});
 });