Skip to content

Commit 88f88aa

Browse files
authored
fix: Don't mutate original request query (okta#568)
1 parent cc642c3 commit 88f88aa

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

.generator/templates/client.mustache

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1176,12 +1176,13 @@ func (c *APIClient) doWithRetries(ctx context.Context, req *http.Request) (*http
11761176
11771177
headerParams := make(map[string]string)
11781178
queryParams := req.URL.Query()
1179-
req.URL.RawQuery = ""
1180-
auth, err := c.prepareRequest(ctx, req.URL.String(), req.Method, nil, headerParams, queryParams, url.Values{}, []formFile{})
1179+
urlWithoutQuery := *req.URL
1180+
urlWithoutQuery.RawQuery = ""
1181+
1182+
auth, err := c.prepareRequest(ctx, urlWithoutQuery.String(), req.Method, nil, headerParams, queryParams, url.Values{}, []formFile{})
11811183
if err != nil {
11821184
return nil, err
11831185
}
1184-
11851186
req.Header = req.Header.Clone() // Start with original headers
11861187

11871188
// Update only the authentication headers from the fresh auth request

okta/client.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1479,8 +1479,10 @@ func (c *APIClient) doWithRetries(ctx context.Context, req *http.Request) (*http
14791479

14801480
headerParams := make(map[string]string)
14811481
queryParams := req.URL.Query()
1482-
req.URL.RawQuery = ""
1483-
auth, err := c.prepareRequest(ctx, req.URL.String(), req.Method, nil, headerParams, queryParams, url.Values{}, []formFile{})
1482+
urlWithoutQuery := *req.URL
1483+
urlWithoutQuery.RawQuery = ""
1484+
1485+
auth, err := c.prepareRequest(ctx, urlWithoutQuery.String(), req.Method, nil, headerParams, queryParams, url.Values{}, []formFile{})
14841486
if err != nil {
14851487
return nil, err
14861488
}

0 commit comments

Comments
 (0)