Skip to content

Commit 0b6fc84

Browse files
committed
Merge branch 'master' of https://github.com/mongodb/specifications into mkbook
2 parents b6e310e + bb9dddd commit 0b6fc84

4 files changed

Lines changed: 25 additions & 14 deletions

File tree

source/auth/tests/mongodb-oidc.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ Drivers MUST implement all prose tests in this section. Unless otherwise noted,
3535
configured with `retryReads=false`.
3636

3737
> [!NOTE]
38-
> For test cases that create fail points, drivers MUST either use a unique `appName` or explicitly remove the fail point
39-
> callback to prevent interaction between test cases.
38+
> For test cases that create fail points, drivers MUST use a unique `appName` to prevent interaction with other
39+
> environment processes, and explicitly remove the fail point to prevent interaction between test runs.
4040
4141
After setting up your OIDC
4242
[environment](https://github.com/mongodb-labs/drivers-evergreen-tools/blob/master/.evergreen/auth_oidc/README.md),

source/auth/tests/unified/mongodb-oidc-no-retry.json

Lines changed: 12 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

source/auth/tests/unified/mongodb-oidc-no-retry.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ createEntities:
2121
authMechanismProperties: { $$placeholder: 1 }
2222
retryReads: false
2323
retryWrites: false
24+
appName: &appName mongodb-oidc-no-retry
2425
observeEvents:
2526
- commandStartedEvent
2627
- commandSucceededEvent
@@ -87,6 +88,7 @@ tests:
8788
failCommands:
8889
- find
8990
errorCode: 391 # ReauthenticationRequired
91+
appName: *appName
9092
- name: find
9193
object: collection0
9294
arguments:
@@ -121,6 +123,7 @@ tests:
121123
failCommands:
122124
- insert
123125
errorCode: 391 # ReauthenticationRequired
126+
appName: *appName
124127
- name: insertOne
125128
object: collection0
126129
arguments:
@@ -160,6 +163,7 @@ tests:
160163
failCommands:
161164
- insert
162165
closeConnection: true
166+
appName: *appName
163167
- name: insertOne
164168
object: collection0
165169
arguments:
@@ -180,6 +184,7 @@ tests:
180184
failCommands:
181185
- saslStart
182186
errorCode: 18
187+
appName: *appName
183188
- name: insertOne
184189
object: collection0
185190
arguments:
@@ -219,11 +224,12 @@ tests:
219224
failCommands:
220225
- saslStart
221226
errorCode: 18
227+
appName: *appName
222228
- name: insertOne
223229
object: collection0
224230
arguments:
225231
document:
226232
_id: 1
227233
x: 1
228234
expectError:
229-
errorCode: 18
235+
errorCode: 18

source/connection-monitoring-and-pooling/connection-monitoring-and-pooling.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -291,10 +291,9 @@ Endpoint. The pool has the following properties:
291291
to avoid clearing the pool. The pool MUST NOT add the backpressure error labels during an authentication step
292292
after the `hello` message. For errors that the driver can distinguish as never occurring due to server overload,
293293
such as DNS lookup failures, non‑I/O TLS errors (e.g., certificate validation or hostname‑mismatch failures), or
294-
errors encountered while establishing a connection to a SOCKS5 proxy, the driver MUST clear the connection pool and
295-
MUST mark the server Unknown for these error types. In contrast, if an I/O error (for example, an EOF error) occurs
296-
during the TLS handshake, the driver MUST treat it as a potential overload condition and MUST add the backpressure
297-
error labels.
294+
errors encountered while establishing a connection to a SOCKS5 proxy, the driver MUST NOT add backpressure error
295+
labels for these error types. In contrast, if an I/O error (for example, an EOF error) occurs during the TLS
296+
handshake, the driver MUST treat it as a potential overload condition and MUST add the backpressure error labels.
298297

299298
```typescript
300299
interface ConnectionPool {
@@ -472,7 +471,7 @@ try:
472471
return connection
473472
except error:
474473
close connection
475-
add `SystemOverloadedError` label if appropriate (see "backpressure-enabled" in [Connection Pool](#connection-pool))
474+
add `SystemOverloadedError` and `RetryableError` labels if appropriate (see "backpressure-enabled" in [Connection Pool](#connection-pool))
476475
throw error # Propagate error in manner idiomatic to language.
477476
```
478477

0 commit comments

Comments
 (0)