Skip to content

Commit 238cae3

Browse files
Add missing only and optional validation
1 parent ba3fa7e commit 238cae3

2 files changed

Lines changed: 14 additions & 2 deletions

File tree

application/controllers/Admins.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,12 @@ public function update(): void
202202

203203
$this->admins_model->only($admin, $this->allowed_admin_fields);
204204

205+
$this->admins_model->optional($admin, $this->optional_admin_fields);
206+
205207
$this->admins_model->only($admin['settings'], $this->allowed_admin_setting_fields);
206208

209+
$this->admins_model->optional($admin['settings'], $this->optional_admin_setting_fields);
210+
207211
$admin_id = $this->admins_model->save($admin);
208212

209213
$admin = $this->admins_model->find($admin_id);

application/controllers/Secretaries.php

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,17 @@ class Secretaries extends EA_Controller
4141
'settings',
4242
'providers',
4343
];
44-
public array $allowed_secretary_setting_fields = ['username', 'password', 'notifications', 'calendar_view'];
44+
4545
public array $optional_secretary_fields = [
4646
'providers' => [],
4747
];
4848

49+
public array $allowed_secretary_setting_fields = ['username', 'password', 'notifications', 'calendar_view'];
50+
51+
public array $optional_secretary_setting_fields = [
52+
//
53+
];
54+
4955
/**
5056
* Secretaries constructor.
5157
*/
@@ -154,9 +160,11 @@ public function store(): void
154160

155161
$this->secretaries_model->only($secretary, $this->allowed_secretary_fields);
156162

163+
$this->secretaries_model->optional($secretary, $this->optional_secretary_fields);
164+
157165
$this->secretaries_model->only($secretary['settings'], $this->allowed_secretary_setting_fields);
158166

159-
$this->secretaries_model->optional($secretary, $this->optional_secretary_fields);
167+
$this->secretaries_model->optional($secretary['settings'], $this->optional_secretary_setting_fields);
160168

161169
$secretary_id = $this->secretaries_model->save($secretary);
162170

0 commit comments

Comments
 (0)