Skip to content

Commit c38197a

Browse files
committed
Wrap up data-driven version migration
Now that every shell reads from versions/<shell>.{all,current} via shvr_update_<shell>, drop the now-dead shvr_clear_versioninfo call in shvr_update: the updaters discover versions fresh and never read the version_*/fork_*/build_srcdir globals. The function and its two github_regen_* call sites (which clear then consume build_srcdir) are unchanged. Document the maintainer update workflow in README.md (sh shvr.sh update, probe new versions, versions/<shell>.excluded, github_regen_all, commit).
1 parent 87fdd7a commit c38197a

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

README.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,3 +87,15 @@ This is particularly useful if you want to test a version that we don't bundle
8787
by default, such as an old patch. Our scripts are able to build most
8888
intermediate versions without modifications, but we can't include them all in
8989
any of the default images.
90+
91+
## Updating the Version Lists
92+
93+
The supported versions live in `versions/<shell>.{all,current}` (plus an optional
94+
`versions/<shell>.excluded` denylist). To pull in new upstream releases, run
95+
`sh shvr.sh update [<shell>]` (with no argument it updates every shell), which
96+
refreshes `versions/<shell>.all` from each shell's upstream source. Probe any
97+
newly-discovered versions before shipping them; if one fails to build with the
98+
current toolchain, add it to `versions/<shell>.excluded` (with a comment recording
99+
the failure) and re-run the update to drop it. Finally, run
100+
`sh shvr.sh github_regen_all` to regenerate the `.github/` build matrix from the
101+
data files, and commit `versions/` and `.github/` together.

shvr.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ shvr_update ()
8585
while test $# -gt 0
8686
do
8787
interpreter="$1"
88-
shvr_clear_versioninfo
8988
. "${SHVR_DIR_SELF}/variants/${interpreter}.sh"
9089
if command -v "shvr_update_${interpreter}" >/dev/null 2>&1
9190
then "shvr_update_${interpreter}"

0 commit comments

Comments
 (0)