Skip to content

Commit bf5aa0d

Browse files
author
Jan Petr
authored
Merge pull request #972 from algolia/develop
Develop
2 parents c91305c + 48f22bc commit bf5aa0d

File tree

30 files changed

+542
-272
lines changed

30 files changed

+542
-272
lines changed

‎.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ install:
1717
- composer install --no-scripts
1818

1919
script:
20-
- dev/runTests.sh -a $ALGOLIA_APPLICATION_ID -k $ALGOLIA_API_KEY -s $ALGOLIA_SEARCH_API_KEY -b http://magento.local -p magento1_tests_ -v 193 --xdebug
20+
- dev/runTests.sh -a $ALGOLIA_APPLICATION_ID -k $ALGOLIA_API_KEY -s $ALGOLIA_SEARCH_API_KEY -b http://magento.local -p magento1_tests_ -v 193

‎CHANGELOG.md

Lines changed: 102 additions & 76 deletions
Large diffs are not rendered by default.

‎README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Algolia Search for Magento 1.6+
22
==================
33

4-
![Latest version](https://img.shields.io/badge/latest-1.12.0-green.svg)
4+
![Latest version](https://img.shields.io/badge/latest-1.13.0-green.svg)
55

66
[![Build Status](https://travis-ci.org/algolia/algoliasearch-magento.svg?branch=master)](https://travis-ci.org/algolia/algoliasearch-magento)
77
![PHP >= 5.3](https://img.shields.io/badge/php-%3E=5.3-green.svg)

‎app/code/community/Algolia/Algoliasearch/Block/Adminhtml/Notifications.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function getQueueInfo()
2626

2727
$readConnection = $resource->getConnection('core_read');
2828

29-
$size = (int)$readConnection->query('SELECT COUNT(*) as total_count FROM '.$tableName)->fetchColumn(0);
29+
$size = (int) $readConnection->query('SELECT COUNT(*) as total_count FROM '.$tableName)->fetchColumn(0);
3030
$maxJobsPerSingleRun = $config->getNumberOfJobToRun();
3131

3232
$etaMinutes = ceil($size / $maxJobsPerSingleRun) * 5; // 5 - assuming the queue runner runs every 5 minutes

‎app/code/community/Algolia/Algoliasearch/Helper/Algoliahelper.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,10 @@ public function __construct()
3434
\AlgoliaSearch\Version::addPrefixUserAgentSegment('Magento integration', $version);
3535
\AlgoliaSearch\Version::addSuffixUserAgentSegment('PHP', phpversion());
3636
\AlgoliaSearch\Version::addSuffixUserAgentSegment('Magento', Mage::getVersion());
37+
38+
if (method_exists('Mage', 'getEdition')) {
39+
\AlgoliaSearch\Version::addSuffixUserAgentSegment('Edition', Mage::getEdition());
40+
}
3741
}
3842

3943
public function resetCredentialsFromConfig()

‎app/code/community/Algolia/Algoliasearch/Helper/Config.php

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ class Algolia_Algoliasearch_Helper_Config extends Mage_Core_Helper_Abstract
2121
const MAX_VALUES_PER_FACET = 'algoliasearch/instant/max_values_per_facet';
2222
const SORTING_INDICES = 'algoliasearch/instant/sorts';
2323
const XML_ADD_TO_CART_ENABLE = 'algoliasearch/instant/add_to_cart_enable';
24+
const INFINITE_SCROLL_ENABLE = 'algoliasearch/instant/infinite_scroll_enable';
2425

2526
const NB_OF_PRODUCTS_SUGGESTIONS = 'algoliasearch/autocomplete/nb_of_products_suggestions';
2627
const NB_OF_CATEGORIES_SUGGESTIONS = 'algoliasearch/autocomplete/nb_of_categories_suggestions';
@@ -78,6 +79,7 @@ class Algolia_Algoliasearch_Helper_Config extends Mage_Core_Helper_Abstract
7879
const INDEX_PRODUCT_ON_CATEGORY_PRODUCTS_UPDATE = 'algoliasearch/advanced/index_product_on_category_products_update';
7980
const INDEX_ALL_CATEGORY_PRODUCTS_ON_CATEGORY_UPDATE = 'algoliasearch/advanced/index_all_category_product_on_category_update';
8081
const PREVENT_BACKEND_RENDERING = 'algoliasearch/advanced/prevent_backend_rendering';
82+
const PREVENT_BACKEND_RENDERING_DISPLAY_MODE = 'algoliasearch/advanced/prevent_backend_rendering_display_mode';
8183
const BACKEND_RENDERING_ALLOWED_USER_AGENTS = 'algoliasearch/advanced/backend_rendering_allowed_user_agents';
8284

8385
const SHOW_OUT_OF_STOCK = 'cataloginventory/options/show_out_of_stock';
@@ -242,6 +244,12 @@ public function isAddToCartEnable($storeId = null)
242244
return Mage::getStoreConfigFlag(self::XML_ADD_TO_CART_ENABLE, $storeId);
243245
}
244246

247+
public function isInfiniteScrollEnabled($storeId = null)
248+
{
249+
return $this->isInstantEnabled($storeId)
250+
&& Mage::getStoreConfigFlag(self::INFINITE_SCROLL_ENABLE, $storeId);
251+
}
252+
245253
public function isRemoveBranding($storeId = null)
246254
{
247255
return Mage::getStoreConfigFlag(self::REMOVE_BRANDING, $storeId);
@@ -445,6 +453,7 @@ public function getAttributesToRetrieve($group_id)
445453
'image_url',
446454
'in_stock',
447455
'type_id',
456+
'value', // for additional sections
448457
));
449458

450459
/** @var Mage_Directory_Model_Currency $currencyDirectory */
@@ -670,6 +679,11 @@ public function preventBackendRendering($storeId = null)
670679
return true;
671680
}
672681

682+
public function getBackendRenderingDisplayMode($storeId = null)
683+
{
684+
return Mage::getStoreConfig(self::PREVENT_BACKEND_RENDERING_DISPLAY_MODE, $storeId);
685+
}
686+
673687
private function getCustomRanking($configName, $storeId = null)
674688
{
675689
$attrs = unserialize(Mage::getStoreConfig($configName, $storeId));

‎app/code/community/Algolia/Algoliasearch/Helper/Entity/Helper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ protected function strip($s, $completeRemoveTags = array())
8282
{
8383
if (!empty($completeRemoveTags)) {
8484
$dom = new DOMDocument();
85-
if (@$dom->loadHTML($s)) {
85+
if (@$dom->loadHTML('<?xml encoding="utf-8" ?>' . $s)) {
8686
$toRemove = array();
8787
foreach ($completeRemoveTags as $tag) {
8888
$removeTags = $dom->getElementsByTagName($tag);

‎app/code/community/Algolia/Algoliasearch/Helper/Entity/Producthelper.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ public function getProductCollectionQuery($storeId, $productIds = null, $only_vi
151151

152152
$products = $products->setStoreId($storeId);
153153
$products = $products->addStoreFilter($storeId);
154+
$products = $products->distinct(true);
154155

155156
if ($productIds && count($productIds) > 0) {
156157
$products = $products->addAttributeToFilter('entity_id', array('in' => $productIds));
@@ -171,6 +172,7 @@ public function getProductCollectionQuery($storeId, $productIds = null, $only_vi
171172
}
172173

173174
$products = $products
175+
->addAttributeToSelect('special_price')
174176
->addAttributeToSelect('special_from_date')
175177
->addAttributeToSelect('special_to_date')
176178
->addAttributeToSelect('visibility')
@@ -897,7 +899,7 @@ public function getObject(Mage_Catalog_Model_Product $product)
897899

898900
foreach ($additionalAttributes as $attribute) {
899901
$attribute_name = $attribute['attribute'];
900-
if (isset($customData[$attribute_name])) {
902+
if (array_key_exists($attribute_name, $customData)) {
901903
continue;
902904
}
903905

‎app/code/community/Algolia/Algoliasearch/Model/Observer.php

Lines changed: 77 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@ public function __construct()
3030
}
3131

3232
/**
33-
* On config save.
33+
* On configuration save
34+
*
35+
* @param Varien_Event_Observer $observer
3436
*/
3537
public function configSaved(Varien_Event_Observer $observer)
3638
{
@@ -57,33 +59,36 @@ public function addBundleToAdmin(Varien_Event_Observer $observer)
5759
$req = Mage::app()->getRequest();
5860

5961
if (strpos($req->getPathInfo(), 'system_config/edit/section/algoliasearch') !== false) {
60-
$observer->getLayout()->getUpdate()->addHandle('algolia_bundle_handle');
62+
$observer->getData('layout')->getUpdate()->addHandle('algolia_bundle_handle');
6163
}
6264
}
6365

6466
/**
65-
* Call algoliasearch.xml To load js / css / phtml.
67+
* Call algoliasearch.xml to load JS / CSS / PHTMLs
68+
*
69+
* @param Varien_Event_Observer $observer
70+
* @return $this
6671
*/
6772
public function useAlgoliaSearchPopup(Varien_Event_Observer $observer)
6873
{
69-
if ($this->config->isEnabledFrontEnd()) {
70-
if ($this->config->getApplicationID() && $this->config->getAPIKey()) {
71-
if ($this->config->isPopupEnabled() || $this->config->isInstantEnabled()) {
72-
$observer->getLayout()->getUpdate()->addHandle('algolia_search_handle');
73-
74-
if ($this->config->isDefaultSelector()) {
75-
$observer->getLayout()->getUpdate()->addHandle('algolia_search_handle_with_topsearch');
76-
} else {
77-
$observer->getLayout()->getUpdate()->addHandle('algolia_search_handle_no_topsearch');
78-
}
74+
if (!$this->config->isEnabledFrontEnd()) {
75+
return $this;
76+
}
7977

80-
if ($this->config->preventBackendRendering() === true) {
81-
$observer->getLayout()->getUpdate()->addHandle('algolia_search_handle_prevent_backend_rendering');
82-
}
83-
}
84-
}
78+
if (!$this->config->getApplicationID() || !$this->config->getAPIKey()) {
79+
return $this;
8580
}
8681

82+
$this->loadAlgoliasearchHandle($observer);
83+
84+
$this->loadSearchFormHandle($observer);
85+
86+
$this->loadInstantSearchHandle($observer);
87+
88+
$this->loadAutocompleteHandle($observer);
89+
90+
$this->loadPreventBackendRenderingHandle($observer);
91+
8792
return $this;
8893
}
8994

@@ -244,4 +249,58 @@ public function moveProductsTmpIndex(Varien_Object $event)
244249

245250
$this->helper->moveProductsIndex($storeId);
246251
}
252+
253+
private function loadAlgoliasearchHandle(Varien_Event_Observer $observer)
254+
{
255+
if (!$this->config->isPopupEnabled() && !$this->config->isInstantEnabled()) {
256+
return;
257+
}
258+
259+
$observer->getData('layout')->getUpdate()->addHandle('algolia_search_handle');
260+
}
261+
262+
private function loadSearchFormHandle(Varien_Event_Observer $observer)
263+
{
264+
if (!$this->config->isDefaultSelector()) {
265+
return;
266+
}
267+
268+
$observer->getData('layout')->getUpdate()->addHandle('algolia_search_handle_with_topsearch');
269+
}
270+
271+
private function loadInstantSearchHandle(Varien_Event_Observer $observer)
272+
{
273+
if (!$this->config->isInstantEnabled()) {
274+
return;
275+
}
276+
277+
$category = Mage::registry('current_category');
278+
if ($this->config->replaceCategories() && $category && $category->getDisplayMode() === 'PAGE') {
279+
return;
280+
}
281+
282+
$observer->getData('layout')->getUpdate()->addHandle('algolia_search_handle_instantsearch');
283+
}
284+
285+
private function loadAutocompleteHandle(Varien_Event_Observer $observer)
286+
{
287+
if ($this->config->isPopupEnabled()) {
288+
$observer->getData('layout')->getUpdate()->addHandle('algolia_search_handle_autocomplete');
289+
}
290+
}
291+
292+
private function loadPreventBackendRenderingHandle(Varien_Event_Observer $observer)
293+
{
294+
if (!$this->config->preventBackendRendering()) {
295+
return;
296+
}
297+
298+
$category = Mage::registry('current_category');
299+
$backendRenderingDisplayMode = $this->config->getBackendRenderingDisplayMode();
300+
if ($category && $backendRenderingDisplayMode === 'only_products' && $category->getDisplayMode() === 'PAGE') {
301+
return;
302+
}
303+
304+
$observer->getData('layout')->getUpdate() ->addHandle('algolia_search_handle_prevent_backend_rendering');
305+
}
247306
}

‎app/code/community/Algolia/Algoliasearch/Model/Resource/Fulltext.php

Lines changed: 32 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public function prepareResult($object, $queryText, $query)
3131

3232
protected function _saveProductIndexes($storeId, $productIndexes)
3333
{
34-
if ($this->config->isEnabledBackend(Mage::app()->getStore()->getId()) === false) {
34+
if ($this->config->isEnabledBackend($storeId) === false) {
3535
return parent::_saveProductIndexes($storeId, $productIndexes);
3636
}
3737

@@ -40,32 +40,56 @@ protected function _saveProductIndexes($storeId, $productIndexes)
4040

4141
/**
4242
* Only used when reindexing everything. Otherwise Model/Indexer/Algolia will take care of the rest.
43+
*
44+
* @param int|null $storeId
45+
* @param array|null $productIds
46+
*
47+
* @return $this|Mage_CatalogSearch_Model_Resource_Fulltext
4348
*/
4449
public function rebuildIndex($storeId = null, $productIds = null)
4550
{
46-
if ($this->config->isEnabledBackend(Mage::app()->getStore()->getId()) === false) {
51+
if ($this->config->isModuleOutputEnabled() === false) {
4752
return parent::rebuildIndex($storeId, $productIds);
4853
}
4954

50-
if ($this->config->isModuleOutputEnabled() === false) {
55+
if ($storeId !== null) {
56+
$this->reindex($storeId, $productIds);
57+
58+
return $this;
59+
}
60+
61+
/** @var Mage_Core_Model_Store $store */
62+
foreach (Mage::app()->getStores() as $store) {
63+
$this->reindex($store->getId(), $productIds);
64+
}
65+
66+
return $this;
67+
}
68+
69+
private function reindex($storeId, $productIds)
70+
{
71+
if ($this->config->isEnabledBackend($storeId) === false) {
5172
return parent::rebuildIndex($storeId, $productIds);
5273
}
5374

54-
if (!$this->config->getApplicationID() || !$this->config->getAPIKey() || !$this->config->getSearchOnlyAPIKey()) {
75+
return $this->reindexAlgolia($storeId, $productIds);
76+
}
77+
78+
private function reindexAlgolia($storeId, $productIds)
79+
{
80+
if (!$this->config->getApplicationID($storeId) || !$this->config->getAPIKey($storeId) || !$this->config->getSearchOnlyAPIKey($storeId)) {
5581
/** @var Mage_Adminhtml_Model_Session $session */
5682
$session = Mage::getSingleton('adminhtml/session');
5783
$session->addError('Algolia reindexing failed: You need to configure your Algolia credentials in System > Configuration > Algolia Search.');
5884

59-
return null;
85+
return;
6086
}
6187

6288
/* Avoid Indexing twice */
6389
if (is_array($productIds) && $productIds > 0) {
64-
return $this;
90+
return;
6591
}
6692

6793
$this->engine->rebuildProducts($storeId);
68-
69-
return $this;
7094
}
7195
}

0 commit comments

Comments
 (0)