fix bug for TypeUtils.castToTimestamp, for issue #3906 and #3907 (#3908)

* fix bug for TypeUtils.castToTimestamp, for issue #3906 and #3907

* update

* optimize

* lazy load

Author: jujn

core/src/main/java/com/alibaba/fastjson2/util/JdbcSupport.java

@@ -10,6 +10,7 @@
 import com.alibaba.fastjson2.writer.ObjectWriter;
 
 import java.io.Reader;
+import java.lang.reflect.Constructor;
 import java.lang.reflect.Type;
 import java.sql.SQLException;
 import java.sql.Time;
@@ -26,6 +27,15 @@ public class JdbcSupport {
     static Class CLASS_CLOB;
     static volatile boolean CLASS_CLOB_ERROR;
 
+    static Constructor CONSTRUCTOR_TIMESTAMP;
+    static volatile boolean CONSTRUCTOR_TIMESTAMP_ERROR;
+
+    static Constructor CONSTRUCTOR_DATE;
+    static volatile boolean CONSTRUCTOR_DATE_ERROR;
+
+    static Constructor CONSTRUCTOR_TIME;
+    static volatile boolean CONSTRUCTOR_TIME_ERROR;
+
     public static ObjectReader createTimeReader(Class objectClass, String format, Locale locale) {
         return new TimeReader(format, locale);
     }
@@ -47,15 +57,66 @@ public static ObjectWriter createTimeWriter(String format) {
     }
 
     public static Object createTimestamp(long millis) {
-        return new Timestamp(millis);
+        if (CONSTRUCTOR_TIMESTAMP == null && !CONSTRUCTOR_TIMESTAMP_ERROR) {
+            try {
+                Class<?> clazz = Class.forName("java.sql.Timestamp");
+                CONSTRUCTOR_TIMESTAMP = clazz.getConstructor(long.class);
+            } catch (Throwable e) {
+                CONSTRUCTOR_TIMESTAMP_ERROR = true;
+            }
+        }
+
+        if (CONSTRUCTOR_TIMESTAMP == null) {
+            throw new JSONException("class java.sql.Timestamp not found");
+        }
+
+        try {
+            return CONSTRUCTOR_TIMESTAMP.newInstance(millis);
+        } catch (Exception e) {
+            throw new JSONException("create java.sql.Timestamp error", e);
+        }
     }
 
     public static Object createDate(long millis) {
-        return new java.sql.Date(millis);
+        if (CONSTRUCTOR_DATE == null && !CONSTRUCTOR_DATE_ERROR) {
+            try {
+                Class<?> clazz = Class.forName("java.sql.Date");
+                CONSTRUCTOR_DATE = clazz.getConstructor(long.class);
+            } catch (Throwable e) {
+                CONSTRUCTOR_DATE_ERROR = true;
+            }
+        }
+
+        if (CONSTRUCTOR_DATE == null) {
+            throw new JSONException("class java.sql.Date not found");
+        }
+
+        try {
+            return CONSTRUCTOR_DATE.newInstance(millis);
+        } catch (Exception e) {
+            throw new JSONException("create java.sql.Date error", e);
+        }
     }
 
     public static Object createTime(long millis) {
-        return new java.sql.Time(millis);
+        if (CONSTRUCTOR_TIME == null && !CONSTRUCTOR_TIME_ERROR) {
+            try {
+                Class<?> clazz = Class.forName("java.sql.Time");
+                CONSTRUCTOR_TIME = clazz.getConstructor(long.class);
+            } catch (Throwable e) {
+                CONSTRUCTOR_TIME_ERROR = true;
+            }
+        }
+
+        if (CONSTRUCTOR_TIME == null) {
+            throw new JSONException("class java.sql.Time not found");
+        }
+
+        try {
+            return CONSTRUCTOR_TIME.newInstance(millis);
+        } catch (Exception e) {
+            throw new JSONException("create java.sql.Time error", e);
+        }
     }
 
     public static ObjectWriter createClobWriter(Class objectClass) {

core/src/main/java/com/alibaba/fastjson2/util/TypeUtils.java

@@ -1458,6 +1458,22 @@ public static <T> T cast(Object obj, Class<T> targetClass, ObjectReaderProvider
             }
         }
 
+        if (obj instanceof Date) {
+            long time = ((Date) obj).getTime();
+            String className = targetClass.getName();
+
+            switch (className) {
+                case "java.sql.Timestamp":
+                    return (T) JdbcSupport.createTimestamp(time);
+                case "java.sql.Date":
+                    return (T) JdbcSupport.createDate(time);
+                case "java.sql.Time":
+                    return (T) JdbcSupport.createTime(time);
+                default:
+                    break;
+            }
+        }
+
         if (targetClass == String.class) {
             if (obj instanceof Character) {
                 return (T) obj.toString();

fastjson1-compatible/src/main/java/com/alibaba/fastjson/util/TypeUtils.java

@@ -546,11 +546,11 @@ public static BigInteger castToBigInteger(Object value) {
         return com.alibaba.fastjson2.util.TypeUtils.toBigInteger(value);
     }
 
-    public static Timestamp castToTimestamp(final Object value) {
+    public static Object castToTimestamp(final Object value) {
         return com.alibaba.fastjson2.util.TypeUtils.cast(value, Timestamp.class);
     }
 
-    public static java.sql.Date castToSqlDate(final Object value) {
+    public static Object castToSqlDate(final Object value) {
         return com.alibaba.fastjson2.util.TypeUtils.cast(value, java.sql.Date.class);
     }
 

fastjson1-compatible/src/test/java/com/alibaba/fastjson2/Issue3906.java

@@ -0,0 +1,13 @@
+package com.alibaba.fastjson2;
+
+import com.alibaba.fastjson.util.TypeUtils;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
+public class Issue3906 {
+    @Test
+    public void test() throws NoSuchMethodException {
+        assertDoesNotThrow(() -> TypeUtils.castToTimestamp(new java.util.Date()));
+    }
+}