perf(path): simplified code (#3933)

hchlq · web-flow · commit 8861ef58fc09 · 2023-08-15T10:39:23.000+08:00
diff --git a/packages/path/src/index.ts b/packages/path/src/index.ts
@@ -400,9 +400,10 @@ export class Path {
     if (this.isMatchPattern) {
       throw new Error(`${this.entire} cannot be transformed`)
     }
-    const args = this.segments.reduce((buf, key) => {
-      return new RegExp(regexp).test(key as string) ? buf.concat(key) : buf
-    }, [])
+    const reg = new RegExp(regexp)
+    const args = this.segments.filter((key) =>
+      reg.test(key as string)
+    ) as string[]
     return callback(...args)
   }
 

Original file line number	Diff line number	Diff line change
`@@ -400,9 +400,10 @@ export class Path {`
`400`	`400`	`if (this.isMatchPattern) {`
`401`	`401`	throw new Error(`${this.entire} cannot be transformed`)
`402`	`402`	`}`
`403`		`- const args = this.segments.reduce((buf, key) => {`
`404`		`- return new RegExp(regexp).test(key as string) ? buf.concat(key) : buf`
`405`		`- }, [])`
	`403`	`+ const reg = new RegExp(regexp)`
	`404`	`+ const args = this.segments.filter((key) =>`
	`405`	`+ reg.test(key as string)`
	`406`	`+ ) as string[]`
`406`	`407`	`return callback(...args)`
`407`	`408`	`}`
`408`	`409`