fix

Author: Charlie17Li

test/ingress/conformance/tests/httproute-canary-weight.go

@@ -32,7 +32,7 @@ var HTTPRouteCanaryWeight = suite.ConformanceTest{
 	Test: func(t *testing.T, suite *suite.ConformanceTestSuite) {
 		tt := []struct {
 			assertion http.Assertion
-			succRate  float32
+			succRate  float64
 		}{
 			{
 				succRate: 1.0,

test/ingress/conformance/utils/http/http.go

@@ -408,12 +408,8 @@ func MakeRequestAndCountExpectedResponse(t *testing.T, r roundtripper.RoundTripp
 
 	rate := float64(succ) / totalRequest
 	minSuccRate, maxSuccRate := math.Min(succRate-rateDeviation, 0), math.Max(succRate+rateDeviation, 1.0)
-	if 0 < minSuccRate && rate < minSuccRate {
-		t.Errorf("Test failed, expect the minSuccRate is %v, got %v", minSuccRate, rate)
-		return
-	}
-	if 0 < maxSuccRate && maxSuccRate > rate {
-		t.Errorf("Test failed, expect the maxSuccRate is %v, got %v", maxSuccRate, rate)
+	if rate < minSuccRate || maxSuccRate > rate {
+		t.Errorf("Test failed, expect the minSuccRate is %v, the maxSuccRate is %v, but got %v", minSuccRate, maxSuccRate, rate)
 		return
 	}