[ISSUE #14815] build(style): align Checkstyle with Spotless and enable spotless:check in CI

- Change lineWrappingIndentation from 0 to 4 to match continuation_indentation=1
- Change arrayInitIndent from 8 to 4 to match continuation_indentation_for_array_initializer=1
- Remove all // @Formatter:off/on workarounds (no longer needed)
- Re-format modules affected by continuation_indentation_for_array_initializer change
- Add checkstyle:check and spotless:check to CI check step

Signed-off-by: cxhello <caixiaohuichn@gmail.com>

Author: cxhello

.github/workflows/ci.yml

@@ -33,7 +33,7 @@ jobs:
       - name: "Print maven version"
         run: mvn -version
       - name: "Check with Maven"
-        run: mvn -B clean compile apache-rat:check spotbugs:check -e -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
+        run: mvn -B clean compile apache-rat:check checkstyle:check spotbugs:check spotless:check -e -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
       - name: "Build and Test with Maven"
         run: mvn -B '-Prelease-nacos,!dev' clean install -Drat.skip=true -Dspotbugs.skip=true -DtrimStackTrace=false -U -e -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
       - name: "Upload coverage to Codecov"

ai-registry-adaptor/src/main/java/com/alibaba/nacos/airegistry/controller/SkillsRegistryController.java

@@ -67,12 +67,10 @@ public SkillsRegistryController(NacosSkillsRegistryService nacosSkillsRegistrySe
      * @return well-known index payload
      * @throws NacosException if query fails
      */
-    // @formatter:off
     @GetMapping(value = {
-            WELL_KNOWN_AGENT_SKILLS + "/index.json",
-            WELL_KNOWN_SKILLS + "/index.json"
+        WELL_KNOWN_AGENT_SKILLS + "/index.json",
+        WELL_KNOWN_SKILLS + "/index.json"
     }, produces = MediaType.APPLICATION_JSON_VALUE)
-    // @formatter:on
     public WellKnownSkillsIndex getIndex(@PathVariable String namespaceId) throws NacosException {
         return nacosSkillsRegistryService.buildIndex(namespaceId);
     }
@@ -106,12 +104,10 @@ public SkillsSearchResponse search(@PathVariable String namespaceId, SkillsSearc
      * @return skill markdown when the skill is exportable, otherwise 404
      * @throws NacosException if query fails
      */
-    // @formatter:off
     @GetMapping(value = {
-            WELL_KNOWN_AGENT_SKILLS + "/{skillName}/SKILL.md",
-            WELL_KNOWN_SKILLS + "/{skillName}/SKILL.md"
+        WELL_KNOWN_AGENT_SKILLS + "/{skillName}/SKILL.md",
+        WELL_KNOWN_SKILLS + "/{skillName}/SKILL.md"
     }, produces = MediaType.TEXT_PLAIN_VALUE)
-    // @formatter:on
     public ResponseEntity<String> getSkillMarkdown(@PathVariable String namespaceId,
         @PathVariable String skillName)
         throws NacosException {
@@ -135,12 +131,10 @@ public ResponseEntity<String> getSkillMarkdown(@PathVariable String namespaceId,
      * @return file content when the skill and file are exportable, otherwise 404
      * @throws NacosException if query fails
      */
-    // @formatter:off
     @GetMapping(value = {
-            WELL_KNOWN_AGENT_SKILLS + "/{skillName}/**",
-            WELL_KNOWN_SKILLS + "/{skillName}/**"
+        WELL_KNOWN_AGENT_SKILLS + "/{skillName}/**",
+        WELL_KNOWN_SKILLS + "/{skillName}/**"
     }, produces = MediaType.TEXT_PLAIN_VALUE)
-    // @formatter:on
     public ResponseEntity<String> getSkillFile(@PathVariable String namespaceId,
         @PathVariable String skillName,
         HttpServletRequest request) throws NacosException {

ai/src/main/java/com/alibaba/nacos/ai/service/repository/AiResourcePersistServiceImpl.java

@@ -156,9 +156,9 @@ public boolean updateMetaCas(String namespaceId, String name, String type,
                 + " WHERE namespace_id=? AND name=? AND type=? AND meta_version=?";
 
         Object[] args = new Object[] {newValue.getStatus(), newValue.getDesc(),
-                newValue.getBizTags(), newValue.getExt(),
-                newValue.getVersionInfo(), normalizeNamespaceId(namespaceId), name, type,
-                expectedMetaVersion};
+            newValue.getBizTags(), newValue.getExt(),
+            newValue.getVersionInfo(), normalizeNamespaceId(namespaceId), name, type,
+            expectedMetaVersion};
         int rows = jt.update(sql, args);
         return rows == 1;
     }

ai/src/main/java/com/alibaba/nacos/ai/service/repository/EmbeddedAiResourcePersistServiceImpl.java

@@ -76,15 +76,15 @@ public long insert(AiResource resource) {
                 "gmt_modified@NOW()"));
 
         Object[] args = new Object[] {resource.getName(), resource.getType(), resource.getDesc(),
-                resource.getStatus(),
-                normalizeNamespaceId(resource.getNamespaceId()), resource.getBizTags(),
-                resource.getExt(),
-                resource.getFrom() == null ? "local" : resource.getFrom(),
-                resource.getVersionInfo(),
-                resource.getMetaVersion() == null ? 1L : resource.getMetaVersion(),
-                resource.getScope() == null ? VisibilityConstants.SCOPE_PRIVATE
-                    : resource.getScope(),
-                resource.getOwner() == null ? "" : resource.getOwner()};
+            resource.getStatus(),
+            normalizeNamespaceId(resource.getNamespaceId()), resource.getBizTags(),
+            resource.getExt(),
+            resource.getFrom() == null ? "local" : resource.getFrom(),
+            resource.getVersionInfo(),
+            resource.getMetaVersion() == null ? 1L : resource.getMetaVersion(),
+            resource.getScope() == null ? VisibilityConstants.SCOPE_PRIVATE
+                : resource.getScope(),
+            resource.getOwner() == null ? "" : resource.getOwner()};
 
         EmbeddedStorageContextHolder.addSqlContext(sql, args);
         Boolean success = databaseOperate.blockUpdate();
@@ -146,9 +146,9 @@ public boolean updateMetaCas(String namespaceId, String name, String type,
                 + " WHERE namespace_id=? AND name=? AND type=? AND meta_version=?";
 
         Object[] args = new Object[] {newValue.getStatus(), newValue.getDesc(),
-                newValue.getBizTags(), newValue.getExt(),
-                newValue.getVersionInfo(), normalizeNamespaceId(namespaceId), name, type,
-                expectedMetaVersion};
+            newValue.getBizTags(), newValue.getExt(),
+            newValue.getVersionInfo(), normalizeNamespaceId(namespaceId), name, type,
+            expectedMetaVersion};
 
         EmbeddedStorageContextHolder.addSqlContext(sql, args);
         Boolean success = databaseOperate.blockUpdate();

ai/src/main/java/com/alibaba/nacos/ai/service/repository/EmbeddedAiResourceVersionPersistServiceImpl.java

@@ -76,10 +76,10 @@ public long insert(AiResourceVersion version) {
                 "storage", "publish_pipeline_info", "gmt_create@NOW()", "gmt_modified@NOW()"));
 
         Object[] args = new Object[] {version.getType(), version.getAuthor(), version.getName(),
-                version.getDesc(),
-                version.getStatus(), version.getVersion(),
-                normalizeNamespaceId(version.getNamespaceId()),
-                version.getStorage(), version.getPublishPipelineInfo()};
+            version.getDesc(),
+            version.getStatus(), version.getVersion(),
+            normalizeNamespaceId(version.getNamespaceId()),
+            version.getStorage(), version.getPublishPipelineInfo()};
 
         EmbeddedStorageContextHolder.addSqlContext(sql, args);
         Boolean success = databaseOperate.blockUpdate();
@@ -256,7 +256,7 @@ public int updatePublishPipelineInfo(String namespaceId, String name, String typ
 
         EmbeddedStorageContextHolder.addSqlContext(sql,
             new Object[] {publishPipelineInfo, normalizeNamespaceId(namespaceId), name, type,
-                    version});
+                version});
         Boolean success = databaseOperate.blockUpdate();
         return (success != null && success) ? 1 : 0;
     }

ai/src/test/java/com/alibaba/nacos/ai/pipeline/PublishPipelineBackwardCompatibilityTest.java

@@ -169,7 +169,7 @@ void testSkillPluginOrderPreservedAfterAgentspecAddition() {
 
         List<PipelineNodeConfig> nodes = new ArrayList<>();
         for (String id : new String[] {PLUGIN_SKILL_HIGH_ORDER_ID, PLUGIN_AGENTSPEC_ID,
-                PLUGIN_SKILL_LOW_ORDER_ID}) {
+            PLUGIN_SKILL_LOW_ORDER_ID}) {
             PipelineNodeConfig node = new PipelineNodeConfig();
             node.setPipelineId(id);
             node.setProperties(new Properties());

ai/src/test/java/com/alibaba/nacos/ai/pipeline/PublishPipelineExecutorTest.java

@@ -445,7 +445,7 @@ private static List<CallbackTestInput> sampleCallbackTestInputs() {
         List<CallbackTestInput> list = new ArrayList<>();
         List<String> ids = Arrays.asList("x", "y", "z");
         for (PublishPipelineResourceType rt : new PublishPipelineResourceType[] {
-                PublishPipelineResourceType.SKILL, PublishPipelineResourceType.PROMPT}) {
+            PublishPipelineResourceType.SKILL, PublishPipelineResourceType.PROMPT}) {
             for (int failAt : new int[] {-1, 0, 1}) {
                 list.add(new CallbackTestInput(ids, rt, failAt));
             }

ai/src/test/java/com/alibaba/nacos/ai/pipeline/PublishPipelineManagerRoutingTest.java

@@ -73,7 +73,7 @@ void setUp() {
         // Plugin C: supports both SKILL and AGENTSPEC
         builders.add(createBuilder(PLUGIN_C_ID, 3,
             new PublishPipelineResourceType[] {PublishPipelineResourceType.SKILL,
-                    PublishPipelineResourceType.AGENTSPEC}));
+                PublishPipelineResourceType.AGENTSPEC}));
 
         PipelineConfig config = new PipelineConfig();
         config.setEnabled(true);

ai/src/test/java/com/alibaba/nacos/ai/pipeline/PublishPipelineManagerTest.java

@@ -116,7 +116,7 @@ private static List<FilterTestInput> sampleFilterTestInputs() {
             new ServiceDescriptor("a", 1,
                 new PublishPipelineResourceType[] {PublishPipelineResourceType.SKILL}),
             new ServiceDescriptor("b", 2, new PublishPipelineResourceType[] {
-                    PublishPipelineResourceType.SKILL, PublishPipelineResourceType.AGENTSPEC}));
+                PublishPipelineResourceType.SKILL, PublishPipelineResourceType.AGENTSPEC}));
         list.add(
             new FilterTestInput(svc1, PublishPipelineResourceType.SKILL, Arrays.asList("a", "b")));
         list.add(new FilterTestInput(svc1, PublishPipelineResourceType.SKILL,

ai/src/test/java/com/alibaba/nacos/ai/pipeline/repository/PipelineExecutionRepositoryTest.java

@@ -87,7 +87,7 @@ private static List<PipelineExecution> samplePipelineExecutions() {
         long t = 1_700_000_000_000L;
         for (String resType : new String[] {"SKILL", "PROMPT", "CONFIG"}) {
             for (PipelineExecutionStatus status : new PipelineExecutionStatus[] {
-                    PipelineExecutionStatus.APPROVED, PipelineExecutionStatus.REJECTED}) {
+                PipelineExecutionStatus.APPROVED, PipelineExecutionStatus.REJECTED}) {
                 PipelineExecution execution = new PipelineExecution();
                 execution.setExecutionId(UUID.randomUUID().toString());
                 execution.setResourceType(resType);