Skip to content

Commit 93ddd8a

Browse files
committed
fix: clean up macOS CMake options
1 parent 65477f7 commit 93ddd8a

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

CMakeLists.txt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,6 @@ option(PAIMON_ENABLE_LANCE "Whether to enable lance file format" OFF)
5454
option(PAIMON_ENABLE_JINDO "Whether to enable jindo file system" OFF)
5555
option(PAIMON_ENABLE_LUMINA "Whether to enable lumina vector index" OFF)
5656
option(PAIMON_ENABLE_LUCENE "Whether to enable lucene index" OFF)
57-
option(PAIMON_USE_APPLE_LIBCXX_WITH_CLANG
58-
"Use Apple SDK libc++ headers when building with upstream Clang on macOS" ON)
59-
6057
if(PAIMON_ENABLE_ORC)
6158
add_definitions(-DPAIMON_ENABLE_ORC)
6259
endif()
@@ -298,8 +295,6 @@ if(PAIMON_ENABLE_LANCE)
298295
DESTINATION ${CMAKE_INSTALL_LIBDIR})
299296
endif()
300297
301-
list(APPEND PAIMON_LINK_LIBS ${CMAKE_DL_LIBS})
302-
list(APPEND PAIMON_SHARED_INSTALL_INTERFACE_LIBS ${CMAKE_DL_LIBS})
303298
if(PAIMON_ENABLE_LUMINA)
304299
add_subdirectory(third_party/lumina EXCLUDE_FROM_ALL)
305300
link_directories(third_party/lumina/lib)

cmake_modules/DefineOptions.cmake

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,10 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")
9898

9999
define_option(PAIMON_USE_CCACHE "Use ccache when compiling (if available)" ON)
100100

101+
define_option(PAIMON_USE_APPLE_LIBCXX_WITH_CLANG
102+
"Use Apple SDK libc++ headers when building with upstream Clang on macOS"
103+
ON)
104+
101105
#----------------------------------------------------------------------
102106
set_option_category("Test")
103107

0 commit comments

Comments
 (0)