Skip to content

Support blocked log recording #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

liqiangz
Copy link
Contributor

@liqiangz liqiangz commented Oct 20, 2020

Describe what this PR does / why we need it

Support blocked log recording
log example :
2020-10-20 22:52:10|some-test22|FlowControl|2000
time|resource name|block type|block times

Does this pull request fix one issue?

fixed #130

Describe how you did it

This is a StatLogger implementation like https://github.com/alibaba/Sentinel/tree/master/sentinel-core/src/main/java/com/alibaba/csp/sentinel/eagleeye

Describe how to verify it

Run stat_logger_test.go.
Run qps_limit_example.go and check log file.

Special notes for reviews

@louyuting louyuting added the area/logging Issue related to logging of Sentinel label Oct 20, 2020
@codecov-io
Copy link

Codecov Report

Merging #297 into master will decrease coverage by 0.01%.
The diff coverage is 51.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
- Coverage   51.44%   51.42%   -0.02%     
==========================================
  Files          80       83       +3     
  Lines        4010     4196     +186     
==========================================
+ Hits         2063     2158      +95     
- Misses       1661     1745      +84     
- Partials      286      293       +7     
Impacted Files Coverage Δ
core/statlogger/stat_writer.go 12.64% <12.64%> (ø)
core/statlogger/stat_log_controller.go 80.00% <80.00%> (ø)
core/statlogger/stat_logger.go 88.13% <88.13%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9496ed...f44ff55. Read the comment docs.

@sczyh30 sczyh30 added the kind/feature Category issues or PRs related to feature request label Oct 21, 2020
@sczyh30 sczyh30 added this to the 1.1.0 milestone Nov 9, 2020
@liqiangz liqiangz requested a review from binbin0325 December 6, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Issue related to logging of Sentinel kind/feature Category issues or PRs related to feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging: Support flow-limited log recording
5 participants