Skip to content

feat: JSpecify annotations for starters module#4269

Open
yuluo-yx wants to merge 16 commits into2025.1.xfrom
0225-yuluo/feat
Open

feat: JSpecify annotations for starters module#4269
yuluo-yx wants to merge 16 commits into2025.1.xfrom
0225-yuluo/feat

Conversation

@yuluo-yx
Copy link
Collaborator

@yuluo-yx yuluo-yx commented Feb 26, 2026

只改了 starter 模块,有下面几个问题:

  1. google errorprone 高版本需要 jdk21+,classfile 61 和 65 文件版本不匹配;target 版本是 17,编译是 jdk21
  2. 低版本不能和 uber nullway 很好配合用;
  3. 修改量比较多,可以用 mvn clean compile -Dmaven.test.skip=true 本地编译;
  4. 对泛型目前不是很友好,特别是继承了泛型方法时。

@uuuyuqi

Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
@yuluo-yx yuluo-yx changed the title feat: JSpecify annotations for starters module [WIP] feat: JSpecify annotations for starters module Feb 26, 2026
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
@uuuyuqi
Copy link
Collaborator

uuuyuqi commented Mar 9, 2026

看下来应该问题不大,不过编译时 jdk 版本是不是需要从 17 升级到 21?可能会增加贡献门槛

@yuluo-yx
Copy link
Collaborator Author

yuluo-yx commented Mar 9, 2026

看下来应该问题不大,不过编译时 jdk 版本是不是需要从 17 升级到 21?可能会增加贡献门槛

是的,这是一个限制,主要是因为 google errorprone 对 jdk 有要求

yuluo-yx added 3 commits March 9, 2026 21:16
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>

# Conflicts:
#	spring-cloud-alibaba-starters/spring-alibaba-nacos-config/src/main/java/com/alibaba/cloud/nacos/NacosConfigProperties.java
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
@yuluo-yx yuluo-yx changed the title [WIP] feat: JSpecify annotations for starters module feat: JSpecify annotations for starters module Mar 10, 2026
@uuuyuqi
Copy link
Collaborator

uuuyuqi commented Mar 21, 2026

@yuluo-yx 空了再看下评论,没其他问题的话我就合并了~

Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants