feat: JSpecify annotations for starters module#4269
Open
feat: JSpecify annotations for starters module#4269
Conversation
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
uuuyuqi
reviewed
Mar 9, 2026
...spring-alibaba-nacos-config/src/main/java/com/alibaba/cloud/nacos/NacosConfigProperties.java
Outdated
Show resolved
Hide resolved
Collaborator
|
看下来应该问题不大,不过编译时 jdk 版本是不是需要从 17 升级到 21?可能会增加贡献门槛 |
Collaborator
Author
是的,这是一个限制,主要是因为 google errorprone 对 jdk 有要求 |
uuuyuqi
reviewed
Mar 21, 2026
...loud-starter-alibaba-seata/src/main/java/com/alibaba/cloud/seata/webflux/SeataWebFilter.java
Outdated
Show resolved
Hide resolved
uuuyuqi
reviewed
Mar 21, 2026
...ba-nacos-config/src/main/java/com/alibaba/cloud/nacos/annotation/CustomDateDeserializer.java
Outdated
Show resolved
Hide resolved
uuuyuqi
reviewed
Mar 21, 2026
...spring-alibaba-nacos-config/src/main/java/com/alibaba/cloud/nacos/NacosConfigProperties.java
Outdated
Show resolved
Hide resolved
uuuyuqi
reviewed
Mar 21, 2026
...libaba-nacos-config/src/main/java/com/alibaba/cloud/nacos/NacosPropertiesPrefixProvider.java
Outdated
Show resolved
Hide resolved
uuuyuqi
reviewed
Mar 21, 2026
...a-schedulerx/src/main/java/com/alibaba/cloud/scheduling/schedulerx/service/package-info.java
Show resolved
Hide resolved
Collaborator
|
@yuluo-yx 空了再看下评论,没其他问题的话我就合并了~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
只改了 starter 模块,有下面几个问题:
@uuuyuqi