Skip to content

Commit 334a991

Browse files
lucky-zzzlucky-zzz
committed
[metrics] update ReportEvent metrics
1 parent ab83747 commit 334a991

11 files changed

Lines changed: 96 additions & 94 deletions

‎kv_cache_manager/metrics/kmonitor_metrics_reporter.cc‎

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,6 @@ struct KmonitorMetricsReporter::Context {
5050
DECLARE_METRICS(service, error_qps);
5151
DECLARE_METRICS(service, request_queue_size);
5252

53-
DECLARE_METRICS(event_report, qps);
54-
DECLARE_METRICS(event_report, request_rt_us);
55-
DECLARE_METRICS(event_report, error_qps);
56-
5753
// manager metrics metrics
5854
DECLARE_METRICS(manager, request_key_count);
5955
DECLARE_METRICS(manager, prefix_match_len);
@@ -310,10 +306,6 @@ bool KmonitorMetricsReporter::InitMetrics() {
310306
REGISTER_QPS_METRIC(service, error_qps);
311307
REGISTER_GAUGE_METRIC(service, request_queue_size);
312308

313-
REGISTER_QPS_METRIC(event_report, qps);
314-
REGISTER_GAUGE_METRIC(event_report, request_rt_us);
315-
REGISTER_QPS_METRIC(event_report, error_qps);
316-
317309
// manager metrics
318310
REGISTER_GAUGE_METRIC(manager, request_key_count);
319311
REGISTER_GAUGE_METRIC(manager, prefix_match_len);
@@ -556,11 +548,11 @@ void KmonitorMetricsReporter::ReportPerQuery(MetricsCollector *collector) {
556548
} else if (dynamic_cast<EventReportMetricsCollector *>(collector)) {
557549
auto *p = dynamic_cast<EventReportMetricsCollector *>(collector);
558550
const kmonitor::MetricsTags tags = ctx_->GetKmonitorTags(p->GetMetricsTags());
559-
REPORT_METRICS(event_report, qps, 1.0);
560-
REPORT_METRICS(event_report, request_rt_us, p->GetRequestRtUsSample());
551+
REPORT_METRICS(service, qps, 1.0);
552+
REPORT_METRICS(service, query_rt_us, p->GetRequestRtUsSample());
561553

562554
const double error_code = p->GetErrorCodeSample();
563-
REPORT_METRICS_WHEN(event_report, error_qps, 1.0, !CommonUtil::IsZeroDouble(error_code));
555+
REPORT_METRICS_WHEN(service, error_qps, 1.0, !CommonUtil::IsZeroDouble(error_code));
564556
if (p->HasRequestKeyCountSample()) {
565557
REPORT_METRICS(manager, request_key_count, p->GetRequestKeyCountSample());
566558
}

‎kv_cache_manager/metrics/local_metrics_reporter.cc‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,15 +65,15 @@ void LocalMetricsReporter::ReportPerQuery(MetricsCollector *collector) {
6565
} while (false);
6666
} else if (dynamic_cast<EventReportMetricsCollector *>(collector)) {
6767
auto *p = dynamic_cast<EventReportMetricsCollector *>(collector);
68-
Counter request_counter;
69-
COPY_METRICS_(p, event_report, request_counter, request_counter);
70-
++request_counter;
68+
Counter service_query_counter;
69+
COPY_METRICS_(p, service, query_counter, service_query_counter);
70+
++service_query_counter;
7171

7272
const double error_code = p->GetErrorCodeSample();
7373
if (!CommonUtil::IsZeroDouble(error_code)) {
74-
Counter error_counter;
75-
COPY_METRICS_(p, event_report, error_counter, error_counter);
76-
++error_counter;
74+
Counter service_error_counter;
75+
COPY_METRICS_(p, service, error_counter, service_error_counter);
76+
++service_error_counter;
7777
}
7878
} else if (dynamic_cast<DataStorageMetricsCollector *>(collector)) {
7979
auto *p = dynamic_cast<DataStorageMetricsCollector *>(collector);

‎kv_cache_manager/metrics/metrics_collector.cc‎

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -190,20 +190,21 @@ bool ServiceMetricsCollector::Init() {
190190

191191
/* ---------------- EventReportMetricsCollector -------------------- */
192192

193-
#define DEFINE_METRICS_NAME_FOR_EVENT_REPORT(name) DEFINE_METRICS_NAME_(EventReportMetricsCollector, event_report, name)
194-
#define REGISTER_COUNTER_METRICS_FOR_EVENT_REPORT(name) \
195-
REGISTER_METRICS_W_TAGS_COUNTER_(metrics_registry_, event_report, name, metrics_tags_)
196-
#define REGISTER_GAUGE_METRICS_FOR_EVENT_REPORT(name) \
197-
REGISTER_METRICS_W_TAGS_GAUGE_(metrics_registry_, event_report, name, metrics_tags_)
193+
#define DEFINE_METRICS_NAME_FOR_EVENT_REPORT_SERVICE(name) \
194+
DEFINE_METRICS_NAME_(EventReportMetricsCollector, service, name)
195+
#define REGISTER_COUNTER_METRICS_FOR_EVENT_REPORT_SERVICE(name) \
196+
REGISTER_METRICS_W_TAGS_COUNTER_(metrics_registry_, service, name, metrics_tags_)
197+
#define REGISTER_GAUGE_METRICS_FOR_EVENT_REPORT_SERVICE(name) \
198+
REGISTER_METRICS_W_TAGS_GAUGE_(metrics_registry_, service, name, metrics_tags_)
198199
#define DEFINE_METRICS_NAME_FOR_EVENT_REPORT_MANAGER(name) \
199200
DEFINE_METRICS_NAME_(EventReportMetricsCollector, manager, name)
200201
#define REGISTER_GAUGE_METRICS_FOR_EVENT_REPORT_MANAGER(name) \
201202
REGISTER_METRICS_W_TAGS_GAUGE_(metrics_registry_, manager, name, metrics_tags_)
202203

203-
DEFINE_METRICS_NAME_FOR_EVENT_REPORT(request_counter);
204-
DEFINE_METRICS_NAME_FOR_EVENT_REPORT(request_rt_us);
205-
DEFINE_METRICS_NAME_FOR_EVENT_REPORT(error_code);
206-
DEFINE_METRICS_NAME_FOR_EVENT_REPORT(error_counter);
204+
DEFINE_METRICS_NAME_FOR_EVENT_REPORT_SERVICE(query_counter);
205+
DEFINE_METRICS_NAME_FOR_EVENT_REPORT_SERVICE(query_rt_us);
206+
DEFINE_METRICS_NAME_FOR_EVENT_REPORT_SERVICE(error_code);
207+
DEFINE_METRICS_NAME_FOR_EVENT_REPORT_SERVICE(error_counter);
207208
DEFINE_METRICS_NAME_FOR_EVENT_REPORT_MANAGER(request_key_count);
208209

209210
EventReportMetricsCollector::EventReportMetricsCollector(std::shared_ptr<MetricsRegistry> metrics_registry,
@@ -212,21 +213,21 @@ EventReportMetricsCollector::EventReportMetricsCollector(std::shared_ptr<Metrics
212213

213214
EventReportMetricsCollector::EventReportMetricsCollector(const EventReportMetricsCollector &shared_collector) noexcept
214215
: MetricsCollector(shared_collector.metrics_registry_, shared_collector.metrics_tags_) {
215-
event_report_request_counter_metrics_ = shared_collector.event_report_request_counter_metrics_;
216-
event_report_request_rt_us_metrics_ = shared_collector.event_report_request_rt_us_metrics_;
217-
event_report_error_code_metrics_ = shared_collector.event_report_error_code_metrics_;
218-
event_report_error_counter_metrics_ = shared_collector.event_report_error_counter_metrics_;
216+
service_query_counter_metrics_ = shared_collector.service_query_counter_metrics_;
217+
service_query_rt_us_metrics_ = shared_collector.service_query_rt_us_metrics_;
218+
service_error_code_metrics_ = shared_collector.service_error_code_metrics_;
219+
service_error_counter_metrics_ = shared_collector.service_error_counter_metrics_;
219220
manager_request_key_count_metrics_ = shared_collector.manager_request_key_count_metrics_;
220221
}
221222

222223
bool EventReportMetricsCollector::Init() {
223224
if (metrics_registry_ == nullptr) {
224225
return false;
225226
}
226-
REGISTER_COUNTER_METRICS_FOR_EVENT_REPORT(request_counter);
227-
REGISTER_GAUGE_METRICS_FOR_EVENT_REPORT(request_rt_us);
228-
REGISTER_GAUGE_METRICS_FOR_EVENT_REPORT(error_code);
229-
REGISTER_COUNTER_METRICS_FOR_EVENT_REPORT(error_counter);
227+
REGISTER_COUNTER_METRICS_FOR_EVENT_REPORT_SERVICE(query_counter);
228+
REGISTER_GAUGE_METRICS_FOR_EVENT_REPORT_SERVICE(query_rt_us);
229+
REGISTER_GAUGE_METRICS_FOR_EVENT_REPORT_SERVICE(error_code);
230+
REGISTER_COUNTER_METRICS_FOR_EVENT_REPORT_SERVICE(error_counter);
230231
REGISTER_GAUGE_METRICS_FOR_EVENT_REPORT_MANAGER(request_key_count);
231232
return true;
232233
}

‎kv_cache_manager/metrics/metrics_collector.h‎

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -321,14 +321,15 @@ class ServiceMetricsCollector final : public MetricsCollector {
321321
bool Init() override;
322322
};
323323

324-
// Lightweight per-event observability for ReportEvent. This intentionally
325-
// carries only the request key count from the manager metric family, rather
326-
// than registering every manager/meta metric from ServiceMetricsCollector.
324+
// Lightweight per-event observability for ReportEvent. It reuses service.*
325+
// metrics for request outcome and carries only request_key_count from the
326+
// manager metric family, rather than registering every manager/meta metric
327+
// from ServiceMetricsCollector.
327328
class EventReportMetricsCollector final : public MetricsCollector {
328-
KVCM_COUNTER_METRICS(event_report, request_counter)
329-
KVCM_GAUGE_METRICS(event_report, request_rt_us)
330-
KVCM_GAUGE_METRICS(event_report, error_code)
331-
KVCM_COUNTER_METRICS(event_report, error_counter)
329+
KVCM_COUNTER_METRICS(service, query_counter)
330+
KVCM_GAUGE_METRICS(service, query_rt_us)
331+
KVCM_GAUGE_METRICS(service, error_code)
332+
KVCM_COUNTER_METRICS(service, error_counter)
332333
KVCM_GAUGE_METRICS(manager, request_key_count)
333334

334335
public:
@@ -349,10 +350,10 @@ class EventReportMetricsCollector final : public MetricsCollector {
349350
has_request_sample_ = true;
350351
}
351352
[[nodiscard]] double GetRequestRtUsSample() const noexcept {
352-
return has_request_sample_ ? request_rt_us_sample_ : get_event_report_request_rt_us_metrics();
353+
return has_request_sample_ ? request_rt_us_sample_ : get_service_query_rt_us_metrics();
353354
}
354355
[[nodiscard]] double GetErrorCodeSample() const noexcept {
355-
return has_request_sample_ ? error_code_sample_ : get_event_report_error_code_metrics();
356+
return has_request_sample_ ? error_code_sample_ : get_service_error_code_metrics();
356357
}
357358
void SetRequestKeyCountSample(double request_key_count) noexcept {
358359
request_key_count_sample_ = request_key_count;

‎kv_cache_manager/metrics/test/kmonitor_metrics_reporter_test.cc‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@ TEST_F(KmonitorMetricsReporterTest, TestReportPerQuery) {
5252
{
5353
EventReportMetricsCollector collector(metrics_registry_, {{"event_type", "block_snapshot"}});
5454
ASSERT_TRUE(collector.Init());
55-
SET_METRICS_(&collector, event_report, request_rt_us, 123.);
56-
SET_METRICS_(&collector, event_report, error_code, 1.);
55+
SET_METRICS_(&collector, service, query_rt_us, 123.);
56+
SET_METRICS_(&collector, service, error_code, 1.);
5757
EXPECT_NO_FATAL_FAILURE(reporter_->ReportPerQuery(&collector));
58-
EXPECT_EQ(1, collector.get_event_report_request_counter_metrics());
59-
EXPECT_EQ(1, collector.get_event_report_error_counter_metrics());
58+
EXPECT_EQ(1, collector.get_service_query_counter_metrics());
59+
EXPECT_EQ(1, collector.get_service_error_counter_metrics());
6060
}
6161

6262
{

‎kv_cache_manager/metrics/test/local_metrics_reporter_test.cc‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -212,16 +212,16 @@ TEST_F(LocalMetricsReporterTest, TestReportPerQueryEventReport) {
212212

213213
reporter_->ReportPerQuery(&collector);
214214
std::uint64_t value = 0;
215-
GET_METRICS_(&collector, event_report, request_counter, value);
215+
GET_METRICS_(&collector, service, query_counter, value);
216216
EXPECT_EQ(1, value);
217-
GET_METRICS_(&collector, event_report, error_counter, value);
217+
GET_METRICS_(&collector, service, error_counter, value);
218218
EXPECT_EQ(0, value);
219219

220-
SET_METRICS_(&collector, event_report, error_code, 10.);
220+
SET_METRICS_(&collector, service, error_code, 10.);
221221
reporter_->ReportPerQuery(&collector);
222-
GET_METRICS_(&collector, event_report, request_counter, value);
222+
GET_METRICS_(&collector, service, query_counter, value);
223223
EXPECT_EQ(2, value);
224-
GET_METRICS_(&collector, event_report, error_counter, value);
224+
GET_METRICS_(&collector, service, error_counter, value);
225225
EXPECT_EQ(1, value);
226226
}
227227

@@ -236,14 +236,14 @@ TEST_F(LocalMetricsReporterTest, ConcurrentEventCollectorsDoNotShareErrorSamples
236236
failure.SetRequestSample(20.0, 1.0);
237237
// Both objects point at the same tagged registry gauge. Deliberately leave
238238
// that shared gauge in the failed state before reporting the success.
239-
SET_METRICS_(&success, event_report, error_code, 0.0);
240-
SET_METRICS_(&failure, event_report, error_code, 1.0);
239+
SET_METRICS_(&success, service, error_code, 0.0);
240+
SET_METRICS_(&failure, service, error_code, 1.0);
241241

242242
reporter_->ReportPerQuery(&success);
243243
reporter_->ReportPerQuery(&failure);
244244

245-
EXPECT_EQ(2u, success.get_event_report_request_counter_metrics());
246-
EXPECT_EQ(1u, success.get_event_report_error_counter_metrics());
245+
EXPECT_EQ(2u, success.get_service_query_counter_metrics());
246+
EXPECT_EQ(1u, success.get_service_error_counter_metrics());
247247
}
248248

249249
TEST_F(LocalMetricsReporterTest, ServiceCallGuardCopiesRequestOutcomeToEventReportMetrics) {
@@ -262,10 +262,10 @@ TEST_F(LocalMetricsReporterTest, ServiceCallGuardCopiesRequestOutcomeToEventRepo
262262
std::this_thread::sleep_for(std::chrono::milliseconds(1));
263263
}
264264

265-
EXPECT_GT(snapshot_collector->get_event_report_request_rt_us_metrics(), 0.);
266-
EXPECT_DOUBLE_EQ(1., snapshot_collector->get_event_report_error_code_metrics());
267-
EXPECT_EQ(1, snapshot_collector->get_event_report_request_counter_metrics());
268-
EXPECT_EQ(1, snapshot_collector->get_event_report_error_counter_metrics());
265+
EXPECT_GT(snapshot_collector->get_service_query_rt_us_metrics(), 0.);
266+
EXPECT_DOUBLE_EQ(1., snapshot_collector->get_service_error_code_metrics());
267+
EXPECT_EQ(1, snapshot_collector->get_service_query_counter_metrics());
268+
EXPECT_EQ(1, snapshot_collector->get_service_error_counter_metrics());
269269
}
270270

271271
TEST_F(LocalMetricsReporterTest, EventReportMetricsUseRequestLocalStatusInsteadOfSharedServiceGauge) {
@@ -283,9 +283,9 @@ TEST_F(LocalMetricsReporterTest, EventReportMetricsUseRequestLocalStatusInsteadO
283283
request_context.GetMetricsCollectorsVehicle().AddMetricsCollector(heartbeat_collector);
284284
{ ServiceCallGuard guard(cache_manager_.get(), &request_context, reporter_.get()); }
285285

286-
EXPECT_DOUBLE_EQ(0., heartbeat_collector->get_event_report_error_code_metrics());
287-
EXPECT_EQ(1, heartbeat_collector->get_event_report_request_counter_metrics());
288-
EXPECT_EQ(0, heartbeat_collector->get_event_report_error_counter_metrics());
286+
EXPECT_DOUBLE_EQ(0., heartbeat_collector->get_service_error_code_metrics());
287+
EXPECT_EQ(1, heartbeat_collector->get_service_query_counter_metrics());
288+
EXPECT_EQ(0, heartbeat_collector->get_service_error_counter_metrics());
289289
}
290290

291291
TEST_F(LocalMetricsReporterTest, TestReportInterval00) {

‎kv_cache_manager/metrics/test/metrics_collector_test.cc‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,16 +29,16 @@ TEST_F(MetricsCollectorTest, EventReportMetricsTest) {
2929
EXPECT_EQ(tags, collector->GetMetricsTags());
3030
EXPECT_EQ(5, metrics_registry_->GetSize());
3131

32-
EXPECT_EQ(0, GET(collector, event_report, request_counter));
33-
EXPECT_DOUBLE_EQ(0., GET(collector, event_report, request_rt_us));
34-
EXPECT_DOUBLE_EQ(0., GET(collector, event_report, error_code));
35-
EXPECT_EQ(0, GET(collector, event_report, error_counter));
32+
EXPECT_EQ(0, GET(collector, service, query_counter));
33+
EXPECT_DOUBLE_EQ(0., GET(collector, service, query_rt_us));
34+
EXPECT_DOUBLE_EQ(0., GET(collector, service, error_code));
35+
EXPECT_EQ(0, GET(collector, service, error_counter));
3636
EXPECT_DOUBLE_EQ(0., GET(collector, manager, request_key_count));
3737

38-
SET_METRICS_(collector, event_report, request_rt_us, 123.);
39-
SET_METRICS_(collector, event_report, error_code, 10.);
40-
EXPECT_DOUBLE_EQ(123., GET(collector, event_report, request_rt_us));
41-
EXPECT_DOUBLE_EQ(10., GET(collector, event_report, error_code));
38+
SET_METRICS_(collector, service, query_rt_us, 123.);
39+
SET_METRICS_(collector, service, error_code, 10.);
40+
EXPECT_DOUBLE_EQ(123., GET(collector, service, query_rt_us));
41+
EXPECT_DOUBLE_EQ(10., GET(collector, service, error_code));
4242
}
4343

4444
// Test MetaIndexer metrics functionality

‎kv_cache_manager/metrics/test/prometheus_exporter_test.cc‎

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -59,24 +59,26 @@ TEST_F(PrometheusExporterTest, MetricsWithTags) {
5959
<< output;
6060
}
6161

62-
TEST_F(PrometheusExporterTest, EventReportSnapshotMetricsExposeIndependentTagsAndValues) {
63-
MetricsTags tags = {{"event_type", "block_snapshot"},
62+
TEST_F(PrometheusExporterTest, EventReportSnapshotMetricsReuseServiceTagsAndValues) {
63+
MetricsTags tags = {{"api_name", "ReportEvent"},
64+
{"event_type", "block_snapshot"},
6465
{"instance_group", "group_a"},
6566
{"instance_id", "instance_a"},
6667
{"type", "event_report_l2"}};
6768
EventReportMetricsCollector collector(registry_, tags);
6869
ASSERT_TRUE(collector.Init());
6970
Counter request_counter;
70-
COPY_METRICS_(&collector, event_report, request_counter, request_counter);
71+
COPY_METRICS_(&collector, service, query_counter, request_counter);
7172
++request_counter;
72-
SET_METRICS_(&collector, event_report, request_rt_us, 321.);
73+
SET_METRICS_(&collector, service, query_rt_us, 321.);
7374

7475
const std::string output = PrometheusExporter::Expose(*registry_);
75-
const std::string labels = "{event_type=\"block_snapshot\",instance_group=\"group_a\",instance_id=\"instance_a\","
76-
"type=\"event_report_l2\"}";
77-
EXPECT_NE(output.find("kvcm_event_report_request_counter" + labels + " 1"), std::string::npos) << output;
78-
EXPECT_NE(output.find("kvcm_event_report_request_rt_us" + labels + " 321"), std::string::npos) << output;
79-
EXPECT_EQ(output.find("kvcm_event_report_error_counter"), std::string::npos) << output;
76+
const std::string labels =
77+
"{api_name=\"ReportEvent\",event_type=\"block_snapshot\",instance_group=\"group_a\","
78+
"instance_id=\"instance_a\",type=\"event_report_l2\"}";
79+
EXPECT_NE(output.find("kvcm_service_query_counter" + labels + " 1"), std::string::npos) << output;
80+
EXPECT_NE(output.find("kvcm_service_query_rt_us" + labels + " 321"), std::string::npos) << output;
81+
EXPECT_EQ(output.find("kvcm_event_report_request_counter"), std::string::npos) << output;
8082
}
8183

8284
TEST_F(PrometheusExporterTest, MultipleTagSets) {

‎kv_cache_manager/service/meta_service_metrics_base.cc‎

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,11 @@ std::shared_ptr<MetricsCollector> MetaServiceMetricsBase::GetEventTypeMetricsCol
162162
if (instance_group.empty()) {
163163
return nullptr;
164164
}
165-
MetricsTags tags = {
166-
{"instance_group", instance_group}, {"instance_id", instance_id}, {"type", type}, {"event_type", event_type}};
165+
MetricsTags tags = {{"api_name", "ReportEvent"},
166+
{"instance_group", instance_group},
167+
{"instance_id", instance_id},
168+
{"type", type},
169+
{"event_type", event_type}};
167170
auto collector = std::make_shared<EventReportMetricsCollector>(metrics_registry_, std::move(tags));
168171
if (!collector->Init()) {
169172
return nullptr;
@@ -207,6 +210,8 @@ void MetaServiceMetricsBase::AttachReportEventTypeMetricsCollectors(const proto:
207210

208211
static constexpr std::array<const char *, 7> kEventTypeTags = {
209212
"unknown", "node_register", "block_add", "block_delete", "host_down", "heartbeat", "block_snapshot"};
213+
static constexpr std::array<bool, kEventTypeTags.size()> kEnableEventTypeMetrics = {
214+
false, false, true, true, false, false, true};
210215
uint32_t event_type_mask = 0;
211216
std::array<size_t, kEventTypeTags.size()> request_key_counts{};
212217
for (const auto &event : request.events()) {
@@ -239,6 +244,9 @@ void MetaServiceMetricsBase::AttachReportEventTypeMetricsCollectors(const proto:
239244
if ((event_type_mask & (1U << event_type)) == 0) {
240245
continue;
241246
}
247+
if (!kEnableEventTypeMetrics[event_type]) {
248+
continue;
249+
}
242250
auto shared_collector =
243251
GetTypedMetricsCollectorForReportEventType(request.instance_id(), type, kEventTypeTags[event_type]);
244252
auto event_collector = std::dynamic_pointer_cast<EventReportMetricsCollector>(shared_collector);
@@ -247,10 +255,7 @@ void MetaServiceMetricsBase::AttachReportEventTypeMetricsCollectors(const proto:
247255
// lightweight view with the same handles but private sample state,
248256
// avoiding both registry re-registration and cross-request races.
249257
auto request_collector = std::make_shared<EventReportMetricsCollector>(*event_collector);
250-
if (event_type == proto::meta::EVENT_BLOCK_ADD || event_type == proto::meta::EVENT_BLOCK_DELETE ||
251-
event_type == proto::meta::EVENT_BLOCK_SNAPSHOT) {
252-
request_collector->SetRequestKeyCountSample(request_key_counts[event_type]);
253-
}
258+
request_collector->SetRequestKeyCountSample(request_key_counts[event_type]);
254259
request_context->GetMetricsCollectorsVehicle().AddMetricsCollector(std::move(request_collector));
255260
}
256261
}

0 commit comments

Comments
 (0)