Skip to content

Commit 46ce54f

Browse files
committed
[service] improve per-instance metrics failure diagnostics
Include trace ID and instance ID when a per-instance service metrics collector cannot be resolved. Document the two possible failure scopes in the log so unknown-instance requests can be distinguished from the API business path without exposing request payloads.
1 parent dbe01da commit 46ce54f

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

kv_cache_manager/service/util/common.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,11 @@ std::string ExtractIpFromPeer(const std::string &peer);
3434
#define API_CONTEXT_GET_AND_INIT_COLLECTOR(method, return_value) \
3535
auto metrics_collector = get_metrics_collector_from_map_for_##method(request->instance_id()); \
3636
if (metrics_collector == nullptr) { \
37-
KVCM_LOG_ERROR("get " #method " metrics collector failed"); \
37+
KVCM_LOG_ERROR("[traceId: %s] get " #method \
38+
" metrics collector failed, instance_id: %s; instance is not registered or metrics collector " \
39+
"initialization failed", \
40+
request->trace_id().c_str(), \
41+
request->instance_id().c_str()); \
3842
auto *header = response->mutable_header(); \
3943
auto *status = header->mutable_status(); \
4044
status->set_code(proto::meta::INSTANCE_NOT_EXIST); \

0 commit comments

Comments
 (0)