Skip to content

Commit a1122e2

Browse files
authored
[data_storage] add vipserver_domain for tairmempool in storage config (#13)
1 parent f6aa2b2 commit a1122e2

File tree

5 files changed

+12
-2
lines changed

5 files changed

+12
-2
lines changed

kv_cache_manager/data_storage/storage_config.cc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,8 @@ bool MooncakeStorageSpec::ValidateRequiredFields(std::string &invalid_fields) co
107107
}
108108
std::string TairMemPoolStorageSpec::ToString() const {
109109
std::ostringstream oss;
110-
oss << "enable_vipserver: " << enable_vipserver_ << ", domain: " << domain_ << ", timeout: " << timeout_;
110+
oss << "enable_vipserver: " << enable_vipserver_ << ", domain: " << domain_
111+
<< ", vipserver_domain: " << vipserver_domain_ << ", timeout: " << timeout_;
111112
return oss.str();
112113
}
113114
bool TairMemPoolStorageSpec::ValidateRequiredFields(std::string &invalid_fields) const {
@@ -242,13 +243,15 @@ void MooncakeStorageSpec::ToRapidWriter(rapidjson::Writer<rapidjson::StringBuffe
242243
// TairMemPoolStorageSpec
243244
bool TairMemPoolStorageSpec::FromRapidValue(const rapidjson::Value &rapid_value) {
244245
KVCM_JSON_GET_MACRO(rapid_value, "enable_vipserver", enable_vipserver_);
246+
KVCM_JSON_GET_MACRO(rapid_value, "vipserver_domain", vipserver_domain_);
245247
KVCM_JSON_GET_MACRO(rapid_value, "domain", domain_);
246248
KVCM_JSON_GET_MACRO(rapid_value, "timeout", timeout_);
247249
return true;
248250
}
249251

250252
void TairMemPoolStorageSpec::ToRapidWriter(rapidjson::Writer<rapidjson::StringBuffer> &writer) const noexcept {
251253
Put(writer, "enable_vipserver", enable_vipserver_);
254+
Put(writer, "vipserver_domain", vipserver_domain_);
252255
Put(writer, "domain", domain_);
253256
Put(writer, "timeout", timeout_);
254257
}

kv_cache_manager/data_storage/storage_config.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,15 +127,18 @@ class TairMemPoolStorageSpec : public StorageSpec {
127127
std::string ToString() const override;
128128
const std::string &cluster_name() const { return cluster_name_; }
129129
const std::string &domain() const { return domain_; }
130+
const std::string &vipserver_domain() const { return vipserver_domain_; }
130131
int64_t timeout() const { return timeout_; }
131132
const bool enable_vipserver() const { return enable_vipserver_; }
132133
void set_domain(const std::string &domain) { domain_ = domain; }
134+
void set_vipserver_domain(const std::string &vipserver_domain) { vipserver_domain_ = vipserver_domain; }
133135
void set_cluster_name(const std::string &cluster_name) { cluster_name_ = cluster_name; }
134136
void set_timeout(int64_t timeout) { timeout_ = timeout; }
135137
void set_enable_vipserver(bool enable_vipserver) { enable_vipserver_ = enable_vipserver; }
136138

137139
private:
138-
std::string domain_; // metaservice域名
140+
std::string domain_; // 统一接入
141+
std::string vipserver_domain_; // vipserver
139142
int64_t timeout_{0}; // 目前连接超时、请求超时时间的值一样
140143
bool enable_vipserver_ = false; // 是否使用vipserver
141144
std::string cluster_name_; // TODO proto中没有这个字段并且未使用,考虑删除

kv_cache_manager/protocol/protobuf/admin_service.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ message TairMemPoolStorageSpec {
8080
string domain = 1; // tair mempool的 meta service挂载的域名
8181
int32 timeout = 2; // 单位超时时间
8282
bool enable_vipserver = 3;
83+
string vipserver_domain = 4;
8384
}
8485

8586
message NfsStorageSpec {

kv_cache_manager/protocol/protobuf/meta_service.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ message TairMemPoolStorageSpec {
129129
string domain = 1; // tair mempool的 meta service挂载的域名
130130
int32 timeout = 2; // 单位超时时间
131131
bool enable_vipserver = 3;
132+
string vipserver_domain = 4;
132133
}
133134

134135
message NfsStorageSpec {

kv_cache_manager/service/util/manager_message_proto_util.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ void ProtoConvert::StorageConfigToProto(const StorageConfig &storage_config,
4747
// proto_storage_config->set_global_unique_name(tair_mem_pool_storage.get_global_unique_name());
4848
auto *tair_mem_pool = proto_storage_config->mutable_tair_mem_pool();
4949
tair_mem_pool->set_domain(tair_mem_pool_storage.domain());
50+
tair_mem_pool->set_vipserver_domain(tair_mem_pool_storage.vipserver_domain());
5051
tair_mem_pool->set_timeout(tair_mem_pool_storage.timeout());
5152
tair_mem_pool->set_enable_vipserver(tair_mem_pool_storage.enable_vipserver());
5253
} else if (type == DataStorageType::DATA_STORAGE_TYPE_NFS) {
@@ -103,6 +104,7 @@ void ProtoConvert::StorageFromProto(const proto::admin::StorageConfig *proto_sto
103104
case proto::admin::StorageConfig::kTairMemPool: {
104105
TairMemPoolStorageSpec spec;
105106
spec.set_domain(proto_storage_config->tair_mem_pool().domain());
107+
spec.set_vipserver_domain(proto_storage_config->tair_mem_pool().vipserver_domain());
106108
spec.set_timeout(proto_storage_config->tair_mem_pool().timeout());
107109
spec.set_enable_vipserver(proto_storage_config->tair_mem_pool().enable_vipserver());
108110
storage_config.set_storage_spec(std::make_shared<TairMemPoolStorageSpec>(spec));

0 commit comments

Comments
 (0)