fix: resolve compiler warnings and enable -Werror across all CI platforms (#460)

Author: luoxiaojian

.github/workflows/03-macos-linux-build.yml

@@ -116,6 +116,7 @@ jobs:
           python -m pip install -v . \
             --no-build-isolation \
             --config-settings='cmake.define.BUILD_TOOLS=ON' \
+            --config-settings='cmake.define.ENABLE_WERROR=ON' \
             --config-settings='cmake.define.CMAKE_C_COMPILER_LAUNCHER=ccache' \
             --config-settings='cmake.define.CMAKE_CXX_COMPILER_LAUNCHER=ccache' \
             ${{ matrix.arch_flag }}

.github/workflows/04-android-build.yml

@@ -121,6 +121,7 @@ jobs:
             -DBUILD_TOOLS=OFF \
             -DENABLE_NATIVE=OFF \
             -DAUTO_DETECT_ARCH=OFF \
+            -DENABLE_WERROR=ON \
             -DCMAKE_INSTALL_PREFIX="$BUILD_DIR/install" \
             -DGLOBAL_CC_PROTOBUF_PROTOC="$GITHUB_WORKSPACE/build_host/bin/protoc" \
             -DCMAKE_C_COMPILER_LAUNCHER=ccache \

.github/workflows/05-windows-build.yml

@@ -83,6 +83,7 @@ jobs:
           python -m pip install -v . `
             --no-build-isolation `
             --config-settings='cmake.define.BUILD_TOOLS=ON' `
+            --config-settings='cmake.define.ENABLE_WERROR=ON' `
             --config-settings='cmake.define.CMAKE_C_COMPILER_LAUNCHER=sccache' `
             --config-settings='cmake.define.CMAKE_CXX_COMPILER_LAUNCHER=sccache'
         shell: powershell

.github/workflows/06-ios-build.yml

@@ -71,6 +71,7 @@ jobs:
             -DCMAKE_BUILD_TYPE=Release \
             -DBUILD_PYTHON_BINDINGS=OFF \
             -DBUILD_TOOLS=OFF \
+            -DENABLE_WERROR=ON \
             -DCMAKE_INSTALL_PREFIX="./install" \
             -DGLOBAL_CC_PROTOBUF_PROTOC="$GITHUB_WORKSPACE/build_host/bin/protoc" \
             -DIOS=ON \

.github/workflows/07-linux-riscv-build.yml

@@ -221,6 +221,7 @@ jobs:
           $PYTHON -m pip install -v . \
             --no-build-isolation \
             --config-settings='cmake.define.BUILD_TOOLS="ON"' \
+            --config-settings='cmake.define.ENABLE_WERROR=ON' \
             --config-settings='cmake.define.CMAKE_C_COMPILER_LAUNCHER=ccache' \
             --config-settings='cmake.define.CMAKE_CXX_COMPILER_LAUNCHER=ccache'
         shell: bash

cmake/bazel.cmake

@@ -396,16 +396,23 @@ endif()
 if(NOT MSVC)
   # Use color in diagnostics
   set(
-      _COMPILER_FLAGS
+      _C_FLAGS
+      "$<$<C_COMPILER_ID:Clang>:-fcolor-diagnostics>"
+      "$<$<C_COMPILER_ID:AppleClang>:-fcolor-diagnostics>"
+      "$<$<C_COMPILER_ID:GNU>:-fdiagnostics-color=always>"
+    )
+  set(
+      _CXX_FLAGS
       "$<$<C_COMPILER_ID:Clang>:-fcolor-diagnostics;${CLANG_STDLIB_OPTION}>"
       "$<$<C_COMPILER_ID:AppleClang>:-fcolor-diagnostics>"
       "$<$<C_COMPILER_ID:GNU>:-fdiagnostics-color=always>"
     )
   add_compile_options(
-      "$<$<COMPILE_LANGUAGE:C>:${_COMPILER_FLAGS}>"
-      "$<$<COMPILE_LANGUAGE:CXX>:${_COMPILER_FLAGS}>"
+      "$<$<COMPILE_LANGUAGE:C>:${_C_FLAGS}>"
+      "$<$<COMPILE_LANGUAGE:CXX>:${_CXX_FLAGS}>"
     )
-  unset(_COMPILER_FLAGS)
+  unset(_C_FLAGS)
+  unset(_CXX_FLAGS)
 else()
   option(ZVEC_USE_STATIC_CRT "Use static CRT (/MT) instead of dynamic CRT (/MD), default=ON" ON)
 
@@ -477,13 +484,25 @@ set(
   )
 
 # C/C++ strict compile flags
+if(ENABLE_WERROR)
+  set(BAZEL_CC_WERROR_FLAGS
+      "$<$<CXX_COMPILER_ID:Clang>:-Werror>"
+      "$<$<CXX_COMPILER_ID:AppleClang>:-Werror>"
+      "$<$<CXX_COMPILER_ID:GNU>:-Werror>"
+      "$<$<CXX_COMPILER_ID:MSVC>:/WX>"
+    )
+else()
+  set(BAZEL_CC_WERROR_FLAGS "")
+endif()
+
 if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 7.0)
   set(
       BAZEL_CC_STRICT_COMPILE_FLAGS
       "$<$<CXX_COMPILER_ID:Clang>:-Wall;-Wextra;-Wshadow>"
       "$<$<CXX_COMPILER_ID:AppleClang>:-Wall;-Wextra;-Wshadow>"
       "$<$<CXX_COMPILER_ID:GNU>:-Wall;-Wextra;-Wshadow-local;-Wno-misleading-indentation>"
       "$<$<CXX_COMPILER_ID:MSVC>:/W4>"
+      ${BAZEL_CC_WERROR_FLAGS}
       ${BAZEL_CC_ASAN_COMPILE_FLAGS}
       ${BAZEL_CC_COVERAGE_COMPILE_FLAGS}
     )
@@ -494,6 +513,7 @@ else()
       "$<$<CXX_COMPILER_ID:AppleClang>:-Wall;-Wextra;-Wshadow>"
       "$<$<CXX_COMPILER_ID:GNU>:-Wall;-Wextra;-Wshadow;-Wno-misleading-indentation>"
       "$<$<CXX_COMPILER_ID:MSVC>:/W4>"
+      ${BAZEL_CC_WERROR_FLAGS}
       ${BAZEL_CC_ASAN_COMPILE_FLAGS}
       ${BAZEL_CC_COVERAGE_COMPILE_FLAGS}
     )
@@ -503,7 +523,6 @@ endif()
 # C/C++ strict link flags
 set(
     BAZEL_CC_STRICT_LINK_FLAGS
-    "$<$<CXX_COMPILER_ID:Clang>:${CLANG_STDLIB_OPTION}>"
     ${BAZEL_CC_ASAN_COMPILE_FLAGS}
     ${BAZEL_CC_COVERAGE_COMPILE_FLAGS}
   )
@@ -522,7 +541,6 @@ set(
 # C/C++ unstrict link flags
 set(
     BAZEL_CC_UNSTRICT_LINK_FLAGS
-    "$<$<CXX_COMPILER_ID:Clang>:${CLANG_STDLIB_OPTION}>"
     ${BAZEL_CC_ASAN_COMPILE_FLAGS}
     ${BAZEL_CC_COVERAGE_COMPILE_FLAGS}
   )

cmake/option.cmake

@@ -33,6 +33,9 @@ option(ENABLE_ARMV8.6A "Enable ARMv8.6-a architecture" OFF)
 ## OpenMP option
 option(ENABLE_OPENMP "Enable OpenMP support" OFF)
 
+## Treat warnings as errors (for CI)
+option(ENABLE_WERROR "Treat compiler warnings as errors in strict targets" OFF)
+
 set(ARCH_OPTIONS
   ENABLE_NEHALEM ENABLE_SANDYBRIDGE ENABLE_HASWELL ENABLE_BROADWELL ENABLE_SKYLAKE
   ENABLE_SKYLAKE_AVX512 ENABLE_ICELAKE ENABLE_SAPPHIRERAPIDS ENABLE_EMERALDRAPIDS ENABLE_GRANITERAPIDS

src/ailego/utility/float_helper.cc

@@ -24,14 +24,16 @@
 
 #if defined(__aarch64__)
 static inline float float32(uint16_t val) {
-  __fp16 *p = reinterpret_cast<__fp16 *>(&val);
-  return *p;
+  __fp16 f;
+  memcpy(&f, &val, sizeof(val));
+  return static_cast<float>(f);
 }
 
 static inline uint16_t float16(float val) {
   __fp16 f = static_cast<__fp16>(val);
-  uint16_t *fp = reinterpret_cast<uint16_t *>(&f);
-  return *fp;
+  uint16_t result;
+  memcpy(&result, &f, sizeof(result));
+  return result;
 }
 
 static inline void convert_fp16_to_fp32(const uint16_t *arr, size_t size,

src/binding/python/model/python_doc.cc

@@ -285,7 +285,7 @@ void ZVecPyDoc::bind_doc(py::module_ &m) {
               d[py::int_(indices[i])] =
                   py::float_(static_cast<float>(values[i]));
             }
-            return std::move(d);
+            return d;
           }
           case DataType::SPARSE_VECTOR_FP32: {
             auto vector =
@@ -297,7 +297,7 @@ void ZVecPyDoc::bind_doc(py::module_ &m) {
             for (size_t i = 0; i < indices.size(); ++i) {
               d[py::int_(indices[i])] = py::float_(values[i]);
             }
-            return std::move(d);
+            return d;
           }
           default:
             throw py::type_error("Unsupported type for field: " + field);
@@ -414,7 +414,7 @@ void ZVecPyDoc::bind_doc(py::module_ &m) {
                     d[py::int_(indices[i])] =
                         py::float_(static_cast<float>(values[i]));
                   }
-                  return std::move(d);
+                  return d;
                 }
                 case DataType::SPARSE_VECTOR_FP32: {
                   auto vector = self.get<
@@ -426,7 +426,7 @@ void ZVecPyDoc::bind_doc(py::module_ &m) {
                   for (size_t i = 0; i < indices.size(); ++i) {
                     d[py::int_(indices[i])] = py::float_(values[i]);
                   }
-                  return std::move(d);
+                  return d;
                 }
                 default:
                   throw py::type_error("Unsupported type for field: " + vec);

src/core/algorithm/diskann/diskann_file_reader.h

@@ -62,7 +62,7 @@ class AlignedFileReader {
  public:
   virtual IOContext &get_ctx() = 0;
 
-  virtual ~AlignedFileReader() {};
+  virtual ~AlignedFileReader() {}
 
   virtual void register_thread() = 0;
   virtual void deregister_thread() = 0;
@@ -77,7 +77,6 @@ class AlignedFileReader {
 
 class LinuxAlignedFileReader : public AlignedFileReader {
  private:
-  uint64_t file_sz;
   int file_desc;
 
   IOContext bad_ctx = (IOContext)-1;