Skip to content

Commit a0f4630

Browse files
authored
Merge pull request #174 from alicevision/fix/windowsBoost1.76
Remove legacy defines for boost/cuda
2 parents 9fb60f4 + 98de68f commit a0f4630

File tree

3 files changed

+15
-42
lines changed

3 files changed

+15
-42
lines changed

CHANGES.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1515

1616
### Removed
1717

18+
## [1.0.1] - 2021-10-08
19+
20+
### Changed
21+
22+
- Renamed the marker files to be 0-based [PR](https://github.com/alicevision/CCTag/pull/165)
23+
24+
### Fixed
25+
26+
- Fixed missing math module for boost [PR](https://github.com/alicevision/CCTag/pull/168)
27+
- Fixed compilation errors for newer version of boost on windows [PR](https://github.com/alicevision/CCTag/pull/166)
28+
- Removed old legacy defines for cuda and boost no more needed since the switch to c++14 [PR](https://github.com/alicevision/CCTag/pull/174)
29+
30+
1831
## [1.0.0] - 2021-06-24
1932

2033
- Support for OpenCV 3.4.9 [PR](https://github.com/alicevision/CCTag/pull/121)

CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ cmake_minimum_required(VERSION 3.13)
55

66
include(ExternalProject)
77

8-
project(CCTag VERSION 1.0.0 LANGUAGES C CXX)
8+
project(CCTag VERSION 1.0.1 LANGUAGES C CXX)
99

1010
# Set build path as a folder named as the platform (linux, windows, darwin...) plus the processor type
1111
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/${CMAKE_SYSTEM_NAME}-${CMAKE_SYSTEM_PROCESSOR}")
@@ -147,7 +147,7 @@ if(CCTAG_WITH_CUDA)
147147
set(CUDA_USE_STATIC_CUDA_RUNTIME ON)
148148
endif()
149149

150-
find_package(CUDA 7.0 REQUIRED)
150+
find_package(CUDA 9.0 REQUIRED)
151151

152152
include(CheckNvccCompilerFlag)
153153

src/cctag/cuda/cctag_cuda_runtime.h

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -8,44 +8,4 @@
88

99
#pragma once
1010

11-
#ifdef __CUDACC__
12-
//
13-
// When compiling .cu files, there's a bunch of stuff that doesn't work with msvc:
14-
//
15-
#if defined(_MSC_VER)
16-
# define BOOST_NO_CXX14_DIGIT_SEPARATORS
17-
# define BOOST_NO_CXX11_UNICODE_LITERALS
18-
# define BOOST_PP_VARIADICS 0
19-
#endif
20-
# define BOOST_NO_CXX11_DEFAULTED_FUNCTIONS
21-
#endif
22-
2311
#include <cuda_runtime.h>
24-
25-
26-
// https://svn.boost.org/trac/boost/ticket/11897
27-
// This is fixed in 7.5. As the following version macro was introduced in 7.5 an existance
28-
// check is enough to detect versions < 7.5
29-
#if BOOST_CUDA_VERSION < 7050000
30-
# define BOOST_NO_CXX11_VARIADIC_TEMPLATES
31-
#endif
32-
// The same bug is back again in 8.0:
33-
#if (BOOST_CUDA_VERSION > 8000000) && (BOOST_CUDA_VERSION < 8010000)
34-
# define BOOST_NO_CXX11_VARIADIC_TEMPLATES
35-
#endif
36-
// Most recent CUDA (8.0) has no constexpr support in msvc mode:
37-
#if defined(_MSC_VER)
38-
# define BOOST_NO_CXX11_CONSTEXPR
39-
#endif
40-
41-
#ifdef __CUDACC__
42-
// And this one effects the NVCC front end,
43-
// See https://svn.boost.org/trac/boost/ticket/13049
44-
//
45-
#if (BOOST_CUDA_VERSION >= 8000000) && (BOOST_CUDA_VERSION < 8010000)
46-
# define BOOST_NO_CXX11_NOEXCEPT
47-
#endif
48-
49-
#endif
50-
51-

0 commit comments

Comments
 (0)