Skip to content

Commit 1aea45e

Browse files
committed
[core] Node: Propagate attribute change via valueChanged signal
Propagate attribute value changes downstream using `valueChanged` signal emission, instead of calling `_onAttributeChanged` directly. This does not change the current core behavior, but it triggers the property notification signal when in UI mode. This makes changes happening upstream properly reflected in downstream nodes.
1 parent 1f42ad3 commit 1aea45e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

meshroom/core/node.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -980,7 +980,7 @@ def _onAttributeChanged(self, attr: Attribute):
980980
if self.graph:
981981
# If we are in a graph, propagate the notification to the connected output attributes
982982
for edge in self.graph.outEdges(attr):
983-
edge.dst.node._onAttributeChanged(edge.dst)
983+
edge.dst.valueChanged.emit()
984984

985985
def onAttributeClicked(self, attr):
986986
""" When an attribute is clicked, a specific function can be defined in the descriptor and be called.

0 commit comments

Comments
 (0)