Skip to content

Commit 2608695

Browse files
Apply suggestions from code review (Layout adjustment on connection and displayable icons)
Co-authored-by: Candice Bentéjac <candice.bentejac@gmail.com>
1 parent 2488f3e commit 2608695

1 file changed

Lines changed: 4 additions & 7 deletions

File tree

meshroom/ui/qml/GraphEditor/AttributeItemDelegate.qml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,8 @@ RowLayout {
6868
text: MaterialIcons.login
6969
enabled: shouldBeVisible
7070
font.pointSize: 8
71-
Layout.alignment: Qt.AlignTop | Qt.AlignLeft
72-
topPadding: 7
73-
opacity: shouldBeVisible ? 1: 0
71+
Layout.fillHeight: true
72+
visible: shouldBeVisible
7473

7574
MouseArea {
7675
anchors.fill: parent
@@ -214,8 +213,7 @@ RowLayout {
214213
enabled: isDisplayed
215214
visible: isDisplayable
216215

217-
Layout.alignment: Qt.AlignRight
218-
rightPadding: 5
216+
padding: 4
219217
font.pointSize: 8
220218
}
221219

@@ -227,8 +225,7 @@ RowLayout {
227225
text: MaterialIcons.logout
228226
font.pointSize: 8
229227
enabled: shouldBeVisible
230-
Layout.alignment: Qt.AlignRight
231-
topPadding: 5
228+
Layout.fillHeight: true
232229
visible: shouldBeVisible
233230

234231
MouseArea {

0 commit comments

Comments
 (0)